* [PATCH] ARM: dts: stm32: fix usart 2 & 3 pinconf to wake up with flow control
@ 2021-02-11 11:07 Valentin CARON - foss
2021-03-11 11:08 ` Alexandre TORGUE
0 siblings, 1 reply; 2+ messages in thread
From: Valentin CARON - foss @ 2021-02-11 11:07 UTC (permalink / raw)
To: Alexandre TORGUE - foss
Cc: devicetree, Erwan LE-RAY - foss, linux-kernel, Rob Herring,
Maxime Coquelin, linux-stm32, linux-arm-kernel
Modify usart 2 & 3 pins to allow wake up from low power mode while the
hardware flow control is activated. UART RTS pin need to stay configure
in idle mode to receive characters in order to wake up.
Fixes: 842ed898a757 ("ARM: dts: stm32: add usart2, usart3 and uart7 pins in stm32mp15-pinctrl")
Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
---
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 21 ++++++++++++++++++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
index 7b4249ed1983..060baa8b7e9d 100644
--- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
@@ -1891,10 +1891,15 @@
usart2_idle_pins_c: usart2-idle-2 {
pins1 {
pinmux = <STM32_PINMUX('D', 5, ANALOG)>, /* USART2_TX */
- <STM32_PINMUX('D', 4, ANALOG)>, /* USART2_RTS */
<STM32_PINMUX('D', 3, ANALOG)>; /* USART2_CTS_NSS */
};
pins2 {
+ pinmux = <STM32_PINMUX('D', 4, AF7)>; /* USART2_RTS */
+ bias-disable;
+ drive-push-pull;
+ slew-rate = <3>;
+ };
+ pins3 {
pinmux = <STM32_PINMUX('D', 6, AF7)>; /* USART2_RX */
bias-disable;
};
@@ -1940,10 +1945,15 @@
usart3_idle_pins_b: usart3-idle-1 {
pins1 {
pinmux = <STM32_PINMUX('B', 10, ANALOG)>, /* USART3_TX */
- <STM32_PINMUX('G', 8, ANALOG)>, /* USART3_RTS */
<STM32_PINMUX('I', 10, ANALOG)>; /* USART3_CTS_NSS */
};
pins2 {
+ pinmux = <STM32_PINMUX('G', 8, AF8)>; /* USART3_RTS */
+ bias-disable;
+ drive-push-pull;
+ slew-rate = <0>;
+ };
+ pins3 {
pinmux = <STM32_PINMUX('B', 12, AF8)>; /* USART3_RX */
bias-disable;
};
@@ -1976,10 +1986,15 @@
usart3_idle_pins_c: usart3-idle-2 {
pins1 {
pinmux = <STM32_PINMUX('B', 10, ANALOG)>, /* USART3_TX */
- <STM32_PINMUX('G', 8, ANALOG)>, /* USART3_RTS */
<STM32_PINMUX('B', 13, ANALOG)>; /* USART3_CTS_NSS */
};
pins2 {
+ pinmux = <STM32_PINMUX('G', 8, AF8)>; /* USART3_RTS */
+ bias-disable;
+ drive-push-pull;
+ slew-rate = <0>;
+ };
+ pins3 {
pinmux = <STM32_PINMUX('B', 12, AF8)>; /* USART3_RX */
bias-disable;
};
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: stm32: fix usart 2 & 3 pinconf to wake up with flow control
2021-02-11 11:07 [PATCH] ARM: dts: stm32: fix usart 2 & 3 pinconf to wake up with flow control Valentin CARON - foss
@ 2021-03-11 11:08 ` Alexandre TORGUE
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre TORGUE @ 2021-03-11 11:08 UTC (permalink / raw)
To: Valentin CARON - foss
Cc: Rob Herring, Maxime Coquelin, Erwan LE-RAY - foss, devicetree,
linux-stm32, linux-arm-kernel, linux-kernel
Hi Valentin
On 2/11/21 12:07 PM, Valentin CARON - foss wrote:
> Modify usart 2 & 3 pins to allow wake up from low power mode while the
> hardware flow control is activated. UART RTS pin need to stay configure
> in idle mode to receive characters in order to wake up.
>
> Fixes: 842ed898a757 ("ARM: dts: stm32: add usart2, usart3 and uart7 pins in stm32mp15-pinctrl")
>
> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
> ---
Applied on stm32-fixes.
Thanks
Alex
> arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 21 ++++++++++++++++++---
> 1 file changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> index 7b4249ed1983..060baa8b7e9d 100644
> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> @@ -1891,10 +1891,15 @@
> usart2_idle_pins_c: usart2-idle-2 {
> pins1 {
> pinmux = <STM32_PINMUX('D', 5, ANALOG)>, /* USART2_TX */
> - <STM32_PINMUX('D', 4, ANALOG)>, /* USART2_RTS */
> <STM32_PINMUX('D', 3, ANALOG)>; /* USART2_CTS_NSS */
> };
> pins2 {
> + pinmux = <STM32_PINMUX('D', 4, AF7)>; /* USART2_RTS */
> + bias-disable;
> + drive-push-pull;
> + slew-rate = <3>;
> + };
> + pins3 {
> pinmux = <STM32_PINMUX('D', 6, AF7)>; /* USART2_RX */
> bias-disable;
> };
> @@ -1940,10 +1945,15 @@
> usart3_idle_pins_b: usart3-idle-1 {
> pins1 {
> pinmux = <STM32_PINMUX('B', 10, ANALOG)>, /* USART3_TX */
> - <STM32_PINMUX('G', 8, ANALOG)>, /* USART3_RTS */
> <STM32_PINMUX('I', 10, ANALOG)>; /* USART3_CTS_NSS */
> };
> pins2 {
> + pinmux = <STM32_PINMUX('G', 8, AF8)>; /* USART3_RTS */
> + bias-disable;
> + drive-push-pull;
> + slew-rate = <0>;
> + };
> + pins3 {
> pinmux = <STM32_PINMUX('B', 12, AF8)>; /* USART3_RX */
> bias-disable;
> };
> @@ -1976,10 +1986,15 @@
> usart3_idle_pins_c: usart3-idle-2 {
> pins1 {
> pinmux = <STM32_PINMUX('B', 10, ANALOG)>, /* USART3_TX */
> - <STM32_PINMUX('G', 8, ANALOG)>, /* USART3_RTS */
> <STM32_PINMUX('B', 13, ANALOG)>; /* USART3_CTS_NSS */
> };
> pins2 {
> + pinmux = <STM32_PINMUX('G', 8, AF8)>; /* USART3_RTS */
> + bias-disable;
> + drive-push-pull;
> + slew-rate = <0>;
> + };
> + pins3 {
> pinmux = <STM32_PINMUX('B', 12, AF8)>; /* USART3_RX */
> bias-disable;
> };
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-11 11:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-11 11:07 [PATCH] ARM: dts: stm32: fix usart 2 & 3 pinconf to wake up with flow control Valentin CARON - foss
2021-03-11 11:08 ` Alexandre TORGUE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).