* [PATCH] arm64: dts: mediatek: fix reset GPIO level on pumpkin
@ 2021-02-23 22:18 Fabien Parent
2021-04-01 9:39 ` Matthias Brugger
0 siblings, 1 reply; 2+ messages in thread
From: Fabien Parent @ 2021-02-23 22:18 UTC (permalink / raw)
To: Matthias Brugger, Rob Herring, Krzysztof Kozlowski
Cc: devicetree, mkorpershoek, linux-kernel, Fabien Parent,
linux-mediatek, linux-arm-kernel
The tca6416 chip is active low. Fix the reset-gpios value.
Fixes: e2a8fa1e0faa ("arm64: dts: mediatek: fix tca6416 reset GPIOs in pumpkin")
Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
index 63fd70086bb8..9f27e7ed5e22 100644
--- a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
+++ b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
@@ -56,7 +56,7 @@ &i2c0 {
tca6416: gpio@20 {
compatible = "ti,tca6416";
reg = <0x20>;
- reset-gpios = <&pio 65 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&pio 65 GPIO_ACTIVE_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&tca6416_pins>;
--
2.30.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: fix reset GPIO level on pumpkin
2021-02-23 22:18 [PATCH] arm64: dts: mediatek: fix reset GPIO level on pumpkin Fabien Parent
@ 2021-04-01 9:39 ` Matthias Brugger
0 siblings, 0 replies; 2+ messages in thread
From: Matthias Brugger @ 2021-04-01 9:39 UTC (permalink / raw)
To: Fabien Parent, Rob Herring, Krzysztof Kozlowski
Cc: mkorpershoek, linux-arm-kernel, linux-mediatek, devicetree, linux-kernel
On 23/02/2021 23:18, Fabien Parent wrote:
> The tca6416 chip is active low. Fix the reset-gpios value.
>
> Fixes: e2a8fa1e0faa ("arm64: dts: mediatek: fix tca6416 reset GPIOs in pumpkin")
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
Applied to v5.12-next/dts64
Thanks!
> ---
> arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> index 63fd70086bb8..9f27e7ed5e22 100644
> --- a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> @@ -56,7 +56,7 @@ &i2c0 {
> tca6416: gpio@20 {
> compatible = "ti,tca6416";
> reg = <0x20>;
> - reset-gpios = <&pio 65 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&pio 65 GPIO_ACTIVE_LOW>;
> pinctrl-names = "default";
> pinctrl-0 = <&tca6416_pins>;
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-01 9:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 22:18 [PATCH] arm64: dts: mediatek: fix reset GPIO level on pumpkin Fabien Parent
2021-04-01 9:39 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).