* [PATCH v6 1/6] uapi: Define the aux vector AT_MINSIGSTKSZ
[not found] <20210227165911.32757-1-chang.seok.bae@intel.com>
@ 2021-02-27 16:59 ` Chang S. Bae
2021-03-01 19:09 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Chang S. Bae @ 2021-02-27 16:59 UTC (permalink / raw)
To: bp, tglx, mingo, luto, x86
Cc: linux-arch, len.brown, tony.luck, libc-alpha, ravi.v.shankar,
hjl.tools, carlos, mpe, chang.seok.bae, jannh, linux-kernel,
dave.hansen, linux-api, Dave.Martin, linux-arm-kernel
Define the AT_MINSIGSTKSZ in generic Linux. It is already used as generic
ABI in glibc's generic elf.h, and this define will prevent future namespace
conflicts. In particular, x86 is also using this generic definition.
Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
Reviewed-by: Len Brown <len.brown@intel.com>
Cc: Carlos O'Donell <carlos@redhat.com>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: libc-alpha@sourceware.org
Cc: linux-arch@vger.kernel.org
Cc: linux-api@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
Change from v5:
* Reverted the arm64 change. (Dave Martin)
* Massaged the changelog.
Change from v4:
* Added as a new patch (Carlos O'Donell)
---
include/uapi/linux/auxvec.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/uapi/linux/auxvec.h b/include/uapi/linux/auxvec.h
index abe5f2b6581b..15be98c75174 100644
--- a/include/uapi/linux/auxvec.h
+++ b/include/uapi/linux/auxvec.h
@@ -33,5 +33,8 @@
#define AT_EXECFN 31 /* filename of program */
+#ifndef AT_MINSIGSTKSZ
+#define AT_MINSIGSTKSZ 51 /* stack needed for signal delivery */
+#endif
#endif /* _UAPI_LINUX_AUXVEC_H */
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v6 1/6] uapi: Define the aux vector AT_MINSIGSTKSZ
2021-02-27 16:59 ` [PATCH v6 1/6] uapi: Define the aux vector AT_MINSIGSTKSZ Chang S. Bae
@ 2021-03-01 19:09 ` Borislav Petkov
2021-03-10 16:31 ` Bae, Chang Seok
0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2021-03-01 19:09 UTC (permalink / raw)
To: Chang S. Bae
Cc: linux-arch, len.brown, tony.luck, libc-alpha, jannh, hjl.tools,
carlos, mpe, x86, linux-kernel, Dave.Martin, dave.hansen, luto,
linux-api, tglx, mingo, linux-arm-kernel, ravi.v.shankar
On Sat, Feb 27, 2021 at 08:59:06AM -0800, Chang S. Bae wrote:
> Define the AT_MINSIGSTKSZ in generic Linux. It is already used as generic
> ABI in glibc's generic elf.h, and this define will prevent future namespace
> conflicts. In particular, x86 is also using this generic definition.
>
> Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
> Reviewed-by: Len Brown <len.brown@intel.com>
> Cc: Carlos O'Donell <carlos@redhat.com>
> Cc: Dave Martin <Dave.Martin@arm.com>
> Cc: libc-alpha@sourceware.org
> Cc: linux-arch@vger.kernel.org
> Cc: linux-api@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
> Change from v5:
> * Reverted the arm64 change. (Dave Martin)
> * Massaged the changelog.
>
> Change from v4:
> * Added as a new patch (Carlos O'Donell)
> ---
> include/uapi/linux/auxvec.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/uapi/linux/auxvec.h b/include/uapi/linux/auxvec.h
> index abe5f2b6581b..15be98c75174 100644
> --- a/include/uapi/linux/auxvec.h
> +++ b/include/uapi/linux/auxvec.h
> @@ -33,5 +33,8 @@
>
> #define AT_EXECFN 31 /* filename of program */
>
> +#ifndef AT_MINSIGSTKSZ
> +#define AT_MINSIGSTKSZ 51 /* stack needed for signal delivery */
I know glibc's comment says a similar thing but the correct thing to say
here should be "minimal stack size for signal delivery" or so. Even the
variable name alludes to that too.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v6 1/6] uapi: Define the aux vector AT_MINSIGSTKSZ
2021-03-01 19:09 ` Borislav Petkov
@ 2021-03-10 16:31 ` Bae, Chang Seok
0 siblings, 0 replies; 3+ messages in thread
From: Bae, Chang Seok @ 2021-03-10 16:31 UTC (permalink / raw)
To: Borislav Petkov
Cc: Thomas Gleixner, Ingo Molnar, Andy Lutomirski,
the arch/x86 maintainers, Brown, Len, Hansen, Dave, H.J. Lu,
Dave Martin, Jann Horn, Michael Ellerman, carlos, Luck, Tony,
Shankar, Ravi V, libc-alpha, linux-arch, Linux API, linux-kernel,
linux-arm-kernel
On Mar 1, 2021, at 11:09, Borislav Petkov <bp@suse.de> wrote:
> On Sat, Feb 27, 2021 at 08:59:06AM -0800, Chang S. Bae wrote:
>>
>> diff --git a/include/uapi/linux/auxvec.h b/include/uapi/linux/auxvec.h
>> index abe5f2b6581b..15be98c75174 100644
>> --- a/include/uapi/linux/auxvec.h
>> +++ b/include/uapi/linux/auxvec.h
>> @@ -33,5 +33,8 @@
>>
>> #define AT_EXECFN 31 /* filename of program */
>>
>> +#ifndef AT_MINSIGSTKSZ
>> +#define AT_MINSIGSTKSZ 51 /* stack needed for signal delivery */
>
> I know glibc's comment says a similar thing but the correct thing to say
> here should be "minimal stack size for signal delivery" or so. Even the
> variable name alludes to that too.
Yeah, you’re right.
Thanks,
Chang
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-10 16:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210227165911.32757-1-chang.seok.bae@intel.com>
2021-02-27 16:59 ` [PATCH v6 1/6] uapi: Define the aux vector AT_MINSIGSTKSZ Chang S. Bae
2021-03-01 19:09 ` Borislav Petkov
2021-03-10 16:31 ` Bae, Chang Seok
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).