linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] arm64: defconfig: Use DEBUG_INFO_REDUCED
@ 2021-03-04 17:44 Mark Brown
  2021-03-04 18:30 ` Will Deacon
  2021-03-15 19:13 ` Catalin Marinas
  0 siblings, 2 replies; 5+ messages in thread
From: Mark Brown @ 2021-03-04 17:44 UTC (permalink / raw)
  To: Will Deacon, Catalin Marinas
  Cc: linux-arm-kernel, Mark Brown, Guillaume Tucker, Kevin Hilman

We've had DEBUG_INFO enabled for arm64 defconfigs since the initial
commit.  This is probably not that frequently used but substantially
inflates the size of the build tree and amount of I/O needed during the
build.  This was causing issues with storage usage in some automated CI
environments which don't expect defconfigs to be quite this big, and
generally increases the resource consumption for both them and people
doing local builds.  The main use case for the debug info is decoding
things with scripts/faddr2line but that doesn't need the full
DEBUG_INFO, DEBUG_INFO_REDUCED is enough for it, so enable that by
default.

Without this patch my build tree is 6.8G, with it the size drops to 2G
(smaller than the 6.4G for allmodconfig!).

Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
Reported-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Acked-by: Kevin Hilman <khilman@baylibre.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index d612f633b771..8793a9cb9d4b 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1156,6 +1156,7 @@ CONFIG_CRYPTO_DEV_HISI_TRNG=m
 CONFIG_CMA_SIZE_MBYTES=32
 CONFIG_PRINTK_TIME=y
 CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_INFO_REDUCED=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_FS=y
 CONFIG_DEBUG_KERNEL=y
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] arm64: defconfig: Use DEBUG_INFO_REDUCED
  2021-03-04 17:44 [PATCH v2] arm64: defconfig: Use DEBUG_INFO_REDUCED Mark Brown
@ 2021-03-04 18:30 ` Will Deacon
  2021-03-04 18:33   ` Mark Brown
  2021-03-15 19:13 ` Catalin Marinas
  1 sibling, 1 reply; 5+ messages in thread
From: Will Deacon @ 2021-03-04 18:30 UTC (permalink / raw)
  To: Mark Brown
  Cc: Catalin Marinas, linux-arm-kernel, Guillaume Tucker, Kevin Hilman

On Thu, Mar 04, 2021 at 05:44:07PM +0000, Mark Brown wrote:
> We've had DEBUG_INFO enabled for arm64 defconfigs since the initial
> commit.  This is probably not that frequently used but substantially
> inflates the size of the build tree and amount of I/O needed during the
> build.  This was causing issues with storage usage in some automated CI
> environments which don't expect defconfigs to be quite this big, and
> generally increases the resource consumption for both them and people
> doing local builds.  The main use case for the debug info is decoding
> things with scripts/faddr2line but that doesn't need the full
> DEBUG_INFO, DEBUG_INFO_REDUCED is enough for it, so enable that by
> default.
> 
> Without this patch my build tree is 6.8G, with it the size drops to 2G
> (smaller than the 6.4G for allmodconfig!).
> 
> Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
> Reported-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Acked-by: Kevin Hilman <khilman@baylibre.com>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index d612f633b771..8793a9cb9d4b 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1156,6 +1156,7 @@ CONFIG_CRYPTO_DEV_HISI_TRNG=m
>  CONFIG_CMA_SIZE_MBYTES=32
>  CONFIG_PRINTK_TIME=y
>  CONFIG_DEBUG_INFO=y
> +CONFIG_DEBUG_INFO_REDUCED=y
>  CONFIG_MAGIC_SYSRQ=y
>  CONFIG_DEBUG_FS=y
>  CONFIG_DEBUG_KERNEL=y

I gave this a spin with clang and it looks alright! Are you targetting 5.12
with this or can it wait until 5.13? I can't tell how big a deal it is on
the CI side of things.

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] arm64: defconfig: Use DEBUG_INFO_REDUCED
  2021-03-04 18:30 ` Will Deacon
@ 2021-03-04 18:33   ` Mark Brown
  2021-03-04 18:49     ` Will Deacon
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2021-03-04 18:33 UTC (permalink / raw)
  To: Will Deacon
  Cc: Catalin Marinas, linux-arm-kernel, Guillaume Tucker, Kevin Hilman


[-- Attachment #1.1: Type: text/plain, Size: 367 bytes --]

On Thu, Mar 04, 2021 at 06:30:34PM +0000, Will Deacon wrote:

> I gave this a spin with clang and it looks alright! Are you targetting 5.12
> with this or can it wait until 5.13? I can't tell how big a deal it is on
> the CI side of things.

v5.13 should be fine, it's more annoying for CI users than anything else
I think - KernelCI certainly dealt with it already.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] arm64: defconfig: Use DEBUG_INFO_REDUCED
  2021-03-04 18:33   ` Mark Brown
@ 2021-03-04 18:49     ` Will Deacon
  0 siblings, 0 replies; 5+ messages in thread
From: Will Deacon @ 2021-03-04 18:49 UTC (permalink / raw)
  To: Mark Brown
  Cc: Catalin Marinas, linux-arm-kernel, Guillaume Tucker, Kevin Hilman

On Thu, Mar 04, 2021 at 06:33:26PM +0000, Mark Brown wrote:
> On Thu, Mar 04, 2021 at 06:30:34PM +0000, Will Deacon wrote:
> 
> > I gave this a spin with clang and it looks alright! Are you targetting 5.12
> > with this or can it wait until 5.13? I can't tell how big a deal it is on
> > the CI side of things.
> 
> v5.13 should be fine, it's more annoying for CI users than anything else
> I think - KernelCI certainly dealt with it already.

Ok, in which case:

Acked-by: Will Deacon <will@kernel.org>

and I'll leave it to Catalin.

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] arm64: defconfig: Use DEBUG_INFO_REDUCED
  2021-03-04 17:44 [PATCH v2] arm64: defconfig: Use DEBUG_INFO_REDUCED Mark Brown
  2021-03-04 18:30 ` Will Deacon
@ 2021-03-15 19:13 ` Catalin Marinas
  1 sibling, 0 replies; 5+ messages in thread
From: Catalin Marinas @ 2021-03-15 19:13 UTC (permalink / raw)
  To: Mark Brown, Will Deacon; +Cc: linux-arm-kernel, Guillaume Tucker, Kevin Hilman

On Thu, 4 Mar 2021 17:44:07 +0000, Mark Brown wrote:
> We've had DEBUG_INFO enabled for arm64 defconfigs since the initial
> commit.  This is probably not that frequently used but substantially
> inflates the size of the build tree and amount of I/O needed during the
> build.  This was causing issues with storage usage in some automated CI
> environments which don't expect defconfigs to be quite this big, and
> generally increases the resource consumption for both them and people
> doing local builds.  The main use case for the debug info is decoding
> things with scripts/faddr2line but that doesn't need the full
> DEBUG_INFO, DEBUG_INFO_REDUCED is enough for it, so enable that by
> default.
> 
> [...]

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64: defconfig: Use DEBUG_INFO_REDUCED
      https://git.kernel.org/arm64/c/ed938a4bfc58

-- 
Catalin


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-03-15 19:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-04 17:44 [PATCH v2] arm64: defconfig: Use DEBUG_INFO_REDUCED Mark Brown
2021-03-04 18:30 ` Will Deacon
2021-03-04 18:33   ` Mark Brown
2021-03-04 18:49     ` Will Deacon
2021-03-15 19:13 ` Catalin Marinas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).