* [PATCH] ARM: decompressor: remove unused global variable output_data
@ 2021-03-08 14:29 Rasmus Villemoes
2021-03-18 12:45 ` Rasmus Villemoes
0 siblings, 1 reply; 2+ messages in thread
From: Rasmus Villemoes @ 2021-03-08 14:29 UTC (permalink / raw)
To: Russell King; +Cc: Rasmus Villemoes, linux-arm-kernel, linux-kernel
output_data seems to have been write-only since the flush_window()
callback was removed in commit e7db7b4270ed ("arm: add support for
LZO-compressed kernels").
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
arch/arm/boot/compressed/misc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm/boot/compressed/misc.c b/arch/arm/boot/compressed/misc.c
index e1e9a5dde853..fdef4d413d24 100644
--- a/arch/arm/boot/compressed/misc.c
+++ b/arch/arm/boot/compressed/misc.c
@@ -103,8 +103,6 @@ static void putstr(const char *ptr)
extern char input_data[];
extern char input_data_end[];
-unsigned char *output_data;
-
unsigned long free_mem_ptr;
unsigned long free_mem_end_ptr;
@@ -145,7 +143,6 @@ decompress_kernel(unsigned long output_start, unsigned long free_mem_ptr_p,
{
int ret;
- output_data = (unsigned char *)output_start;
free_mem_ptr = free_mem_ptr_p;
free_mem_end_ptr = free_mem_ptr_end_p;
__machine_arch_type = arch_id;
@@ -154,7 +151,7 @@ decompress_kernel(unsigned long output_start, unsigned long free_mem_ptr_p,
putstr("Uncompressing Linux...");
ret = do_decompress(input_data, input_data_end - input_data,
- output_data, error);
+ (u8 *)output_start, error);
if (ret)
error("decompressor returned an error");
else
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: decompressor: remove unused global variable output_data
2021-03-08 14:29 [PATCH] ARM: decompressor: remove unused global variable output_data Rasmus Villemoes
@ 2021-03-18 12:45 ` Rasmus Villemoes
0 siblings, 0 replies; 2+ messages in thread
From: Rasmus Villemoes @ 2021-03-18 12:45 UTC (permalink / raw)
To: Russell King; +Cc: linux-arm-kernel, linux-kernel
On 08/03/2021 15.29, Rasmus Villemoes wrote:
> output_data seems to have been write-only since the flush_window()
> callback was removed in commit e7db7b4270ed ("arm: add support for
> LZO-compressed kernels").
Ping.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-18 12:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 14:29 [PATCH] ARM: decompressor: remove unused global variable output_data Rasmus Villemoes
2021-03-18 12:45 ` Rasmus Villemoes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).