From: Andre Przywara <andre.przywara@arm.com>
To: Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Shuah Khan <shuah@kernel.org>
Cc: Amit Daniel Kachhap <amit.kachhap@arm.com>,
Mark Brown <broonie@kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com
Subject: [PATCH 10/11] kselftest/arm64: mte: Fix clang warning
Date: Fri, 19 Mar 2021 16:53:33 +0000 [thread overview]
Message-ID: <20210319165334.29213-11-andre.przywara@arm.com> (raw)
In-Reply-To: <20210319165334.29213-1-andre.przywara@arm.com>
if (!prctl(...) == 0) is not only cumbersome to read, it also upsets
clang and triggers a warning:
------------
mte_common_util.c:287:6: warning: logical not is only applied to the
left hand side of this comparison [-Wlogical-not-parentheses]
....
Fix that by just comparing against "not 0" instead.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
tools/testing/selftests/arm64/mte/mte_common_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/arm64/mte/mte_common_util.c b/tools/testing/selftests/arm64/mte/mte_common_util.c
index aa8a8a6b8b6d..040abdca079d 100644
--- a/tools/testing/selftests/arm64/mte/mte_common_util.c
+++ b/tools/testing/selftests/arm64/mte/mte_common_util.c
@@ -284,7 +284,7 @@ int mte_switch_mode(int mte_option, unsigned long incl_mask)
en |= (incl_mask << PR_MTE_TAG_SHIFT);
/* Enable address tagging ABI, mte error reporting mode and tag inclusion mask. */
- if (!prctl(PR_SET_TAGGED_ADDR_CTRL, en, 0, 0, 0) == 0) {
+ if (prctl(PR_SET_TAGGED_ADDR_CTRL, en, 0, 0, 0) != 0) {
ksft_print_msg("FAIL:prctl PR_SET_TAGGED_ADDR_CTRL for mte mode\n");
return -EINVAL;
}
--
2.17.5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-19 16:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 16:53 [PATCH 00/11] kselftest/arm64: mte: Fix feature detection and compilation Andre Przywara
2021-03-19 16:53 ` [PATCH 01/11] kselftest/arm64: mte: Fix compilation with native compiler Andre Przywara
2021-03-19 17:29 ` Nick Desaulniers
2021-03-19 16:53 ` [PATCH 02/11] kselftest/arm64: mte: Fix pthread linking Andre Przywara
2021-03-19 16:53 ` [PATCH 03/11] kselftest/arm64: mte: ksm_options: Fix fscanf warning Andre Przywara
2021-03-19 16:53 ` [PATCH 04/11] kselftest/arm64: mte: user_mem: Fix write() warning Andre Przywara
2021-03-19 16:53 ` [PATCH 05/11] kselftest/arm64: mte: common: Fix write() warnings Andre Przywara
2021-03-19 16:53 ` [PATCH 06/11] kselftest/arm64: mte: Fix MTE feature detection Andre Przywara
2021-03-19 16:53 ` [PATCH 07/11] kselftest/arm64: mte: Use cross-compiler if specified Andre Przywara
2021-03-19 16:53 ` [PATCH 08/11] kselftest/arm64: mte: Output warning about failing compiler Andre Przywara
2021-03-19 16:53 ` [PATCH 09/11] kselftest/arm64: mte: Makefile: Fix clang compilation Andre Przywara
2021-03-19 16:53 ` Andre Przywara [this message]
2021-03-19 17:36 ` [PATCH 10/11] kselftest/arm64: mte: Fix clang warning Nick Desaulniers
2021-03-19 16:53 ` [PATCH 11/11] kselftest/arm64: mte: Report filename on failing temp file creation Andre Przywara
2021-03-19 17:12 ` [PATCH 00/11] kselftest/arm64: mte: Fix feature detection and compilation Mark Brown
2021-03-23 17:54 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319165334.29213-11-andre.przywara@arm.com \
--to=andre.przywara@arm.com \
--cc=amit.kachhap@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=shuah@kernel.org \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).