* [PATCH 2/7] dt-bindigns: regulator: mtk: Drop unneeded compatible
2021-03-12 14:55 [PATCH 1/7] dt-bindings: mfd: mediatek: Fix regulator description matthias.bgg
@ 2021-03-12 14:55 ` matthias.bgg
2021-03-18 14:11 ` Enric Balletbo Serra
2021-03-12 14:55 ` [PATCH 3/7] mfd: mt6397: Drop of_compatible for regulator matthias.bgg
` (5 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: matthias.bgg @ 2021-03-12 14:55 UTC (permalink / raw)
To: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie
Cc: devicetree, linux-mediatek, linux-kernel, linux-arm-kernel,
Matthias Brugger
From: Matthias Brugger <mbrugger@suse.com>
The regulator does not need to have a device tree compatible, if it's
part of an MFD. We leave the node name to the SoC specific name (e.g.
mt6323regulator) to allow older kernels to work with the new binding.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
.../bindings/regulator/mt6323-regulator.txt | 2 +-
.../bindings/regulator/mt6358-regulator.txt | 4 +---
.../bindings/regulator/mt6397-regulator.txt | 14 +++++---------
3 files changed, 7 insertions(+), 13 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
index a48749db4df36..69f32e1a6702e 100644
--- a/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
@@ -19,7 +19,7 @@ LDO:
Example:
pmic: mt6323 {
- mt6323regulator: regulators {
+ mt6323regulator {
mt6323_vproc_reg: buck_vproc{
regulator-name = "vproc";
regulator-min-microvolt = < 700000>;
diff --git a/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt
index 9a90a92f2d7e1..ba1214da5bf7c 100644
--- a/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt
@@ -23,9 +23,7 @@ Example:
pmic {
compatible = "mediatek,mt6358";
- mt6358regulator: mt6358regulator {
- compatible = "mediatek,mt6358-regulator";
-
+ mt6358regulator {
mt6358_vdram1_reg: buck_vdram1 {
regulator-compatible = "buck_vdram1";
regulator-name = "vdram1";
diff --git a/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt
index c080086d3e629..2b14362ac56e1 100644
--- a/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt
@@ -1,11 +1,9 @@
Mediatek MT6397 Regulator
-Required properties:
-- compatible: "mediatek,mt6397-regulator"
-- mt6397regulator: List of regulators provided by this controller. It is named
- according to its regulator type, buck_<name> and ldo_<name>.
- The definition for each of these nodes is defined using the standard binding
- for regulators at Documentation/devicetree/bindings/regulator/regulator.txt.
+List of regulators provided by this controller. It is named
+according to its regulator type, buck_<name> and ldo_<name>.
+The definition for each of these nodes is defined using the standard binding
+for regulators at Documentation/devicetree/bindings/regulator/regulator.txt.
The valid names for regulators are::
BUCK:
@@ -23,9 +21,7 @@ Example:
pmic {
compatible = "mediatek,mt6397";
- mt6397regulator: mt6397regulator {
- compatible = "mediatek,mt6397-regulator";
-
+ mt6397regulator {
mt6397_vpca15_reg: buck_vpca15 {
regulator-compatible = "buck_vpca15";
regulator-name = "vpca15";
--
2.30.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 2/7] dt-bindigns: regulator: mtk: Drop unneeded compatible
2021-03-12 14:55 ` [PATCH 2/7] dt-bindigns: regulator: mtk: Drop unneeded compatible matthias.bgg
@ 2021-03-18 14:11 ` Enric Balletbo Serra
2021-03-24 16:16 ` Rob Herring
0 siblings, 1 reply; 13+ messages in thread
From: Enric Balletbo Serra @ 2021-03-18 14:11 UTC (permalink / raw)
To: matthias.bgg
Cc: Lee Jones, Rob Herring, Matthias Brugger, Liam Girdwood,
Mark Brown, devicetree, moderated list:ARM/Mediatek SoC support,
linux-kernel, Linux ARM, Matthias Brugger
Hi Matthias,
Thank you for your patch. There is a typo in the subject line
s/dt-bindigns/dt-bindings/ Rob might miss this patch as he filters the
patches by subject I guess.
Missatge de l'adreça <matthias.bgg@kernel.org> del dia dv., 12 de març
2021 a les 15:57:
>
> From: Matthias Brugger <mbrugger@suse.com>
>
> The regulator does not need to have a device tree compatible, if it's
> part of an MFD. We leave the node name to the SoC specific name (e.g.
> mt6323regulator) to allow older kernels to work with the new binding.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
> .../bindings/regulator/mt6323-regulator.txt | 2 +-
> .../bindings/regulator/mt6358-regulator.txt | 4 +---
> .../bindings/regulator/mt6397-regulator.txt | 14 +++++---------
> 3 files changed, 7 insertions(+), 13 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
> index a48749db4df36..69f32e1a6702e 100644
> --- a/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
> @@ -19,7 +19,7 @@ LDO:
> Example:
>
> pmic: mt6323 {
> - mt6323regulator: regulators {
> + mt6323regulator {
If you convert this binding to YAML, you'll probably get a review that
the node name must be just 'regulators' here. And then, looking at the
other patches something will break I guess ...
> mt6323_vproc_reg: buck_vproc{
> regulator-name = "vproc";
> regulator-min-microvolt = < 700000>;
> diff --git a/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt
> index 9a90a92f2d7e1..ba1214da5bf7c 100644
> --- a/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt
> @@ -23,9 +23,7 @@ Example:
> pmic {
> compatible = "mediatek,mt6358";
>
> - mt6358regulator: mt6358regulator {
> - compatible = "mediatek,mt6358-regulator";
> -
> + mt6358regulator {
> mt6358_vdram1_reg: buck_vdram1 {
> regulator-compatible = "buck_vdram1";
> regulator-name = "vdram1";
> diff --git a/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt
> index c080086d3e629..2b14362ac56e1 100644
> --- a/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt
> @@ -1,11 +1,9 @@
> Mediatek MT6397 Regulator
>
> -Required properties:
> -- compatible: "mediatek,mt6397-regulator"
> -- mt6397regulator: List of regulators provided by this controller. It is named
> - according to its regulator type, buck_<name> and ldo_<name>.
> - The definition for each of these nodes is defined using the standard binding
> - for regulators at Documentation/devicetree/bindings/regulator/regulator.txt.
> +List of regulators provided by this controller. It is named
> +according to its regulator type, buck_<name> and ldo_<name>.
> +The definition for each of these nodes is defined using the standard binding
> +for regulators at Documentation/devicetree/bindings/regulator/regulator.txt.
>
> The valid names for regulators are::
> BUCK:
> @@ -23,9 +21,7 @@ Example:
> pmic {
> compatible = "mediatek,mt6397";
>
> - mt6397regulator: mt6397regulator {
> - compatible = "mediatek,mt6397-regulator";
> -
> + mt6397regulator {
> mt6397_vpca15_reg: buck_vpca15 {
> regulator-compatible = "buck_vpca15";
> regulator-name = "vpca15";
> --
> 2.30.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 2/7] dt-bindigns: regulator: mtk: Drop unneeded compatible
2021-03-18 14:11 ` Enric Balletbo Serra
@ 2021-03-24 16:16 ` Rob Herring
0 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2021-03-24 16:16 UTC (permalink / raw)
To: Enric Balletbo Serra
Cc: matthias.bgg, Lee Jones, Matthias Brugger, Liam Girdwood,
Mark Brown, devicetree, moderated list:ARM/Mediatek SoC support,
linux-kernel, Linux ARM, Matthias Brugger
On Thu, Mar 18, 2021 at 03:11:56PM +0100, Enric Balletbo Serra wrote:
> Hi Matthias,
>
> Thank you for your patch. There is a typo in the subject line
> s/dt-bindigns/dt-bindings/ Rob might miss this patch as he filters the
> patches by subject I guess.
I should, then I'd have a lot less to review...
>
> Missatge de l'adreça <matthias.bgg@kernel.org> del dia dv., 12 de març
> 2021 a les 15:57:
> >
> > From: Matthias Brugger <mbrugger@suse.com>
> >
> > The regulator does not need to have a device tree compatible, if it's
> > part of an MFD. We leave the node name to the SoC specific name (e.g.
> > mt6323regulator) to allow older kernels to work with the new binding.
> >
> > Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> > ---
> > .../bindings/regulator/mt6323-regulator.txt | 2 +-
> > .../bindings/regulator/mt6358-regulator.txt | 4 +---
> > .../bindings/regulator/mt6397-regulator.txt | 14 +++++---------
> > 3 files changed, 7 insertions(+), 13 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
> > index a48749db4df36..69f32e1a6702e 100644
> > --- a/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
> > +++ b/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt
> > @@ -19,7 +19,7 @@ LDO:
> > Example:
> >
> > pmic: mt6323 {
This one is wrong...
> > - mt6323regulator: regulators {
> > + mt6323regulator {
And this was right.
>
> If you convert this binding to YAML, you'll probably get a review that
> the node name must be just 'regulators' here. And then, looking at the
> other patches something will break I guess ...
>
> > mt6323_vproc_reg: buck_vproc{
> > regulator-name = "vproc";
> > regulator-min-microvolt = < 700000>;
> > diff --git a/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt
> > index 9a90a92f2d7e1..ba1214da5bf7c 100644
> > --- a/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt
> > +++ b/Documentation/devicetree/bindings/regulator/mt6358-regulator.txt
> > @@ -23,9 +23,7 @@ Example:
> > pmic {
> > compatible = "mediatek,mt6358";
> >
> > - mt6358regulator: mt6358regulator {
> > - compatible = "mediatek,mt6358-regulator";
> > -
> > + mt6358regulator {
> > mt6358_vdram1_reg: buck_vdram1 {
> > regulator-compatible = "buck_vdram1";
> > regulator-name = "vdram1";
> > diff --git a/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt
> > index c080086d3e629..2b14362ac56e1 100644
> > --- a/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt
> > +++ b/Documentation/devicetree/bindings/regulator/mt6397-regulator.txt
> > @@ -1,11 +1,9 @@
> > Mediatek MT6397 Regulator
> >
> > -Required properties:
> > -- compatible: "mediatek,mt6397-regulator"
> > -- mt6397regulator: List of regulators provided by this controller. It is named
> > - according to its regulator type, buck_<name> and ldo_<name>.
> > - The definition for each of these nodes is defined using the standard binding
> > - for regulators at Documentation/devicetree/bindings/regulator/regulator.txt.
> > +List of regulators provided by this controller. It is named
> > +according to its regulator type, buck_<name> and ldo_<name>.
> > +The definition for each of these nodes is defined using the standard binding
> > +for regulators at Documentation/devicetree/bindings/regulator/regulator.txt.
> >
> > The valid names for regulators are::
> > BUCK:
> > @@ -23,9 +21,7 @@ Example:
> > pmic {
> > compatible = "mediatek,mt6397";
> >
> > - mt6397regulator: mt6397regulator {
> > - compatible = "mediatek,mt6397-regulator";
> > -
> > + mt6397regulator {
> > mt6397_vpca15_reg: buck_vpca15 {
> > regulator-compatible = "buck_vpca15";
> > regulator-name = "vpca15";
> > --
> > 2.30.1
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 3/7] mfd: mt6397: Drop of_compatible for regulator
2021-03-12 14:55 [PATCH 1/7] dt-bindings: mfd: mediatek: Fix regulator description matthias.bgg
2021-03-12 14:55 ` [PATCH 2/7] dt-bindigns: regulator: mtk: Drop unneeded compatible matthias.bgg
@ 2021-03-12 14:55 ` matthias.bgg
2021-03-23 9:05 ` Lee Jones
2021-03-12 14:55 ` [PATCH 4/7] regulator: mediatek: Add regulators_node to description matthias.bgg
` (4 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: matthias.bgg @ 2021-03-12 14:55 UTC (permalink / raw)
To: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie
Cc: devicetree, linux-mediatek, linux-kernel, linux-arm-kernel,
Matthias Brugger
From: Matthias Brugger <mbrugger@suse.com>
For regulators a compatible string is superfluous. Drop the string.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
drivers/mfd/mt6397-core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
index 7518d74c3b4c3..13037f4bc54e7 100644
--- a/drivers/mfd/mt6397-core.c
+++ b/drivers/mfd/mt6397-core.c
@@ -67,7 +67,6 @@ static const struct mfd_cell mt6323_devs[] = {
.of_compatible = "mediatek,mt6323-rtc",
}, {
.name = "mt6323-regulator",
- .of_compatible = "mediatek,mt6323-regulator"
}, {
.name = "mt6323-led",
.of_compatible = "mediatek,mt6323-led"
@@ -87,7 +86,6 @@ static const struct mfd_cell mt6323_devs[] = {
static const struct mfd_cell mt6358_devs[] = {
{
.name = "mt6358-regulator",
- .of_compatible = "mediatek,mt6358-regulator"
}, {
.name = "mt6358-rtc",
.num_resources = ARRAY_SIZE(mt6358_rtc_resources),
@@ -107,7 +105,6 @@ static const struct mfd_cell mt6397_devs[] = {
.of_compatible = "mediatek,mt6397-rtc",
}, {
.name = "mt6397-regulator",
- .of_compatible = "mediatek,mt6397-regulator",
}, {
.name = "mt6397-codec",
.of_compatible = "mediatek,mt6397-codec",
--
2.30.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 3/7] mfd: mt6397: Drop of_compatible for regulator
2021-03-12 14:55 ` [PATCH 3/7] mfd: mt6397: Drop of_compatible for regulator matthias.bgg
@ 2021-03-23 9:05 ` Lee Jones
0 siblings, 0 replies; 13+ messages in thread
From: Lee Jones @ 2021-03-23 9:05 UTC (permalink / raw)
To: matthias.bgg
Cc: robh+dt, matthias.bgg, lgirdwood, broonie, devicetree,
linux-mediatek, linux-kernel, linux-arm-kernel, Matthias Brugger
On Fri, 12 Mar 2021, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> For regulators a compatible string is superfluous. Drop the string.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
> drivers/mfd/mt6397-core.c | 3 ---
> 1 file changed, 3 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 4/7] regulator: mediatek: Add regulators_node to description
2021-03-12 14:55 [PATCH 1/7] dt-bindings: mfd: mediatek: Fix regulator description matthias.bgg
2021-03-12 14:55 ` [PATCH 2/7] dt-bindigns: regulator: mtk: Drop unneeded compatible matthias.bgg
2021-03-12 14:55 ` [PATCH 3/7] mfd: mt6397: Drop of_compatible for regulator matthias.bgg
@ 2021-03-12 14:55 ` matthias.bgg
2021-03-18 13:31 ` Mark Brown
2021-03-12 14:55 ` [PATCH 5/7] arm: dts: mt6323: Drop OF compatible matthias.bgg
` (3 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: matthias.bgg @ 2021-03-12 14:55 UTC (permalink / raw)
To: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie
Cc: devicetree, linux-mediatek, linux-kernel, linux-arm-kernel,
Matthias Brugger
From: Matthias Brugger <mbrugger@suse.com>
Define the regulator node under which the regulators are described.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
drivers/regulator/mt6323-regulator.c | 3 +++
drivers/regulator/mt6358-regulator.c | 4 ++++
drivers/regulator/mt6397-regulator.c | 10 +++-------
3 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/regulator/mt6323-regulator.c b/drivers/regulator/mt6323-regulator.c
index ff9016170db37..8b22ded43ab8a 100644
--- a/drivers/regulator/mt6323-regulator.c
+++ b/drivers/regulator/mt6323-regulator.c
@@ -42,6 +42,7 @@ struct mt6323_regulator_info {
.desc = { \
.name = #vreg, \
.of_match = of_match_ptr(match), \
+ .regulators_node = of_match_ptr("mt6323regulator"), \
.ops = &mt6323_volt_range_ops, \
.type = REGULATOR_VOLTAGE, \
.id = MT6323_ID_##vreg, \
@@ -66,6 +67,7 @@ struct mt6323_regulator_info {
.desc = { \
.name = #vreg, \
.of_match = of_match_ptr(match), \
+ .regulators_node = of_match_ptr("mt6323regulator"), \
.ops = &mt6323_volt_table_ops, \
.type = REGULATOR_VOLTAGE, \
.id = MT6323_ID_##vreg, \
@@ -88,6 +90,7 @@ struct mt6323_regulator_info {
.desc = { \
.name = #vreg, \
.of_match = of_match_ptr(match), \
+ .regulators_node = of_match_ptr("mt6323regulator"), \
.ops = &mt6323_volt_fixed_ops, \
.type = REGULATOR_VOLTAGE, \
.id = MT6323_ID_##vreg, \
diff --git a/drivers/regulator/mt6358-regulator.c b/drivers/regulator/mt6358-regulator.c
index 13cb6ac9a8929..f5c478d7baaf2 100644
--- a/drivers/regulator/mt6358-regulator.c
+++ b/drivers/regulator/mt6358-regulator.c
@@ -44,6 +44,7 @@ struct mt6358_regulator_info {
.desc = { \
.name = #vreg, \
.of_match = of_match_ptr(match), \
+ .regulators_node = of_match_ptr("mt6358regulator"), \
.ops = &mt6358_volt_range_ops, \
.type = REGULATOR_VOLTAGE, \
.id = MT6358_ID_##vreg, \
@@ -74,6 +75,7 @@ struct mt6358_regulator_info {
.desc = { \
.name = #vreg, \
.of_match = of_match_ptr(match), \
+ .regulators_node = of_match_ptr("mt6358regulator"), \
.ops = &mt6358_volt_table_ops, \
.type = REGULATOR_VOLTAGE, \
.id = MT6358_ID_##vreg, \
@@ -99,6 +101,7 @@ struct mt6358_regulator_info {
.desc = { \
.name = #vreg, \
.of_match = of_match_ptr(match), \
+ .regulators_node = of_match_ptr("mt6358regulator"), \
.ops = &mt6358_volt_range_ops, \
.type = REGULATOR_VOLTAGE, \
.id = MT6358_ID_##vreg, \
@@ -124,6 +127,7 @@ struct mt6358_regulator_info {
.desc = { \
.name = #vreg, \
.of_match = of_match_ptr(match), \
+ .regulators_node = of_match_ptr("mt6358regulator"), \
.ops = &mt6358_volt_fixed_ops, \
.type = REGULATOR_VOLTAGE, \
.id = MT6358_ID_##vreg, \
diff --git a/drivers/regulator/mt6397-regulator.c b/drivers/regulator/mt6397-regulator.c
index 0a30df5e414fc..9e8589f773eaa 100644
--- a/drivers/regulator/mt6397-regulator.c
+++ b/drivers/regulator/mt6397-regulator.c
@@ -42,6 +42,7 @@ struct mt6397_regulator_info {
.desc = { \
.name = #vreg, \
.of_match = of_match_ptr(match), \
+ .regulators_node = of_match_ptr("mt6397regulator"), \
.ops = &mt6397_volt_range_ops, \
.type = REGULATOR_VOLTAGE, \
.id = MT6397_ID_##vreg, \
@@ -70,6 +71,7 @@ struct mt6397_regulator_info {
.desc = { \
.name = #vreg, \
.of_match = of_match_ptr(match), \
+ .regulators_node = of_match_ptr("mt6397regulator"), \
.ops = &mt6397_volt_table_ops, \
.type = REGULATOR_VOLTAGE, \
.id = MT6397_ID_##vreg, \
@@ -89,6 +91,7 @@ struct mt6397_regulator_info {
.desc = { \
.name = #vreg, \
.of_match = of_match_ptr(match), \
+ .regulators_node = of_match_ptr("mt6397regulator"), \
.ops = &mt6397_volt_fixed_ops, \
.type = REGULATOR_VOLTAGE, \
.id = MT6397_ID_##vreg, \
@@ -396,16 +399,9 @@ static const struct platform_device_id mt6397_platform_ids[] = {
};
MODULE_DEVICE_TABLE(platform, mt6397_platform_ids);
-static const struct of_device_id mt6397_of_match[] = {
- { .compatible = "mediatek,mt6397-regulator", },
- { /* sentinel */ },
-};
-MODULE_DEVICE_TABLE(of, mt6397_of_match);
-
static struct platform_driver mt6397_regulator_driver = {
.driver = {
.name = "mt6397-regulator",
- .of_match_table = of_match_ptr(mt6397_of_match),
},
.probe = mt6397_regulator_probe,
.id_table = mt6397_platform_ids,
--
2.30.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 4/7] regulator: mediatek: Add regulators_node to description
2021-03-12 14:55 ` [PATCH 4/7] regulator: mediatek: Add regulators_node to description matthias.bgg
@ 2021-03-18 13:31 ` Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2021-03-18 13:31 UTC (permalink / raw)
To: matthias.bgg
Cc: lee.jones, robh+dt, matthias.bgg, lgirdwood, devicetree,
linux-mediatek, linux-kernel, linux-arm-kernel, Matthias Brugger
[-- Attachment #1.1: Type: text/plain, Size: 240 bytes --]
On Fri, Mar 12, 2021 at 03:55:42PM +0100, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Define the regulator node under which the regulators are described.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 5/7] arm: dts: mt6323: Drop OF compatible
2021-03-12 14:55 [PATCH 1/7] dt-bindings: mfd: mediatek: Fix regulator description matthias.bgg
` (2 preceding siblings ...)
2021-03-12 14:55 ` [PATCH 4/7] regulator: mediatek: Add regulators_node to description matthias.bgg
@ 2021-03-12 14:55 ` matthias.bgg
2021-03-12 14:55 ` [PATCH 6/7] arm64: dts: mt6358: Drop compatible for regulators matthias.bgg
` (2 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: matthias.bgg @ 2021-03-12 14:55 UTC (permalink / raw)
To: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie
Cc: devicetree, linux-mediatek, linux-kernel, linux-arm-kernel,
Matthias Brugger
From: Matthias Brugger <mbrugger@suse.com>
The regulator framework does not need compatible, it's acutall
superfluous. Drop it from the DT.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
arch/arm/boot/dts/mt6323.dtsi | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/mt6323.dtsi b/arch/arm/boot/dts/mt6323.dtsi
index 7fda40ab5fe83..d37f118a663a9 100644
--- a/arch/arm/boot/dts/mt6323.dtsi
+++ b/arch/arm/boot/dts/mt6323.dtsi
@@ -21,9 +21,7 @@ mt6323_leds: leds {
status = "disabled";
};
- mt6323regulator: mt6323regulator{
- compatible = "mediatek,mt6323-regulator";
-
+ mt6323regulator {
mt6323_vproc_reg: buck_vproc{
regulator-name = "vproc";
regulator-min-microvolt = < 700000>;
--
2.30.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 6/7] arm64: dts: mt6358: Drop compatible for regulators
2021-03-12 14:55 [PATCH 1/7] dt-bindings: mfd: mediatek: Fix regulator description matthias.bgg
` (3 preceding siblings ...)
2021-03-12 14:55 ` [PATCH 5/7] arm: dts: mt6323: Drop OF compatible matthias.bgg
@ 2021-03-12 14:55 ` matthias.bgg
2021-03-12 14:55 ` [PATCH 7/7] arm64: dts: mt8173: Drop compatible for mt6397 matthias.bgg
2021-03-24 16:12 ` [PATCH 1/7] dt-bindings: mfd: mediatek: Fix regulator description Rob Herring
6 siblings, 0 replies; 13+ messages in thread
From: matthias.bgg @ 2021-03-12 14:55 UTC (permalink / raw)
To: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie
Cc: devicetree, linux-mediatek, linux-kernel, linux-arm-kernel,
Matthias Brugger
From: Matthias Brugger <mbrugger@suse.com>
The regulator framework does not need compatible, it's actually
superfluous. Drop it from the DT.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
arch/arm64/boot/dts/mediatek/mt6358.dtsi | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt6358.dtsi b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
index fa159b20379e4..e423feac0bc2e 100644
--- a/arch/arm64/boot/dts/mediatek/mt6358.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
@@ -15,9 +15,7 @@ mt6358codec: mt6358codec {
compatible = "mediatek,mt6358-sound";
};
- mt6358regulator: mt6358regulator {
- compatible = "mediatek,mt6358-regulator";
-
+ mt6358regulator {
mt6358_vdram1_reg: buck_vdram1 {
regulator-name = "vdram1";
regulator-min-microvolt = <500000>;
--
2.30.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 7/7] arm64: dts: mt8173: Drop compatible for mt6397
2021-03-12 14:55 [PATCH 1/7] dt-bindings: mfd: mediatek: Fix regulator description matthias.bgg
` (4 preceding siblings ...)
2021-03-12 14:55 ` [PATCH 6/7] arm64: dts: mt6358: Drop compatible for regulators matthias.bgg
@ 2021-03-12 14:55 ` matthias.bgg
2021-03-18 14:14 ` Enric Balletbo Serra
2021-03-24 16:12 ` [PATCH 1/7] dt-bindings: mfd: mediatek: Fix regulator description Rob Herring
6 siblings, 1 reply; 13+ messages in thread
From: matthias.bgg @ 2021-03-12 14:55 UTC (permalink / raw)
To: lee.jones, robh+dt, matthias.bgg, lgirdwood, broonie
Cc: devicetree, linux-mediatek, linux-kernel, linux-arm-kernel,
Matthias Brugger
From: Matthias Brugger <mbrugger@suse.com>
The regulator framework does not need compatible, it's actually
superfluous. Drop it from the DT.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Series-to: lee.jones@linaro.org
Series-to: robh+dt@kernel.org
Series-to: matthias.bgg@gmail.com
Series-to: lgirdwood@gmail.com
Series-to: broonie@kernel.org
Series-cc: devicetree@vger.kernel.org
Series-cc: linux-arm-kernel@lists.infradead.org
Series-cc: linux-mediatek@lists.infradead.org
Series-cc: linux-kernel@vger.kernel.org
---
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 4 +---
arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index 21452c51a20a8..db06a986f763e 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -916,9 +916,7 @@ pio6397: pinctrl {
#gpio-cells = <2>;
};
- regulator: mt6397regulator {
- compatible = "mediatek,mt6397-regulator";
-
+ mt6397regulator {
mt6397_vpca15_reg: buck_vpca15 {
regulator-compatible = "buck_vpca15";
regulator-name = "vpca15";
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
index 6dffada2e66b4..c3f2a85d55fe7 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
@@ -303,9 +303,7 @@ pmic: mt6397 {
interrupt-controller;
#interrupt-cells = <2>;
- mt6397regulator: mt6397regulator {
- compatible = "mediatek,mt6397-regulator";
-
+ mt6397regulator {
mt6397_vpca15_reg: buck_vpca15 {
regulator-compatible = "buck_vpca15";
regulator-name = "vpca15";
--
2.30.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 7/7] arm64: dts: mt8173: Drop compatible for mt6397
2021-03-12 14:55 ` [PATCH 7/7] arm64: dts: mt8173: Drop compatible for mt6397 matthias.bgg
@ 2021-03-18 14:14 ` Enric Balletbo Serra
0 siblings, 0 replies; 13+ messages in thread
From: Enric Balletbo Serra @ 2021-03-18 14:14 UTC (permalink / raw)
To: matthias.bgg
Cc: Lee Jones, Rob Herring, Matthias Brugger, Liam Girdwood,
Mark Brown, devicetree, moderated list:ARM/Mediatek SoC support,
linux-kernel, Linux ARM, Matthias Brugger
Hi Matthias,
Thank you for your patch.
Missatge de l'adreça <matthias.bgg@kernel.org> del dia dv., 12 de març
2021 a les 15:57:
>
> From: Matthias Brugger <mbrugger@suse.com>
>
> The regulator framework does not need compatible, it's actually
> superfluous. Drop it from the DT.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>
> Series-to: lee.jones@linaro.org
> Series-to: robh+dt@kernel.org
> Series-to: matthias.bgg@gmail.com
> Series-to: lgirdwood@gmail.com
> Series-to: broonie@kernel.org
> Series-cc: devicetree@vger.kernel.org
> Series-cc: linux-arm-kernel@lists.infradead.org
> Series-cc: linux-mediatek@lists.infradead.org
> Series-cc: linux-kernel@vger.kernel.org
> ---
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 4 +---
> arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index 21452c51a20a8..db06a986f763e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -916,9 +916,7 @@ pio6397: pinctrl {
> #gpio-cells = <2>;
> };
>
> - regulator: mt6397regulator {
> - compatible = "mediatek,mt6397-regulator";
> -
> + mt6397regulator {
The same happens here, it is not checked because the mt6397 is not in
YAML format yet, but once we do this it'll trigger an error as the
node name should be 'regulators'
> mt6397_vpca15_reg: buck_vpca15 {
> regulator-compatible = "buck_vpca15";
> regulator-name = "vpca15";
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> index 6dffada2e66b4..c3f2a85d55fe7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> @@ -303,9 +303,7 @@ pmic: mt6397 {
> interrupt-controller;
> #interrupt-cells = <2>;
>
> - mt6397regulator: mt6397regulator {
> - compatible = "mediatek,mt6397-regulator";
> -
> + mt6397regulator {
> mt6397_vpca15_reg: buck_vpca15 {
> regulator-compatible = "buck_vpca15";
> regulator-name = "vpca15";
> --
> 2.30.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/7] dt-bindings: mfd: mediatek: Fix regulator description
2021-03-12 14:55 [PATCH 1/7] dt-bindings: mfd: mediatek: Fix regulator description matthias.bgg
` (5 preceding siblings ...)
2021-03-12 14:55 ` [PATCH 7/7] arm64: dts: mt8173: Drop compatible for mt6397 matthias.bgg
@ 2021-03-24 16:12 ` Rob Herring
6 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2021-03-24 16:12 UTC (permalink / raw)
To: matthias.bgg
Cc: lee.jones, robh+dt, linux-arm-kernel, devicetree, lgirdwood,
matthias.bgg, broonie, linux-mediatek, linux-kernel,
Matthias Brugger
On Fri, 12 Mar 2021 15:55:39 +0100, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Having a separate compatible for the regulator node is redundant and not
> needed. Delete the corresponding requierement.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
>
> Documentation/devicetree/bindings/mfd/mt6397.txt | 3 ---
> 1 file changed, 3 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread