* [PATCH -next] arm64: smp: Add missing prototype for some smp.c functions
@ 2021-03-27 7:06 Chen Lifu
2021-03-28 17:21 ` Catalin Marinas
0 siblings, 1 reply; 5+ messages in thread
From: Chen Lifu @ 2021-03-27 7:06 UTC (permalink / raw)
To: catalin.marinas, will, valentin.schneider, maz, linux-arm-kernel,
linux-kernel
Cc: heying24, yuehaibing, weiyongjun1, johnny.chenyi, Chen Lifu
In commit eb631bb5bf5b
("arm64: Support arch_irq_work_raise() via self IPIs") a new
function "arch_irq_work_raise" was added without a prototype
in header irq_work.h
In commit d914d4d49745
("arm64: Implement panic_smp_self_stop()") a new
function "panic_smp_self_stop" was added without a prototype
in header irq_work.h
We get the following warnings on W=1:
arch/arm64/kernel/smp.c:842:6: warning: no previous prototype
for ‘arch_irq_work_raise’ [-Wmissing-prototypes]
arch/arm64/kernel/smp.c:862:6: warning: no previous prototype
for ‘panic_smp_self_stop’ [-Wmissing-prototypes]
Fix the same by adding the missing prototype in header irq_work.h
Signed-off-by: Chen Lifu <chenlifu@huawei.com>
---
arch/arm64/include/asm/irq_work.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/include/asm/irq_work.h b/arch/arm64/include/asm/irq_work.h
index a1020285ea75..f766e2190e7c 100644
--- a/arch/arm64/include/asm/irq_work.h
+++ b/arch/arm64/include/asm/irq_work.h
@@ -2,6 +2,9 @@
#ifndef __ASM_IRQ_WORK_H
#define __ASM_IRQ_WORK_H
+extern void arch_irq_work_raise(void);
+extern void panic_smp_self_stop(void);
+
static inline bool arch_irq_work_has_interrupt(void)
{
return true;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] arm64: smp: Add missing prototype for some smp.c functions
2021-03-27 7:06 [PATCH -next] arm64: smp: Add missing prototype for some smp.c functions Chen Lifu
@ 2021-03-28 17:21 ` Catalin Marinas
2021-03-29 3:43 ` [PATCH v2 " Chen Lifu
0 siblings, 1 reply; 5+ messages in thread
From: Catalin Marinas @ 2021-03-28 17:21 UTC (permalink / raw)
To: Chen Lifu
Cc: will, valentin.schneider, maz, linux-arm-kernel, linux-kernel,
heying24, yuehaibing, weiyongjun1, johnny.chenyi
On Sat, Mar 27, 2021 at 03:06:51PM +0800, Chen Lifu wrote:
> In commit eb631bb5bf5b
> ("arm64: Support arch_irq_work_raise() via self IPIs") a new
> function "arch_irq_work_raise" was added without a prototype
> in header irq_work.h
>
> In commit d914d4d49745
> ("arm64: Implement panic_smp_self_stop()") a new
> function "panic_smp_self_stop" was added without a prototype
> in header irq_work.h
>
> We get the following warnings on W=1:
> arch/arm64/kernel/smp.c:842:6: warning: no previous prototype
> for ‘arch_irq_work_raise’ [-Wmissing-prototypes]
> arch/arm64/kernel/smp.c:862:6: warning: no previous prototype
> for ‘panic_smp_self_stop’ [-Wmissing-prototypes]
>
> Fix the same by adding the missing prototype in header irq_work.h
>
> Signed-off-by: Chen Lifu <chenlifu@huawei.com>
> ---
> arch/arm64/include/asm/irq_work.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/include/asm/irq_work.h b/arch/arm64/include/asm/irq_work.h
> index a1020285ea75..f766e2190e7c 100644
> --- a/arch/arm64/include/asm/irq_work.h
> +++ b/arch/arm64/include/asm/irq_work.h
> @@ -2,6 +2,9 @@
> #ifndef __ASM_IRQ_WORK_H
> #define __ASM_IRQ_WORK_H
>
> +extern void arch_irq_work_raise(void);
> +extern void panic_smp_self_stop(void);
The second prototype makes more sense in arch/arm64/include/asm/smp.h
where we already have crash_smp_send_stop().
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 -next] arm64: smp: Add missing prototype for some smp.c functions
2021-03-28 17:21 ` Catalin Marinas
@ 2021-03-29 3:43 ` Chen Lifu
2021-03-29 12:28 ` Catalin Marinas
0 siblings, 1 reply; 5+ messages in thread
From: Chen Lifu @ 2021-03-29 3:43 UTC (permalink / raw)
To: catalin.marinas, will, valentin.schneider, maz, dbrazdil,
mark.rutland, wangkefeng.wang, linux-arm-kernel, linux-kernel
Cc: heying24, yuehaibing, weiyongjun1, johnny.chenyi, Chen Lifu
In commit eb631bb5bf5b
("arm64: Support arch_irq_work_raise() via self IPIs") a new
function "arch_irq_work_raise" was added without a prototype.
In commit d914d4d49745
("arm64: Implement panic_smp_self_stop()") a new
function "panic_smp_self_stop" was added without a prototype.
We get the following warnings on W=1:
arch/arm64/kernel/smp.c:842:6: warning: no previous prototype
for ‘arch_irq_work_raise’ [-Wmissing-prototypes]
arch/arm64/kernel/smp.c:862:6: warning: no previous prototype
for ‘panic_smp_self_stop’ [-Wmissing-prototypes]
Fix the warnings by:
1. Adding the prototype for 'arch_irq_work_raise' in irq_work.h
2. Adding the prototype for 'panic_smp_self_stop' in smp.h
Signed-off-by: Chen Lifu <chenlifu@huawei.com>
---
v2:
- move the prototype for 'panic_smp_self_stop' to smp.h
arch/arm64/include/asm/irq_work.h | 2 ++
arch/arm64/include/asm/smp.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/arch/arm64/include/asm/irq_work.h b/arch/arm64/include/asm/irq_work.h
index a1020285ea75..81bbfa3a035b 100644
--- a/arch/arm64/include/asm/irq_work.h
+++ b/arch/arm64/include/asm/irq_work.h
@@ -2,6 +2,8 @@
#ifndef __ASM_IRQ_WORK_H
#define __ASM_IRQ_WORK_H
+extern void arch_irq_work_raise(void);
+
static inline bool arch_irq_work_has_interrupt(void)
{
return true;
diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h
index bcb01ca15325..0e357757c0cc 100644
--- a/arch/arm64/include/asm/smp.h
+++ b/arch/arm64/include/asm/smp.h
@@ -145,6 +145,7 @@ bool cpus_are_stuck_in_kernel(void);
extern void crash_smp_send_stop(void);
extern bool smp_crash_stop_failed(void);
+extern void panic_smp_self_stop(void);
#endif /* ifndef __ASSEMBLY__ */
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 -next] arm64: smp: Add missing prototype for some smp.c functions
2021-03-29 3:43 ` [PATCH v2 " Chen Lifu
@ 2021-03-29 12:28 ` Catalin Marinas
2021-03-30 1:37 ` chenlifu
0 siblings, 1 reply; 5+ messages in thread
From: Catalin Marinas @ 2021-03-29 12:28 UTC (permalink / raw)
To: wangkefeng.wang, will, linux-arm-kernel, Chen Lifu, dbrazdil,
mark.rutland, linux-kernel, valentin.schneider, maz
Cc: johnny.chenyi, weiyongjun1, heying24, yuehaibing
On Mon, 29 Mar 2021 11:43:43 +0800, Chen Lifu wrote:
> In commit eb631bb5bf5b
> ("arm64: Support arch_irq_work_raise() via self IPIs") a new
> function "arch_irq_work_raise" was added without a prototype.
>
> In commit d914d4d49745
> ("arm64: Implement panic_smp_self_stop()") a new
> function "panic_smp_self_stop" was added without a prototype.
>
> [...]
Applied to arm64 (for-next/misc), thanks!
[1/1] arm64: smp: Add missing prototype for some smp.c functions
https://git.kernel.org/arm64/c/a52ef778ff28
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 -next] arm64: smp: Add missing prototype for some smp.c functions
2021-03-29 12:28 ` Catalin Marinas
@ 2021-03-30 1:37 ` chenlifu
0 siblings, 0 replies; 5+ messages in thread
From: chenlifu @ 2021-03-30 1:37 UTC (permalink / raw)
To: Catalin Marinas, wangkefeng.wang, will, linux-arm-kernel,
dbrazdil, mark.rutland, linux-kernel, valentin.schneider, maz
Cc: johnny.chenyi, weiyongjun1, heying24, yuehaibing
在 2021/3/29 20:28, Catalin Marinas 写道:
> On Mon, 29 Mar 2021 11:43:43 +0800, Chen Lifu wrote:
>> In commit eb631bb5bf5b
>> ("arm64: Support arch_irq_work_raise() via self IPIs") a new
>> function "arch_irq_work_raise" was added without a prototype.
>>
>> In commit d914d4d49745
>> ("arm64: Implement panic_smp_self_stop()") a new
>> function "panic_smp_self_stop" was added without a prototype.
>>
>> [...]
>
> Applied to arm64 (for-next/misc), thanks!
>
> [1/1] arm64: smp: Add missing prototype for some smp.c functions
> https://git.kernel.org/arm64/c/a52ef778ff28
>
Thanks!
--
Chen Lifu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-30 2:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-27 7:06 [PATCH -next] arm64: smp: Add missing prototype for some smp.c functions Chen Lifu
2021-03-28 17:21 ` Catalin Marinas
2021-03-29 3:43 ` [PATCH v2 " Chen Lifu
2021-03-29 12:28 ` Catalin Marinas
2021-03-30 1:37 ` chenlifu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).