From: Will Deacon <will@kernel.org>
To: "Isaac J. Manjarres" <isaacm@codeaurora.org>
Cc: iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org, robin.murphy@arm.com,
pratikp@codeaurora.org, baolu.lu@linux.intel.com
Subject: Re: [RFC PATCH v3 05/12] iommu: Use bitmap to calculate page size in iommu_pgsize()
Date: Tue, 6 Apr 2021 12:50:41 +0100 [thread overview]
Message-ID: <20210406115040.GB13747@willie-the-truck> (raw)
In-Reply-To: <20210405191112.28192-6-isaacm@codeaurora.org>
On Mon, Apr 05, 2021 at 12:11:05PM -0700, Isaac J. Manjarres wrote:
> From: Will Deacon <will@kernel.org>
>
> Avoid the potential for shifting values by amounts greater than the
> width of their type by using a bitmap to compute page size in
> iommu_pgsize().
>
> Signed-off-by: Will Deacon <will@kernel.org>
> Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
> ---
> drivers/iommu/iommu.c | 31 ++++++++++++-------------------
> 1 file changed, 12 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index d0b0a15dba84..9006397b6604 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -8,6 +8,7 @@
>
> #include <linux/device.h>
> #include <linux/kernel.h>
> +#include <linux/bits.h>
> #include <linux/bug.h>
> #include <linux/types.h>
> #include <linux/init.h>
> @@ -2360,30 +2361,22 @@ static size_t iommu_pgsize(struct iommu_domain *domain,
> unsigned long addr_merge, size_t size)
> {
> unsigned int pgsize_idx;
> + unsigned long pgsizes;
> size_t pgsize;
>
> - /* Max page size that still fits into 'size' */
> - pgsize_idx = __fls(size);
> + /* Page sizes supported by the hardware and small enough for @size */
> + pgsizes = domain->pgsize_bitmap & GENMASK_ULL(__fls(size), 0);
See my comments on the other thread, but I don't think it's necessary to use
the _ULL versions everywhere.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-06 11:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210405191112.28192-1-isaacm@codeaurora.org>
[not found] ` <20210405191112.28192-3-isaacm@codeaurora.org>
2021-04-06 1:48 ` [RFC PATCH v3 02/12] iommu: Add an unmap_pages() op for IOMMU drivers Lu Baolu
[not found] ` <20210405191112.28192-6-isaacm@codeaurora.org>
2021-04-06 11:50 ` Will Deacon [this message]
[not found] ` <20210405191112.28192-7-isaacm@codeaurora.org>
2021-04-06 11:53 ` [RFC PATCH v3 06/12] iommu: Split 'addr_merge' argument to iommu_pgsize() into separate parts Will Deacon
[not found] ` <20210405191112.28192-4-isaacm@codeaurora.org>
2021-04-06 11:57 ` [RFC PATCH v3 03/12] iommu/io-pgtable: Introduce map_pages() as a page table op Will Deacon
[not found] ` <75a5d309498b8b41b5e24a2d9d36e78f@codeaurora.org>
2021-04-07 9:54 ` Will Deacon
[not found] ` <20210405191112.28192-5-isaacm@codeaurora.org>
2021-04-06 1:49 ` [RFC PATCH v3 04/12] iommu: Add a map_pages() op for IOMMU drivers Lu Baolu
2021-04-06 11:58 ` Will Deacon
[not found] ` <20210405191112.28192-10-isaacm@codeaurora.org>
2021-04-06 12:15 ` [RFC PATCH v3 09/12] iommu/io-pgtable-arm: Implement arm_lpae_unmap_pages() Will Deacon
[not found] ` <8f78f5d051c9d40981fc6868c9245cd3@codeaurora.org>
2021-04-07 9:57 ` Will Deacon
[not found] ` <20210405191112.28192-12-isaacm@codeaurora.org>
2021-04-06 12:19 ` [RFC PATCH v3 11/12] iommu/arm-smmu: Implement the unmap_pages() IOMMU driver callback Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406115040.GB13747@willie-the-truck \
--to=will@kernel.org \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=isaacm@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=pratikp@codeaurora.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).