From: Lu Baolu <baolu.lu@linux.intel.com>
To: "Isaac J. Manjarres" <isaacm@codeaurora.org>,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org
Cc: baolu.lu@linux.intel.com, will@kernel.org, robin.murphy@arm.com,
pratikp@codeaurora.org
Subject: Re: [RFC PATCH v3 02/12] iommu: Add an unmap_pages() op for IOMMU drivers
Date: Tue, 6 Apr 2021 09:48:39 +0800 [thread overview]
Message-ID: <bf29730d-ddbc-3898-621d-a6211ad2a709@linux.intel.com> (raw)
In-Reply-To: <20210405191112.28192-3-isaacm@codeaurora.org>
On 4/6/21 3:11 AM, Isaac J. Manjarres wrote:
> Add a callback for IOMMU drivers to provide a path for the
> IOMMU framework to call into an IOMMU driver, which can call
> into the io-pgtable code, to unmap a virtually contiguous
> range of pages of the same size.
>
> For IOMMU drivers that do not specify an unmap_pages() callback,
> the existing logic of unmapping memory one page block at a time
> will be used.
>
> Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
> Suggested-by: Will Deacon <will@kernel.org>
> Signed-off-by: Will Deacon <will@kernel.org>
> ---
> include/linux/iommu.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 5e7fe519430a..9cf81242581a 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -193,6 +193,7 @@ struct iommu_iotlb_gather {
> * @detach_dev: detach device from an iommu domain
> * @map: map a physically contiguous memory region to an iommu domain
> * @unmap: unmap a physically contiguous memory region from an iommu domain
> + * @unmap_pages: unmap a number of pages of the same size from an iommu domain
> * @flush_iotlb_all: Synchronously flush all hardware TLBs for this domain
> * @iotlb_sync_map: Sync mappings created recently using @map to the hardware
> * @iotlb_sync: Flush all queued ranges from the hardware TLBs and empty flush
> @@ -245,6 +246,9 @@ struct iommu_ops {
> phys_addr_t paddr, size_t size, int prot, gfp_t gfp);
> size_t (*unmap)(struct iommu_domain *domain, unsigned long iova,
> size_t size, struct iommu_iotlb_gather *iotlb_gather);
> + size_t (*unmap_pages)(struct iommu_domain *domain, unsigned long iova,
> + size_t pgsize, size_t pgcount,
> + struct iommu_iotlb_gather *iotlb_gather);
> void (*flush_iotlb_all)(struct iommu_domain *domain);
> void (*iotlb_sync_map)(struct iommu_domain *domain, unsigned long iova,
> size_t size);
>
This looks good to me.
Acked-by: Lu Baolu <baolu.lu@linux.intel.com>
Best regards,
baolu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2021-04-06 2:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210405191112.28192-1-isaacm@codeaurora.org>
[not found] ` <20210405191112.28192-3-isaacm@codeaurora.org>
2021-04-06 1:48 ` Lu Baolu [this message]
[not found] ` <20210405191112.28192-6-isaacm@codeaurora.org>
2021-04-06 11:50 ` [RFC PATCH v3 05/12] iommu: Use bitmap to calculate page size in iommu_pgsize() Will Deacon
[not found] ` <20210405191112.28192-7-isaacm@codeaurora.org>
2021-04-06 11:53 ` [RFC PATCH v3 06/12] iommu: Split 'addr_merge' argument to iommu_pgsize() into separate parts Will Deacon
[not found] ` <20210405191112.28192-4-isaacm@codeaurora.org>
2021-04-06 11:57 ` [RFC PATCH v3 03/12] iommu/io-pgtable: Introduce map_pages() as a page table op Will Deacon
[not found] ` <75a5d309498b8b41b5e24a2d9d36e78f@codeaurora.org>
2021-04-07 9:54 ` Will Deacon
[not found] ` <20210405191112.28192-5-isaacm@codeaurora.org>
2021-04-06 1:49 ` [RFC PATCH v3 04/12] iommu: Add a map_pages() op for IOMMU drivers Lu Baolu
2021-04-06 11:58 ` Will Deacon
[not found] ` <20210405191112.28192-10-isaacm@codeaurora.org>
2021-04-06 12:15 ` [RFC PATCH v3 09/12] iommu/io-pgtable-arm: Implement arm_lpae_unmap_pages() Will Deacon
[not found] ` <8f78f5d051c9d40981fc6868c9245cd3@codeaurora.org>
2021-04-07 9:57 ` Will Deacon
[not found] ` <20210405191112.28192-12-isaacm@codeaurora.org>
2021-04-06 12:19 ` [RFC PATCH v3 11/12] iommu/arm-smmu: Implement the unmap_pages() IOMMU driver callback Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf29730d-ddbc-3898-621d-a6211ad2a709@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=isaacm@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=pratikp@codeaurora.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).