* [PATCH -next] mmc: owl-mmc: Remove unnecessary error log
@ 2021-04-09 2:33 Laibin Qiu
2021-04-09 5:16 ` Manivannan Sadhasivam
2021-04-12 7:52 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Laibin Qiu @ 2021-04-09 2:33 UTC (permalink / raw)
To: ulf.hansson, afaerber, mani, yuehaibing
Cc: linux-mmc, linux-arm-kernel, linux-actions, linux-kernel
devm_ioremap_resource() has recorded error log, so it's
unnecessary to record log again.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>
---
drivers/mmc/host/owl-mmc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
index 5490962dc8e5..3dc143b03939 100644
--- a/drivers/mmc/host/owl-mmc.c
+++ b/drivers/mmc/host/owl-mmc.c
@@ -581,7 +581,6 @@ static int owl_mmc_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
owl_host->base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(owl_host->base)) {
- dev_err(&pdev->dev, "Failed to remap registers\n");
ret = PTR_ERR(owl_host->base);
goto err_free_host;
}
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mmc: owl-mmc: Remove unnecessary error log
2021-04-09 2:33 [PATCH -next] mmc: owl-mmc: Remove unnecessary error log Laibin Qiu
@ 2021-04-09 5:16 ` Manivannan Sadhasivam
2021-04-12 7:52 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2021-04-09 5:16 UTC (permalink / raw)
To: Laibin Qiu
Cc: ulf.hansson, afaerber, yuehaibing, linux-mmc, linux-arm-kernel,
linux-actions, linux-kernel
On Fri, Apr 09, 2021 at 10:33:49AM +0800, Laibin Qiu wrote:
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> ---
> drivers/mmc/host/owl-mmc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index 5490962dc8e5..3dc143b03939 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -581,7 +581,6 @@ static int owl_mmc_probe(struct platform_device *pdev)
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> owl_host->base = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(owl_host->base)) {
> - dev_err(&pdev->dev, "Failed to remap registers\n");
> ret = PTR_ERR(owl_host->base);
> goto err_free_host;
> }
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mmc: owl-mmc: Remove unnecessary error log
2021-04-09 2:33 [PATCH -next] mmc: owl-mmc: Remove unnecessary error log Laibin Qiu
2021-04-09 5:16 ` Manivannan Sadhasivam
@ 2021-04-12 7:52 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2021-04-12 7:52 UTC (permalink / raw)
To: Laibin Qiu
Cc: Andreas Färber, Manivannan Sadhasivam, YueHaibing,
linux-mmc, Linux ARM, linux-actions, Linux Kernel Mailing List
On Fri, 9 Apr 2021 at 04:24, Laibin Qiu <qiulaibin@huawei.com> wrote:
>
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/owl-mmc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index 5490962dc8e5..3dc143b03939 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -581,7 +581,6 @@ static int owl_mmc_probe(struct platform_device *pdev)
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> owl_host->base = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(owl_host->base)) {
> - dev_err(&pdev->dev, "Failed to remap registers\n");
> ret = PTR_ERR(owl_host->base);
> goto err_free_host;
> }
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-12 7:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 2:33 [PATCH -next] mmc: owl-mmc: Remove unnecessary error log Laibin Qiu
2021-04-09 5:16 ` Manivannan Sadhasivam
2021-04-12 7:52 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).