[PATCH] arm64: alternative: simplify passing alt_region

[PATCH] arm64: alternative: simplify passing alt_region

[Mark Rutland]

In __apply_alternatives() we take a pointer to void which we later
assign to a pointer to struct alt_region. As all callers are passing a
pointer to struct alt_region to begin with, it's simpler and more robust
to take a pointer to struct alt region, so let's do so and avoid the
need for a temporary variable.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
---
 arch/arm64/kernel/alternative.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/kernel/alternative.c b/arch/arm64/kernel/alternative.c
index 1184c44ea2c7..f6fd16185040 100644
--- a/arch/arm64/kernel/alternative.c
+++ b/arch/arm64/kernel/alternative.c
@@ -133,11 +133,10 @@ static void clean_dcache_range_nopatch(u64 start, u64 end)
 	} while (cur += d_size, cur < end);
 }
 
-static void __apply_alternatives(void *alt_region,  bool is_module,
+static void __apply_alternatives(struct alt_region *region, bool is_module,
 				 unsigned long *feature_mask)
 {
 	struct alt_instr *alt;
-	struct alt_region *region = alt_region;
 	__le32 *origptr, *updptr;
 	alternative_cb_t alt_cb;
 
-- 
2.11.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: alternative: simplify passing alt_region

[Will Deacon]

On Fri, Apr 16, 2021 at 05:30:32PM +0100, Mark Rutland wrote:
> In __apply_alternatives() we take a pointer to void which we later
> assign to a pointer to struct alt_region. As all callers are passing a
> pointer to struct alt_region to begin with, it's simpler and more robust
> to take a pointer to struct alt region, so let's do so and avoid the
> need for a temporary variable.
> 
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> ---
>  arch/arm64/kernel/alternative.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Acked-by: Will Deacon <will@kernel.org>

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: alternative: simplify passing alt_region

[Catalin Marinas]

On Fri, 16 Apr 2021 17:30:32 +0100, Mark Rutland wrote:
> In __apply_alternatives() we take a pointer to void which we later
> assign to a pointer to struct alt_region. As all callers are passing a
> pointer to struct alt_region to begin with, it's simpler and more robust
> to take a pointer to struct alt region, so let's do so and avoid the
> need for a temporary variable.

Applied to arm64 (for-next/core), thanks!

[1/1] arm64: alternative: simplify passing alt_region
      https://git.kernel.org/arm64/c/8d144746ecc5

-- 
Catalin


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel