* [PATCH 2/4] crypto: arm: use a pattern rule for generating *.S files
[not found] <20210425175734.1310191-1-masahiroy@kernel.org>
@ 2021-04-25 17:57 ` Masahiro Yamada
2021-04-25 17:57 ` [PATCH 4/4] crypto: arm64: " Masahiro Yamada
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2021-04-25 17:57 UTC (permalink / raw)
To: Herbert Xu, David S . Miller, linux-crypto
Cc: Masahiro Yamada, Russell King, linux-arm-kernel, linux-kernel
Unify similar build rules.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/arm/crypto/Makefile | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/arch/arm/crypto/Makefile b/arch/arm/crypto/Makefile
index 51f160c61740..eafa898ba6a7 100644
--- a/arch/arm/crypto/Makefile
+++ b/arch/arm/crypto/Makefile
@@ -48,13 +48,7 @@ curve25519-neon-y := curve25519-core.o curve25519-glue.o
quiet_cmd_perl = PERL $@
cmd_perl = $(PERL) $(<) > $(@)
-$(obj)/poly1305-core.S: $(src)/poly1305-armv4.pl
- $(call cmd,perl)
-
-$(obj)/sha256-core.S: $(src)/sha256-armv4.pl
- $(call cmd,perl)
-
-$(obj)/sha512-core.S: $(src)/sha512-armv4.pl
+$(obj)/%-core.S: $(src)/%-armv4.pl
$(call cmd,perl)
clean-files += poly1305-core.S sha256-core.S sha512-core.S
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/4] crypto: arm64: use a pattern rule for generating *.S files
[not found] <20210425175734.1310191-1-masahiroy@kernel.org>
2021-04-25 17:57 ` [PATCH 2/4] crypto: arm: use a pattern rule for generating *.S files Masahiro Yamada
@ 2021-04-25 17:57 ` Masahiro Yamada
[not found] ` <20210425175734.1310191-3-masahiroy@kernel.org>
2021-05-14 11:34 ` [PATCH 1/4] crypto: arm: " Herbert Xu
3 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2021-04-25 17:57 UTC (permalink / raw)
To: Herbert Xu, David S . Miller, linux-crypto
Cc: Masahiro Yamada, Catalin Marinas, Will Deacon, linux-arm-kernel,
linux-kernel
Unify similar build rules.
sha256-core.S opts out it because it is generated from sha512-armv8.pl.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/arm64/crypto/Makefile | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm64/crypto/Makefile b/arch/arm64/crypto/Makefile
index 592e52a08c62..09a805cc32d7 100644
--- a/arch/arm64/crypto/Makefile
+++ b/arch/arm64/crypto/Makefile
@@ -71,13 +71,10 @@ $(obj)/aes-glue-%.o: $(src)/aes-glue.c FORCE
quiet_cmd_perlasm = PERLASM $@
cmd_perlasm = $(PERL) $(<) void $(@)
-$(obj)/poly1305-core.S: $(src)/poly1305-armv8.pl
+$(obj)/%-core.S: $(src)/%-armv8.pl
$(call cmd,perlasm)
$(obj)/sha256-core.S: $(src)/sha512-armv8.pl
$(call cmd,perlasm)
-$(obj)/sha512-core.S: $(src)/sha512-armv8.pl
- $(call cmd,perlasm)
-
clean-files += poly1305-core.S sha256-core.S sha512-core.S
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3/4] crypto: arm64: generate *.S by Perl at build time instead of shipping them
[not found] ` <20210425175734.1310191-3-masahiroy@kernel.org>
@ 2021-04-26 8:58 ` Will Deacon
2021-04-26 9:01 ` Ard Biesheuvel
0 siblings, 1 reply; 6+ messages in thread
From: Will Deacon @ 2021-04-26 8:58 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Herbert Xu, David S . Miller, linux-crypto, Catalin Marinas,
linux-arm-kernel, linux-kernel, ardb
[+Ard]
On Mon, Apr 26, 2021 at 02:57:33AM +0900, Masahiro Yamada wrote:
> Generate *.S by Perl like arch/{mips,x86}/crypto/Makefile.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/arm64/crypto/Makefile | 9 +-
> arch/arm64/crypto/poly1305-core.S_shipped | 835 ---------
> arch/arm64/crypto/sha256-core.S_shipped | 2069 ---------------------
> arch/arm64/crypto/sha512-core.S_shipped | 1093 -----------
> 4 files changed, 3 insertions(+), 4003 deletions(-)
> delete mode 100644 arch/arm64/crypto/poly1305-core.S_shipped
> delete mode 100644 arch/arm64/crypto/sha256-core.S_shipped
> delete mode 100644 arch/arm64/crypto/sha512-core.S_shipped
What's the advantage of removing the _shipped files? We included them
originally so that we didn't require perl for the kernel build -- is that no
longer an issue?
I guess I'm just missing the justification for the change.
Cheers,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/4] crypto: arm64: generate *.S by Perl at build time instead of shipping them
2021-04-26 8:58 ` [PATCH 3/4] crypto: arm64: generate *.S by Perl at build time instead of shipping them Will Deacon
@ 2021-04-26 9:01 ` Ard Biesheuvel
2021-04-26 10:40 ` Masahiro Yamada
0 siblings, 1 reply; 6+ messages in thread
From: Ard Biesheuvel @ 2021-04-26 9:01 UTC (permalink / raw)
To: Will Deacon
Cc: Masahiro Yamada, Herbert Xu, David S . Miller,
Linux Crypto Mailing List, Catalin Marinas, Linux ARM,
Linux Kernel Mailing List
On Mon, 26 Apr 2021 at 10:58, Will Deacon <will@kernel.org> wrote:
>
> [+Ard]
>
> On Mon, Apr 26, 2021 at 02:57:33AM +0900, Masahiro Yamada wrote:
> > Generate *.S by Perl like arch/{mips,x86}/crypto/Makefile.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> > arch/arm64/crypto/Makefile | 9 +-
> > arch/arm64/crypto/poly1305-core.S_shipped | 835 ---------
> > arch/arm64/crypto/sha256-core.S_shipped | 2069 ---------------------
> > arch/arm64/crypto/sha512-core.S_shipped | 1093 -----------
> > 4 files changed, 3 insertions(+), 4003 deletions(-)
> > delete mode 100644 arch/arm64/crypto/poly1305-core.S_shipped
> > delete mode 100644 arch/arm64/crypto/sha256-core.S_shipped
> > delete mode 100644 arch/arm64/crypto/sha512-core.S_shipped
>
> What's the advantage of removing the _shipped files? We included them
> originally so that we didn't require perl for the kernel build -- is that no
> longer an issue?
>
> I guess I'm just missing the justification for the change.
Removing 4000 lines of code is an improvement in itself, I suppose,
but I have no preference either way,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/4] crypto: arm64: generate *.S by Perl at build time instead of shipping them
2021-04-26 9:01 ` Ard Biesheuvel
@ 2021-04-26 10:40 ` Masahiro Yamada
0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2021-04-26 10:40 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: Will Deacon, Herbert Xu, David S . Miller,
Linux Crypto Mailing List, Catalin Marinas, Linux ARM,
Linux Kernel Mailing List
On Mon, Apr 26, 2021 at 6:01 PM Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Mon, 26 Apr 2021 at 10:58, Will Deacon <will@kernel.org> wrote:
> >
> > [+Ard]
> >
> > On Mon, Apr 26, 2021 at 02:57:33AM +0900, Masahiro Yamada wrote:
> > > Generate *.S by Perl like arch/{mips,x86}/crypto/Makefile.
> > >
> > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > > ---
> > >
> > > arch/arm64/crypto/Makefile | 9 +-
> > > arch/arm64/crypto/poly1305-core.S_shipped | 835 ---------
> > > arch/arm64/crypto/sha256-core.S_shipped | 2069 ---------------------
> > > arch/arm64/crypto/sha512-core.S_shipped | 1093 -----------
> > > 4 files changed, 3 insertions(+), 4003 deletions(-)
> > > delete mode 100644 arch/arm64/crypto/poly1305-core.S_shipped
> > > delete mode 100644 arch/arm64/crypto/sha256-core.S_shipped
> > > delete mode 100644 arch/arm64/crypto/sha512-core.S_shipped
> >
> > What's the advantage of removing the _shipped files? We included them
> > originally so that we didn't require perl for the kernel build -- is that no
> > longer an issue?
> >
> > I guess I'm just missing the justification for the change.
>
> Removing 4000 lines of code is an improvement in itself, I suppose,
> but I have no preference either way,
If necessary, I can send v2 with the following info added.
------------------------------>8---------------------------------
People building the arm64 kernel are likely to have Perl already
installed on the system.
ARCH=arm64 defconfig sets CONFIG_OID_REGISTRY=y, so Perl is required
to generate lib/oid_registery_data.c anyway.
Also, Documentation/process/changes.rst says:
You will need perl 5 and the following modules: ``Getopt::Long``,
``Getopt::Std``, ``File::Basename``, and ``File::Find`` to build the kernel.
------------------------------>8---------------------------------
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/4] crypto: arm: generate *.S by Perl at build time instead of shipping them
[not found] <20210425175734.1310191-1-masahiroy@kernel.org>
` (2 preceding siblings ...)
[not found] ` <20210425175734.1310191-3-masahiroy@kernel.org>
@ 2021-05-14 11:34 ` Herbert Xu
3 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2021-05-14 11:34 UTC (permalink / raw)
To: Masahiro Yamada
Cc: David S . Miller, linux-crypto, Russell King, linux-arm-kernel,
linux-kernel
On Mon, Apr 26, 2021 at 02:57:31AM +0900, Masahiro Yamada wrote:
> Generate *.S by Perl like arch/{mips,x86}/crypto/Makefile.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/arm/crypto/Makefile | 8 +-
> arch/arm/crypto/poly1305-core.S_shipped | 1158 ----------
> arch/arm/crypto/sha256-core.S_shipped | 2816 -----------------------
> arch/arm/crypto/sha512-core.S_shipped | 1869 ---------------
> 4 files changed, 3 insertions(+), 5848 deletions(-)
> delete mode 100644 arch/arm/crypto/poly1305-core.S_shipped
> delete mode 100644 arch/arm/crypto/sha256-core.S_shipped
> delete mode 100644 arch/arm/crypto/sha512-core.S_shipped
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-14 11:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210425175734.1310191-1-masahiroy@kernel.org>
2021-04-25 17:57 ` [PATCH 2/4] crypto: arm: use a pattern rule for generating *.S files Masahiro Yamada
2021-04-25 17:57 ` [PATCH 4/4] crypto: arm64: " Masahiro Yamada
[not found] ` <20210425175734.1310191-3-masahiroy@kernel.org>
2021-04-26 8:58 ` [PATCH 3/4] crypto: arm64: generate *.S by Perl at build time instead of shipping them Will Deacon
2021-04-26 9:01 ` Ard Biesheuvel
2021-04-26 10:40 ` Masahiro Yamada
2021-05-14 11:34 ` [PATCH 1/4] crypto: arm: " Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).