* [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_dsi_probe()
@ 2021-05-11 10:00 Zhen Lei
2021-05-11 13:22 ` Leizhen (ThunderTown)
0 siblings, 1 reply; 2+ messages in thread
From: Zhen Lei @ 2021-05-11 10:00 UTC (permalink / raw)
To: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-arm-kernel
Cc: Zhen Lei
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.
Therefore, remove the error printing here to simplify code and reduce the
binary size.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index ae403c67cbd922d..89e351dfab88177 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -1062,7 +1062,6 @@ static int mtk_dsi_probe(struct platform_device *pdev)
dsi->regs = devm_ioremap_resource(dev, regs);
if (IS_ERR(dsi->regs)) {
ret = PTR_ERR(dsi->regs);
- dev_err(dev, "Failed to ioremap memory: %d\n", ret);
goto err_unregister_host;
}
--
2.26.0.106.g9fadedd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_dsi_probe()
2021-05-11 10:00 [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_dsi_probe() Zhen Lei
@ 2021-05-11 13:22 ` Leizhen (ThunderTown)
0 siblings, 0 replies; 2+ messages in thread
From: Leizhen (ThunderTown) @ 2021-05-11 13:22 UTC (permalink / raw)
To: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-arm-kernel
Hi everybody,
Please ignore this patch and other "drm/mediatek". Looks like it would be better to combine them into a single patch.
On 2021/5/11 18:00, Zhen Lei wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index ae403c67cbd922d..89e351dfab88177 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1062,7 +1062,6 @@ static int mtk_dsi_probe(struct platform_device *pdev)
> dsi->regs = devm_ioremap_resource(dev, regs);
> if (IS_ERR(dsi->regs)) {
> ret = PTR_ERR(dsi->regs);
> - dev_err(dev, "Failed to ioremap memory: %d\n", ret);
> goto err_unregister_host;
> }
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-11 13:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 10:00 [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_dsi_probe() Zhen Lei
2021-05-11 13:22 ` Leizhen (ThunderTown)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).