* [PATCH] arm64: dts: ti: k3-am65-iot2050-common: Disable mailbox nodes
@ 2021-05-14 21:20 Suman Anna
2021-05-14 22:15 ` Nishanth Menon
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Suman Anna @ 2021-05-14 21:20 UTC (permalink / raw)
To: Nishanth Menon, Jan Kiszka; +Cc: devicetree, linux-arm-kernel
There are no sub-mailbox devices defined currently for both the
IOT2050 boards. These are usually dictated by the firmwares running
on the R5F remote processors and the applications they provide.
Defining the actual sub-mailboxes will also dictate the interrupts
the clusters will use for interrupts on the Cortex-A53 cores.
Disable all of the Mailbox clusters until the sub-mailboxes are
defined and used. This fixes the warnings around the missing
interrupts with the upcoming conversion of the OMAP Mailbox binding
to YAML format.
Signed-off-by: Suman Anna <s-anna@ti.com>
---
Hi Nishanth,
I will be posting the conversion of the OMAP Mailbox binding to YAML
sometime next week to deal with the current dtbs_check warnings seen
with these nodes on all K3 SoCs. It is kinda of a chicken and egg
problem w.r.t when you want all warnings gone, and this is in
preparation towards that. It also follows anyway the expected style
for Mailbox unless you add the usable mailbox sub-device nodes and
the interrupts they use.
regards
Suman
.../boot/dts/ti/k3-am65-iot2050-common.dtsi | 48 +++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
index de763ca9251c..f4ec9ed52939 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
@@ -653,3 +653,51 @@ &pcie1_rc {
&pcie1_ep {
status = "disabled";
};
+
+&mailbox0_cluster0 {
+ status = "disabled";
+};
+
+&mailbox0_cluster1 {
+ status = "disabled";
+};
+
+&mailbox0_cluster2 {
+ status = "disabled";
+};
+
+&mailbox0_cluster3 {
+ status = "disabled";
+};
+
+&mailbox0_cluster4 {
+ status = "disabled";
+};
+
+&mailbox0_cluster5 {
+ status = "disabled";
+};
+
+&mailbox0_cluster6 {
+ status = "disabled";
+};
+
+&mailbox0_cluster7 {
+ status = "disabled";
+};
+
+&mailbox0_cluster8 {
+ status = "disabled";
+};
+
+&mailbox0_cluster9 {
+ status = "disabled";
+};
+
+&mailbox0_cluster10 {
+ status = "disabled";
+};
+
+&mailbox0_cluster11 {
+ status = "disabled";
+};
--
2.30.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am65-iot2050-common: Disable mailbox nodes
2021-05-14 21:20 [PATCH] arm64: dts: ti: k3-am65-iot2050-common: Disable mailbox nodes Suman Anna
@ 2021-05-14 22:15 ` Nishanth Menon
2021-05-19 16:50 ` Jan Kiszka
2021-05-22 0:54 ` Nishanth Menon
2 siblings, 0 replies; 4+ messages in thread
From: Nishanth Menon @ 2021-05-14 22:15 UTC (permalink / raw)
To: Suman Anna; +Cc: Jan Kiszka, devicetree, linux-arm-kernel
On 16:20-20210514, Suman Anna wrote:
> There are no sub-mailbox devices defined currently for both the
> IOT2050 boards. These are usually dictated by the firmwares running
> on the R5F remote processors and the applications they provide.
> Defining the actual sub-mailboxes will also dictate the interrupts
> the clusters will use for interrupts on the Cortex-A53 cores.
>
> Disable all of the Mailbox clusters until the sub-mailboxes are
> defined and used. This fixes the warnings around the missing
> interrupts with the upcoming conversion of the OMAP Mailbox binding
> to YAML format.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> Hi Nishanth,
>
> I will be posting the conversion of the OMAP Mailbox binding to YAML
> sometime next week to deal with the current dtbs_check warnings seen
> with these nodes on all K3 SoCs. It is kinda of a chicken and egg
> problem w.r.t when you want all warnings gone, and this is in
> preparation towards that. It also follows anyway the expected style
> for Mailbox unless you add the usable mailbox sub-device nodes and
> the interrupts they use.
>
yes, that was the exact intent of pushing to cleanup our yaml to expose
definition issues such as these.. Glad and thanks you are doing this.
Expectation ofcourse is that we get the dts fixups done and merged asap
so that the yaml conversion merges produce a clean dtbs_check - where
ever possible hopefully by 5.14-rc1 (I know it is a tall order given the
scope of conversion pending - but bite at a time).
Jan: Are you OK with this? I think overlays will help introduce the
variations you need with the firmware if there is any.
> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index de763ca9251c..f4ec9ed52939 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -653,3 +653,51 @@ &pcie1_rc {
> &pcie1_ep {
> status = "disabled";
> };
> +
> +&mailbox0_cluster0 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster1 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster2 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster3 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster4 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster5 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster6 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster7 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster8 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster9 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster10 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster11 {
> + status = "disabled";
> +};
> --
> 2.30.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am65-iot2050-common: Disable mailbox nodes
2021-05-14 21:20 [PATCH] arm64: dts: ti: k3-am65-iot2050-common: Disable mailbox nodes Suman Anna
2021-05-14 22:15 ` Nishanth Menon
@ 2021-05-19 16:50 ` Jan Kiszka
2021-05-22 0:54 ` Nishanth Menon
2 siblings, 0 replies; 4+ messages in thread
From: Jan Kiszka @ 2021-05-19 16:50 UTC (permalink / raw)
To: Suman Anna, Nishanth Menon; +Cc: devicetree, linux-arm-kernel
On 14.05.21 23:20, Suman Anna wrote:
> There are no sub-mailbox devices defined currently for both the
> IOT2050 boards. These are usually dictated by the firmwares running
> on the R5F remote processors and the applications they provide.
> Defining the actual sub-mailboxes will also dictate the interrupts
> the clusters will use for interrupts on the Cortex-A53 cores.
>
> Disable all of the Mailbox clusters until the sub-mailboxes are
> defined and used. This fixes the warnings around the missing
> interrupts with the upcoming conversion of the OMAP Mailbox binding
> to YAML format.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> Hi Nishanth,
>
> I will be posting the conversion of the OMAP Mailbox binding to YAML
> sometime next week to deal with the current dtbs_check warnings seen
> with these nodes on all K3 SoCs. It is kinda of a chicken and egg
> problem w.r.t when you want all warnings gone, and this is in
> preparation towards that. It also follows anyway the expected style
> for Mailbox unless you add the usable mailbox sub-device nodes and
> the interrupts they use.
>
> regards
> Suman
>
> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index de763ca9251c..f4ec9ed52939 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -653,3 +653,51 @@ &pcie1_rc {
> &pcie1_ep {
> status = "disabled";
> };
> +
> +&mailbox0_cluster0 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster1 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster2 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster3 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster4 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster5 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster6 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster7 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster8 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster9 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster10 {
> + status = "disabled";
> +};
> +
> +&mailbox0_cluster11 {
> + status = "disabled";
> +};
>
Acked-by: Jan Kiszka <jan.kiszka@siemens.com>
Thanks,
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am65-iot2050-common: Disable mailbox nodes
2021-05-14 21:20 [PATCH] arm64: dts: ti: k3-am65-iot2050-common: Disable mailbox nodes Suman Anna
2021-05-14 22:15 ` Nishanth Menon
2021-05-19 16:50 ` Jan Kiszka
@ 2021-05-22 0:54 ` Nishanth Menon
2 siblings, 0 replies; 4+ messages in thread
From: Nishanth Menon @ 2021-05-22 0:54 UTC (permalink / raw)
To: Jan Kiszka, Suman Anna; +Cc: Nishanth Menon, linux-arm-kernel, devicetree
On Fri, 14 May 2021 16:20:16 -0500, Suman Anna wrote:
> There are no sub-mailbox devices defined currently for both the
> IOT2050 boards. These are usually dictated by the firmwares running
> on the R5F remote processors and the applications they provide.
> Defining the actual sub-mailboxes will also dictate the interrupts
> the clusters will use for interrupts on the Cortex-A53 cores.
>
> Disable all of the Mailbox clusters until the sub-mailboxes are
> defined and used. This fixes the warnings around the missing
> interrupts with the upcoming conversion of the OMAP Mailbox binding
> to YAML format.
Hi Suman Anna,
I have applied the following to branch ti-k3-next on [1].
Thank you!
[1/1] arm64: dts: ti: k3-am65-iot2050-common: Disable mailbox nodes
commit: 547be9a05dc825fbbaeb970ec9e2313a49bf586f
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-22 0:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14 21:20 [PATCH] arm64: dts: ti: k3-am65-iot2050-common: Disable mailbox nodes Suman Anna
2021-05-14 22:15 ` Nishanth Menon
2021-05-19 16:50 ` Jan Kiszka
2021-05-22 0:54 ` Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).