[PATCH 00/11] Rid W=1 warnings from TTY

[PATCH 00/11] Rid W=1 warnings from TTY

[Lee Jones]

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Lee Jones (11):
  tty: vt: selection: Correct misspelled function sel_loadlut()
  tty: serdev: core: Fix misspelled function name
    __serdev_device_driver_register()
  tty: tty_io: Fix a few kernel-doc related misdemeanours
  tty: n_tty: Fix some misdocumented functions
  tty: tty_buffer: Fix incorrectly documented function
    __tty_buffer_request_room()
  tty: tty_jobctrl: Fix 2 incorrectly documented functions
  tty: pty: Fix incorrectly named function pty_resize()
  tty: n_hdlc: Fix a little doc-rot in n_hdlc_tty_read()
  tty: serial: st-asc: Demote a kernel-doc formatting abuse
  tty: n_gsm: Fix function naming and provide missing param descriptions
  tty: serial: xilinx_uartps: Fix documentation for
    cdns_uart_clk_notifier_cb()

 drivers/tty/n_gsm.c                |  6 ++++--
 drivers/tty/n_hdlc.c               |  4 +++-
 drivers/tty/n_tty.c                | 10 +++++-----
 drivers/tty/pty.c                  |  2 +-
 drivers/tty/serdev/core.c          |  2 +-
 drivers/tty/serial/st-asc.c        |  2 +-
 drivers/tty/serial/xilinx_uartps.c |  2 +-
 drivers/tty/tty_buffer.c           |  2 +-
 drivers/tty/tty_io.c               | 17 +++++------------
 drivers/tty/tty_jobctrl.c          |  4 ++--
 drivers/tty/vt/selection.c         |  2 +-
 11 files changed, 25 insertions(+), 28 deletions(-)

Cc: Al Longyear <longyear@netcom.com>
Cc: "Andrew J. Kroll" <ag784@freenet.buffalo.edu>
Cc: Andrew Morton <andrewm@uow.edu.eu>
Cc: Bill Hawes <whawes@star.net>
Cc: "C. Scott Ananian" <cananian@alumni.princeton.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: -- <julian@uhunix.uhcc.hawaii.edu>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-serial@vger.kernel.org
Cc: Marko Kohtala <Marko.Kohtala@hut.fi>
Cc: Michael Callahan <callahan@maths.ox.ac.uk>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Nick Holloway <alfie@dcs.warwick.ac.uk>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Paul Fulghum <paulkf@microgate.com>
Cc: Paul Mackerras <Paul.Mackerras@cs.anu.edu.au>
Cc: processes-Sapan Bhatia <sapan@corewars.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Russell King <rmk@arm.linux.org.uk>
-- 
2.31.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 09/11] tty: serial: st-asc: Demote a kernel-doc formatting abuse

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/tty/serial/st-asc.c:73: warning: expecting prototype for Some of status comes from higher bits of the character and some come from(). Prototype was for ASC_RXBUF_DUMMY_RX() instead

Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-serial@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/tty/serial/st-asc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index e7048515a79ca..62128bbd03151 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -65,7 +65,7 @@ static struct uart_driver asc_uart_driver;
 /* ASC_RXBUF */
 #define ASC_RXBUF_PE			0x100
 #define ASC_RXBUF_FE			0x200
-/**
+/*
  * Some of status comes from higher bits of the character and some come from
  * the status register. Combining both of them in to single status using dummy
  * bits.
-- 
2.31.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 11/11] tty: serial: xilinx_uartps: Fix documentation for cdns_uart_clk_notifier_cb()

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/tty/serial/xilinx_uartps.c:496: warning: expecting prototype for cdns_uart_clk_notitifer_cb(). Prototype was for cdns_uart_clk_notifier_cb() instead

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: linux-serial@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/tty/serial/xilinx_uartps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 67a2db621e2b7..2cdcfb8f034de 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -484,7 +484,7 @@ static unsigned int cdns_uart_set_baud_rate(struct uart_port *port,
 
 #ifdef CONFIG_COMMON_CLK
 /**
- * cdns_uart_clk_notitifer_cb - Clock notifier callback
+ * cdns_uart_clk_notifier_cb - Clock notifier callback
  * @nb:		Notifier block
  * @event:	Notify event
  * @data:	Notifier data
-- 
2.31.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 11/11] tty: serial: xilinx_uartps: Fix documentation for cdns_uart_clk_notifier_cb()

[Michal Simek]

On 5/20/21 2:19 PM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/tty/serial/xilinx_uartps.c:496: warning: expecting prototype for cdns_uart_clk_notitifer_cb(). Prototype was for cdns_uart_clk_notifier_cb() instead
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jirislaby@kernel.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: linux-serial@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/tty/serial/xilinx_uartps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index 67a2db621e2b7..2cdcfb8f034de 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -484,7 +484,7 @@ static unsigned int cdns_uart_set_baud_rate(struct uart_port *port,
>  
>  #ifdef CONFIG_COMMON_CLK
>  /**
> - * cdns_uart_clk_notitifer_cb - Clock notifier callback
> + * cdns_uart_clk_notifier_cb - Clock notifier callback
>   * @nb:		Notifier block
>   * @event:	Notify event
>   * @data:	Notifier data
> 

Reviewed-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 00/11] Rid W=1 warnings from TTY

[Greg Kroah-Hartman]

On Thu, May 20, 2021 at 01:18:55PM +0100, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.

All but 3 applied to my tree, you should rebase and resend those
remaining ones as they conflicted with things that others recently
changed.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel