* [PATCH 1/1] arm64: dts: lx2160a: Normalize the compatible string of "arm, sbsa-uart" @ 2021-05-24 3:52 Zhen Lei 2021-05-24 17:36 ` Mark Kettenis 0 siblings, 1 reply; 6+ messages in thread From: Zhen Lei @ 2021-05-24 3:52 UTC (permalink / raw) To: Shawn Guo, Li Yang, Rob Herring, linux-arm-kernel, devicetree; +Cc: Zhen Lei The compatible string of ARM SBSA defined generic UART needs to contain only "arm,sbsa-uart" and does not need to contain "arm,pl011". Otherwise, the pl011.yaml will check it and falsely report many warnings similar to the following: arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dt.yaml: serial@21c0000: compatible:0: 'arm,pl011' was expected serial@21c0000: compatible:1: 'arm,primecell' was expected Delete the redundant "arm,pl011" to fix it. Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi index 4fcc869c21a4..417546616d85 100644 --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi @@ -920,7 +920,7 @@ }; uart0: serial@21c0000 { - compatible = "arm,sbsa-uart","arm,pl011"; + compatible = "arm,sbsa-uart"; reg = <0x0 0x21c0000 0x0 0x1000>; interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; current-speed = <115200>; @@ -928,7 +928,7 @@ }; uart1: serial@21d0000 { - compatible = "arm,sbsa-uart","arm,pl011"; + compatible = "arm,sbsa-uart"; reg = <0x0 0x21d0000 0x0 0x1000>; interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>; current-speed = <115200>; @@ -936,7 +936,7 @@ }; uart2: serial@21e0000 { - compatible = "arm,sbsa-uart","arm,pl011"; + compatible = "arm,sbsa-uart"; reg = <0x0 0x21e0000 0x0 0x1000>; interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; current-speed = <115200>; @@ -944,7 +944,7 @@ }; uart3: serial@21f0000 { - compatible = "arm,sbsa-uart","arm,pl011"; + compatible = "arm,sbsa-uart"; reg = <0x0 0x21f0000 0x0 0x1000>; interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; current-speed = <115200>; -- 2.21.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] arm64: dts: lx2160a: Normalize the compatible string of "arm, sbsa-uart" 2021-05-24 3:52 [PATCH 1/1] arm64: dts: lx2160a: Normalize the compatible string of "arm, sbsa-uart" Zhen Lei @ 2021-05-24 17:36 ` Mark Kettenis 2021-05-25 2:00 ` Leizhen (ThunderTown) 0 siblings, 1 reply; 6+ messages in thread From: Mark Kettenis @ 2021-05-24 17:36 UTC (permalink / raw) To: Zhen Lei Cc: shawnguo, leoyang.li, robh+dt, linux-arm-kernel, devicetree, thunder.leizhen > From: Zhen Lei <thunder.leizhen@huawei.com> > Date: Mon, 24 May 2021 11:52:44 +0800 > Content-Type: text/plain; charset="us-ascii" > > The compatible string of ARM SBSA defined generic UART needs to contain > only "arm,sbsa-uart" and does not need to contain "arm,pl011". Otherwise, > the pl011.yaml will check it and falsely report many warnings similar to > the following: > > arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dt.yaml: > serial@21c0000: compatible:0: 'arm,pl011' was expected > serial@21c0000: compatible:1: 'arm,primecell' was expected > > Delete the redundant "arm,pl011" to fix it. According to its reference manual, the LX2160A has a full PL011 implementation. So I think this is the wrong "fix". > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > index 4fcc869c21a4..417546616d85 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > @@ -920,7 +920,7 @@ > }; > > uart0: serial@21c0000 { > - compatible = "arm,sbsa-uart","arm,pl011"; > + compatible = "arm,sbsa-uart"; > reg = <0x0 0x21c0000 0x0 0x1000>; > interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; > current-speed = <115200>; > @@ -928,7 +928,7 @@ > }; > > uart1: serial@21d0000 { > - compatible = "arm,sbsa-uart","arm,pl011"; > + compatible = "arm,sbsa-uart"; > reg = <0x0 0x21d0000 0x0 0x1000>; > interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>; > current-speed = <115200>; > @@ -936,7 +936,7 @@ > }; > > uart2: serial@21e0000 { > - compatible = "arm,sbsa-uart","arm,pl011"; > + compatible = "arm,sbsa-uart"; > reg = <0x0 0x21e0000 0x0 0x1000>; > interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; > current-speed = <115200>; > @@ -944,7 +944,7 @@ > }; > > uart3: serial@21f0000 { > - compatible = "arm,sbsa-uart","arm,pl011"; > + compatible = "arm,sbsa-uart"; > reg = <0x0 0x21f0000 0x0 0x1000>; > interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; > current-speed = <115200>; > -- > 2.21.1 > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] arm64: dts: lx2160a: Normalize the compatible string of "arm, sbsa-uart" 2021-05-24 17:36 ` Mark Kettenis @ 2021-05-25 2:00 ` Leizhen (ThunderTown) 2021-06-12 2:10 ` Shawn Guo 0 siblings, 1 reply; 6+ messages in thread From: Leizhen (ThunderTown) @ 2021-05-25 2:00 UTC (permalink / raw) To: Mark Kettenis; +Cc: shawnguo, leoyang.li, robh+dt, linux-arm-kernel, devicetree On 2021/5/25 1:36, Mark Kettenis wrote: >> From: Zhen Lei <thunder.leizhen@huawei.com> >> Date: Mon, 24 May 2021 11:52:44 +0800 >> Content-Type: text/plain; charset="us-ascii" >> >> The compatible string of ARM SBSA defined generic UART needs to contain >> only "arm,sbsa-uart" and does not need to contain "arm,pl011". Otherwise, >> the pl011.yaml will check it and falsely report many warnings similar to >> the following: >> >> arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dt.yaml: >> serial@21c0000: compatible:0: 'arm,pl011' was expected >> serial@21c0000: compatible:1: 'arm,primecell' was expected >> >> Delete the redundant "arm,pl011" to fix it. > > According to its reference manual, the LX2160A has a full PL011 > implementation. So I think this is the wrong "fix". No, No, Please refer: https://www.spinics.net/lists/devicetree/msg424054.html Now the "arm,sbsa-uart" driver is mixed with amba-pl011.c，It's impossible "arm,pl011" is loaded but "arm,sbsa-uart" is not loaded. So it makes no sense to append "arm, pl011" to the end of the compatible string as an alternative driver. drivers/tty/serial/amba-pl011.c:2784: { .compatible = "arm,sbsa-uart", }, > >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> >> --- >> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >> index 4fcc869c21a4..417546616d85 100644 >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >> @@ -920,7 +920,7 @@ >> }; >> >> uart0: serial@21c0000 { >> - compatible = "arm,sbsa-uart","arm,pl011"; >> + compatible = "arm,sbsa-uart"; >> reg = <0x0 0x21c0000 0x0 0x1000>; >> interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; >> current-speed = <115200>; >> @@ -928,7 +928,7 @@ >> }; >> >> uart1: serial@21d0000 { >> - compatible = "arm,sbsa-uart","arm,pl011"; >> + compatible = "arm,sbsa-uart"; >> reg = <0x0 0x21d0000 0x0 0x1000>; >> interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>; >> current-speed = <115200>; >> @@ -936,7 +936,7 @@ >> }; >> >> uart2: serial@21e0000 { >> - compatible = "arm,sbsa-uart","arm,pl011"; >> + compatible = "arm,sbsa-uart"; >> reg = <0x0 0x21e0000 0x0 0x1000>; >> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; >> current-speed = <115200>; >> @@ -944,7 +944,7 @@ >> }; >> >> uart3: serial@21f0000 { >> - compatible = "arm,sbsa-uart","arm,pl011"; >> + compatible = "arm,sbsa-uart"; >> reg = <0x0 0x21f0000 0x0 0x1000>; >> interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; >> current-speed = <115200>; >> -- >> 2.21.1 >> >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] arm64: dts: lx2160a: Normalize the compatible string of "arm, sbsa-uart" 2021-05-25 2:00 ` Leizhen (ThunderTown) @ 2021-06-12 2:10 ` Shawn Guo 2021-06-12 10:11 ` Mark Kettenis 0 siblings, 1 reply; 6+ messages in thread From: Shawn Guo @ 2021-06-12 2:10 UTC (permalink / raw) To: Leizhen (ThunderTown) Cc: Mark Kettenis, leoyang.li, robh+dt, linux-arm-kernel, devicetree, Vabhav Sharma, Russell King On Tue, May 25, 2021 at 10:00:30AM +0800, Leizhen (ThunderTown) wrote: > > > On 2021/5/25 1:36, Mark Kettenis wrote: > >> From: Zhen Lei <thunder.leizhen@huawei.com> > >> Date: Mon, 24 May 2021 11:52:44 +0800 > >> Content-Type: text/plain; charset="us-ascii" > >> > >> The compatible string of ARM SBSA defined generic UART needs to contain > >> only "arm,sbsa-uart" and does not need to contain "arm,pl011". Otherwise, > >> the pl011.yaml will check it and falsely report many warnings similar to > >> the following: > >> > >> arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dt.yaml: > >> serial@21c0000: compatible:0: 'arm,pl011' was expected > >> serial@21c0000: compatible:1: 'arm,primecell' was expected > >> > >> Delete the redundant "arm,pl011" to fix it. > > > > According to its reference manual, the LX2160A has a full PL011 > > implementation. So I think this is the wrong "fix". > > No, No, Please refer: https://www.spinics.net/lists/devicetree/msg424054.html > > Now the "arm,sbsa-uart" driver is mixed with amba-pl011.c，It's impossible > "arm,pl011" is loaded but "arm,sbsa-uart" is not loaded. So it makes no sense > to append "arm, pl011" to the end of the compatible string as an alternative > driver. > > drivers/tty/serial/amba-pl011.c:2784: { .compatible = "arm,sbsa-uart", }, I guess Mark is suggesting the following fix. uart0: serial@21c0000 { - compatible = "arm,sbsa-uart","arm,pl011"; + compatible = "arm,pl011", "arm,primecell"; reg = <0x0 0x21c0000 0x0 0x1000>; interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; - current-speed = <115200>; status = "disabled"; }; I copied some folks who might help clarify whether LX2160A UART is a SBSA or a full PL011. Shawn > > > > > >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > >> --- > >> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 8 ++++---- > >> 1 file changed, 4 insertions(+), 4 deletions(-) > >> > >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > >> index 4fcc869c21a4..417546616d85 100644 > >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > >> @@ -920,7 +920,7 @@ > >> }; > >> > >> uart0: serial@21c0000 { > >> - compatible = "arm,sbsa-uart","arm,pl011"; > >> + compatible = "arm,sbsa-uart"; > >> reg = <0x0 0x21c0000 0x0 0x1000>; > >> interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; > >> current-speed = <115200>; > >> @@ -928,7 +928,7 @@ > >> }; > >> > >> uart1: serial@21d0000 { > >> - compatible = "arm,sbsa-uart","arm,pl011"; > >> + compatible = "arm,sbsa-uart"; > >> reg = <0x0 0x21d0000 0x0 0x1000>; > >> interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>; > >> current-speed = <115200>; > >> @@ -936,7 +936,7 @@ > >> }; > >> > >> uart2: serial@21e0000 { > >> - compatible = "arm,sbsa-uart","arm,pl011"; > >> + compatible = "arm,sbsa-uart"; > >> reg = <0x0 0x21e0000 0x0 0x1000>; > >> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; > >> current-speed = <115200>; > >> @@ -944,7 +944,7 @@ > >> }; > >> > >> uart3: serial@21f0000 { > >> - compatible = "arm,sbsa-uart","arm,pl011"; > >> + compatible = "arm,sbsa-uart"; > >> reg = <0x0 0x21f0000 0x0 0x1000>; > >> interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; > >> current-speed = <115200>; > >> -- > >> 2.21.1 > >> > >> > >> > >> _______________________________________________ > >> linux-arm-kernel mailing list > >> linux-arm-kernel@lists.infradead.org > >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > >> > > > > . > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] arm64: dts: lx2160a: Normalize the compatible string of "arm, sbsa-uart" 2021-06-12 2:10 ` Shawn Guo @ 2021-06-12 10:11 ` Mark Kettenis 2021-06-15 11:38 ` Leizhen (ThunderTown) 0 siblings, 1 reply; 6+ messages in thread From: Mark Kettenis @ 2021-06-12 10:11 UTC (permalink / raw) To: Shawn Guo Cc: thunder.leizhen, leoyang.li, robh+dt, linux-arm-kernel, devicetree, vabhav.sharma, linux > Date: Sat, 12 Jun 2021 10:10:58 +0800 > From: Shawn Guo <shawnguo@kernel.org> > > On Tue, May 25, 2021 at 10:00:30AM +0800, Leizhen (ThunderTown) wrote: > > > > > > On 2021/5/25 1:36, Mark Kettenis wrote: > > >> From: Zhen Lei <thunder.leizhen@huawei.com> > > >> Date: Mon, 24 May 2021 11:52:44 +0800 > > >> Content-Type: text/plain; charset="us-ascii" > > >> > > >> The compatible string of ARM SBSA defined generic UART needs to contain > > >> only "arm,sbsa-uart" and does not need to contain "arm,pl011". Otherwise, > > >> the pl011.yaml will check it and falsely report many warnings similar to > > >> the following: > > >> > > >> arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dt.yaml: > > >> serial@21c0000: compatible:0: 'arm,pl011' was expected > > >> serial@21c0000: compatible:1: 'arm,primecell' was expected > > >> > > >> Delete the redundant "arm,pl011" to fix it. > > > > > > According to its reference manual, the LX2160A has a full PL011 > > > implementation. So I think this is the wrong "fix". > > > > No, No, Please refer: https://www.spinics.net/lists/devicetree/msg424054.html > > > > Now the "arm,sbsa-uart" driver is mixed with amba-pl011.c，It's impossible > > "arm,pl011" is loaded but "arm,sbsa-uart" is not loaded. So it makes no sense > > to append "arm, pl011" to the end of the compatible string as an alternative > > driver. > > > > drivers/tty/serial/amba-pl011.c:2784: { .compatible = "arm,sbsa-uart", }, > > I guess Mark is suggesting the following fix. > > uart0: serial@21c0000 { > - compatible = "arm,sbsa-uart","arm,pl011"; > + compatible = "arm,pl011", "arm,primecell"; > reg = <0x0 0x21c0000 0x0 0x1000>; > interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; > - current-speed = <115200>; > status = "disabled"; > }; > > I copied some folks who might help clarify whether LX2160A UART is a SBSA > or a full PL011. Sorry, I missed Leizhen's original reply. But yes, that is what I meant. According to the NXP documentation, the LX2160A has a real PL011 UART, so the correct fix is what Shawn suggests above. Cheers, Mark > > >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > > >> --- > > >> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 8 ++++---- > > >> 1 file changed, 4 insertions(+), 4 deletions(-) > > >> > > >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > >> index 4fcc869c21a4..417546616d85 100644 > > >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > > >> @@ -920,7 +920,7 @@ > > >> }; > > >> > > >> uart0: serial@21c0000 { > > >> - compatible = "arm,sbsa-uart","arm,pl011"; > > >> + compatible = "arm,sbsa-uart"; > > >> reg = <0x0 0x21c0000 0x0 0x1000>; > > >> interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; > > >> current-speed = <115200>; > > >> @@ -928,7 +928,7 @@ > > >> }; > > >> > > >> uart1: serial@21d0000 { > > >> - compatible = "arm,sbsa-uart","arm,pl011"; > > >> + compatible = "arm,sbsa-uart"; > > >> reg = <0x0 0x21d0000 0x0 0x1000>; > > >> interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>; > > >> current-speed = <115200>; > > >> @@ -936,7 +936,7 @@ > > >> }; > > >> > > >> uart2: serial@21e0000 { > > >> - compatible = "arm,sbsa-uart","arm,pl011"; > > >> + compatible = "arm,sbsa-uart"; > > >> reg = <0x0 0x21e0000 0x0 0x1000>; > > >> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; > > >> current-speed = <115200>; > > >> @@ -944,7 +944,7 @@ > > >> }; > > >> > > >> uart3: serial@21f0000 { > > >> - compatible = "arm,sbsa-uart","arm,pl011"; > > >> + compatible = "arm,sbsa-uart"; > > >> reg = <0x0 0x21f0000 0x0 0x1000>; > > >> interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; > > >> current-speed = <115200>; > > >> -- > > >> 2.21.1 > > >> > > >> > > >> > > >> _______________________________________________ > > >> linux-arm-kernel mailing list > > >> linux-arm-kernel@lists.infradead.org > > >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > >> > > > > > > . > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] arm64: dts: lx2160a: Normalize the compatible string of "arm, sbsa-uart" 2021-06-12 10:11 ` Mark Kettenis @ 2021-06-15 11:38 ` Leizhen (ThunderTown) 0 siblings, 0 replies; 6+ messages in thread From: Leizhen (ThunderTown) @ 2021-06-15 11:38 UTC (permalink / raw) To: Mark Kettenis, Shawn Guo Cc: leoyang.li, robh+dt, linux-arm-kernel, devicetree, vabhav.sharma, linux On 2021/6/12 18:11, Mark Kettenis wrote: >> Date: Sat, 12 Jun 2021 10:10:58 +0800 >> From: Shawn Guo <shawnguo@kernel.org> >> >> On Tue, May 25, 2021 at 10:00:30AM +0800, Leizhen (ThunderTown) wrote: >>> >>> >>> On 2021/5/25 1:36, Mark Kettenis wrote: >>>>> From: Zhen Lei <thunder.leizhen@huawei.com> >>>>> Date: Mon, 24 May 2021 11:52:44 +0800 >>>>> Content-Type: text/plain; charset="us-ascii" >>>>> >>>>> The compatible string of ARM SBSA defined generic UART needs to contain >>>>> only "arm,sbsa-uart" and does not need to contain "arm,pl011". Otherwise, >>>>> the pl011.yaml will check it and falsely report many warnings similar to >>>>> the following: >>>>> >>>>> arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dt.yaml: >>>>> serial@21c0000: compatible:0: 'arm,pl011' was expected >>>>> serial@21c0000: compatible:1: 'arm,primecell' was expected >>>>> >>>>> Delete the redundant "arm,pl011" to fix it. >>>> >>>> According to its reference manual, the LX2160A has a full PL011 >>>> implementation. So I think this is the wrong "fix". >>> >>> No, No, Please refer: https://www.spinics.net/lists/devicetree/msg424054.html >>> >>> Now the "arm,sbsa-uart" driver is mixed with amba-pl011.c，It's impossible >>> "arm,pl011" is loaded but "arm,sbsa-uart" is not loaded. So it makes no sense >>> to append "arm, pl011" to the end of the compatible string as an alternative >>> driver. >>> >>> drivers/tty/serial/amba-pl011.c:2784: { .compatible = "arm,sbsa-uart", }, >> >> I guess Mark is suggesting the following fix. >> >> uart0: serial@21c0000 { >> - compatible = "arm,sbsa-uart","arm,pl011"; >> + compatible = "arm,pl011", "arm,primecell"; >> reg = <0x0 0x21c0000 0x0 0x1000>; >> interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; >> - current-speed = <115200>; >> status = "disabled"; >> }; >> >> I copied some folks who might help clarify whether LX2160A UART is a SBSA >> or a full PL011. > > Sorry, I missed Leizhen's original reply. But yes, that is what I > meant. According to the NXP documentation, the LX2160A has a real > PL011 UART, so the correct fix is what Shawn suggests above. Okay, so I'll prepare v2 on the advice of Shawn. > > Cheers, > > Mark > >>>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> >>>>> --- >>>>> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 8 ++++---- >>>>> 1 file changed, 4 insertions(+), 4 deletions(-) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >>>>> index 4fcc869c21a4..417546616d85 100644 >>>>> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >>>>> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >>>>> @@ -920,7 +920,7 @@ >>>>> }; >>>>> >>>>> uart0: serial@21c0000 { >>>>> - compatible = "arm,sbsa-uart","arm,pl011"; >>>>> + compatible = "arm,sbsa-uart"; >>>>> reg = <0x0 0x21c0000 0x0 0x1000>; >>>>> interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; >>>>> current-speed = <115200>; >>>>> @@ -928,7 +928,7 @@ >>>>> }; >>>>> >>>>> uart1: serial@21d0000 { >>>>> - compatible = "arm,sbsa-uart","arm,pl011"; >>>>> + compatible = "arm,sbsa-uart"; >>>>> reg = <0x0 0x21d0000 0x0 0x1000>; >>>>> interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>; >>>>> current-speed = <115200>; >>>>> @@ -936,7 +936,7 @@ >>>>> }; >>>>> >>>>> uart2: serial@21e0000 { >>>>> - compatible = "arm,sbsa-uart","arm,pl011"; >>>>> + compatible = "arm,sbsa-uart"; >>>>> reg = <0x0 0x21e0000 0x0 0x1000>; >>>>> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; >>>>> current-speed = <115200>; >>>>> @@ -944,7 +944,7 @@ >>>>> }; >>>>> >>>>> uart3: serial@21f0000 { >>>>> - compatible = "arm,sbsa-uart","arm,pl011"; >>>>> + compatible = "arm,sbsa-uart"; >>>>> reg = <0x0 0x21f0000 0x0 0x1000>; >>>>> interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; >>>>> current-speed = <115200>; >>>>> -- >>>>> 2.21.1 >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> linux-arm-kernel mailing list >>>>> linux-arm-kernel@lists.infradead.org >>>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >>>>> >>>> >>>> . >>>> >>> >> > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-15 18:21 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-05-24 3:52 [PATCH 1/1] arm64: dts: lx2160a: Normalize the compatible string of "arm, sbsa-uart" Zhen Lei 2021-05-24 17:36 ` Mark Kettenis 2021-05-25 2:00 ` Leizhen (ThunderTown) 2021-06-12 2:10 ` Shawn Guo 2021-06-12 10:11 ` Mark Kettenis 2021-06-15 11:38 ` Leizhen (ThunderTown)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).