From: Sudeep Holla <sudeep.holla@arm.com>
To: Etienne Carriere <etienne.carriere@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Cristian Marussi <cristian.marussi@arm.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jim Quinlan <jim2101024@gmail.com>,
Peter Hilber <peter.hilber@opensynergy.com>
Subject: Re: [PATCH 8/8] dt-bindings: firmware: arm,scmi: Convert to json schema
Date: Thu, 27 May 2021 11:53:34 +0100 [thread overview]
Message-ID: <20210527105334.ouz3pgth7whmqxzl@bogus> (raw)
In-Reply-To: <CAN5uoS_xdGRMki4jTM2tz5nGqjn8BmA5r0egWnngK=L94Y6uxQ@mail.gmail.com>
On Thu, May 27, 2021 at 08:37:58AM +0200, Etienne Carriere wrote:
> Hello Sudeep,
>
> On Wed, 26 May 2021 at 20:28, Sudeep Holla <sudeep.holla@arm.com> wrote:
> >
> > Convert the old text format binding for System Control and Management Interface
> > (SCMI) Message Protocol into the new and shiny YAML format.
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Cristian Marussi <cristian.marussi@arm.com>
> > Cc: Florian Fainelli <f.fainelli@gmail.com>
> > Cc: Jim Quinlan <jim2101024@gmail.com>
> > Cc: Etienne Carriere <etienne.carriere@linaro.org>
> > Cc: Peter Hilber <peter.hilber@opensynergy.com>
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> > .../devicetree/bindings/arm/arm,scmi.txt | 224 ---------------
> > .../bindings/firmware/arm,scmi.yaml | 270 ++++++++++++++++++
> > 2 files changed, 270 insertions(+), 224 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/arm/arm,scmi.txt
> > create mode 100644 Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> >
> > Hi,
> >
> > I have converted all the bindings except the below regulator part of the
> > binding. This needs to be addressed before merging ofcourse. Just posting
> > the remaining changes to get feedback and also ask suggestion for the below:
> >
> > scmi_voltage: protocol@17 {
> > reg = <0x17>;
> > regulators {
> > regulator_devX: regulator@0 {
> > reg = <0x0>;
> > regulator-max-microvolt = <3300000>;
> > };
> >
> > regulator_devY: regulator@9 {
> > reg = <0x9>;
> > regulator-min-microvolt = <500000>;
> > regulator-max-microvolt = <4200000>;
> > };
> > };
> > };
> >
> > I will reply with things I have tried separately to avoid confusion with this
> > the patch here.
>
> Few minor typos, but LGTM for this part, aside a comment on SCMI
> version reference.
>
> Both old and new descriptions refer to SCMI v1.0 (DEN0056A) in both
> description text and URL reference.
> Not mentioning the version would age better. From the implementation,
> versions are already well managed at discovery and enumeration so we
> don't expect regressions due to spec version.
>
> At:
> - the SCMI as described in ARM document number ARM DEN 0056A ("ARM
> System Control
> + the SCMI as described in ARM document number ARM DEN 0056 ("ARM
> System Control
> and at:
> - [0] http://infocenter.arm.com/help/topic/com.arm.doc.den0056a/index.html
> + [0] https://developer.arm.com/documentation/den0056/latest
>
Good point, most of the recent specs, I am referring to latest. This predates
that practice. I will update this and fix typos pointed out. Thanks for taking
a look at this.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-27 10:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 18:27 [PATCH 0/8] dt-bindings: firmware: Convert SCPI and SCMI to json schema Sudeep Holla
2021-05-26 18:28 ` [PATCH 1/8] dt-bindings: firmware: arm, scpi: Move arm, scpi-shmem " Sudeep Holla
2021-05-27 20:25 ` Rob Herring
2021-05-31 8:15 ` Sudeep Holla
2021-05-31 8:20 ` Sudeep Holla
2021-06-01 13:37 ` Rob Herring
2021-06-01 13:53 ` Sudeep Holla
2021-05-26 18:28 ` [PATCH 2/8] dt-bindings: firmware: arm, scmi: Move arm, scmi-shmem " Sudeep Holla
2021-05-26 18:28 ` [PATCH 3/8] dt-bindings: firmware: juno, scpi: Move to sram.yaml " Sudeep Holla
2021-05-26 18:28 ` [PATCH 4/8] dt-bindings: firmware: amlogic, scpi: Move arm, scpi-shmem to " Sudeep Holla
2021-05-26 18:28 ` [PATCH 5/8] dt-bindings: firmware: arm,scpi: Convert " Sudeep Holla
2021-05-27 14:23 ` [PATCH 5/8] dt-bindings: firmware: arm, scpi: " Rob Herring
2021-05-27 16:17 ` [PATCH 5/8] dt-bindings: firmware: arm,scpi: " Sudeep Holla
2021-05-26 18:28 ` [PATCH 6/8] dt-bindings: mailbox : arm, mhu: Fix arm, scpi example used here Sudeep Holla
2021-05-27 14:23 ` Rob Herring
2021-05-27 16:25 ` Sudeep Holla
2021-05-27 20:07 ` Rob Herring
2021-05-31 8:17 ` Sudeep Holla
2021-05-26 18:28 ` [PATCH 7/8] dt-bindings: firmware: amlogic, scpi: Convert to json schema Sudeep Holla
2021-05-27 20:33 ` Rob Herring
2021-05-31 8:36 ` Sudeep Holla
2021-05-26 18:28 ` [PATCH 8/8] dt-bindings: firmware: arm,scmi: " Sudeep Holla
2021-05-26 18:35 ` Sudeep Holla
2021-05-27 20:15 ` [PATCH 8/8] dt-bindings: firmware: arm, scmi: " Rob Herring
2021-05-27 6:37 ` Etienne Carriere
2021-05-27 10:53 ` Sudeep Holla [this message]
2021-05-27 10:33 ` [PATCH 8/8] dt-bindings: firmware: arm,scmi: " Cristian Marussi
2021-05-27 10:49 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527105334.ouz3pgth7whmqxzl@bogus \
--to=sudeep.holla@arm.com \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=etienne.carriere@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=jim2101024@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=peter.hilber@opensynergy.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).