From: Pratyush Yadav <p.yadav@ti.com>
To: <patrice.chotard@foss.st.com>
Cc: Mark Brown <broonie@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
<linux-mtd@lists.infradead.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
<linux-spi@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <christophe.kerello@foss.st.com>
Subject: Re: [PATCH v3 3/3] mtd: spinand: add SPI-NAND MTD resume handler
Date: Fri, 28 May 2021 17:35:10 +0530 [thread overview]
Message-ID: <20210528120508.f6viglv3gkzgweqq@ti.com> (raw)
In-Reply-To: <20210527161252.16620-4-patrice.chotard@foss.st.com>
On 27/05/21 06:12PM, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
>
> After power up, all SPI NAND's blocks are locked. Only read operations
> are allowed, write and erase operations are forbidden.
> The SPI NAND framework unlocks all the blocks during its initialization.
>
> During a standby low power, the memory is powered down, losing its
> configuration.
> During the resume, the QSPI driver state is restored but the SPI NAND
> framework does not reconfigured the memory.
>
> This patch adds SPI-NAND MTD PM handlers for resume ops.
> SPI NAND resume op re-initializes SPI NAND flash to its probed state.
>
> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
> Changes in v3:
> - Add spinand_read_cfg() call to repopulate cache
>
> Changes in v2:
> - Add helper spinand_block_unlock().
> - Add spinand_ecc_enable() call.
> - Remove some dev_err().
> - Fix commit's title and message.
>
> drivers/mtd/nand/spi/core.c | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> index 1f699ad84f1b..e3fcbcf381c3 100644
> --- a/drivers/mtd/nand/spi/core.c
> +++ b/drivers/mtd/nand/spi/core.c
> @@ -1099,6 +1099,38 @@ static int spinand_block_unlock(struct spinand_device *spinand)
> return ret;
> }
>
> +static void spinand_mtd_resume(struct mtd_info *mtd)
> +{
> + struct spinand_device *spinand = mtd_to_spinand(mtd);
> + int ret;
> +
> + ret = spinand_reset_op(spinand);
> + if (ret)
> + return;
> +
> + ret = spinand_read_cfg(spinand);
> + if (ret)
> + return;
> +
> + ret = spinand_init_quad_enable(spinand);
> + if (ret)
> + return;
> +
> + ret = spinand_upd_cfg(spinand, CFG_OTP_ENABLE, 0);
> + if (ret)
> + return;
> +
> + ret = spinand_manufacturer_init(spinand);
> + if (ret)
> + return;
> +
> + ret = spinand_block_unlock(spinand);
> + if (ret)
> + return;
> +
> + spinand_ecc_enable(spinand, false);
> +}
> +
I don't think you quite get what me and Miquel are suggesting.
The helper should call all these functions like read_cfg()
quad_enable(), etc. So it should look something like:
int spinand_init_flash()
{
ret = spinand_read_cfg(spinand);
if (ret)
return;
ret = spinand_init_quad_enable(spinand);
if (ret)
return;
ret = spinand_upd_cfg(spinand, CFG_OTP_ENABLE, 0);
if (ret)
return;
ret = spinand_manufacturer_init(spinand);
if (ret)
return;
ret = spinand_block_unlock(spinand);
if (ret)
return;
spinand_ecc_enable(spinand, false);
}
Then spinand_mtd_resume should look something like:
int spinand_mtd_resume()
{
ret = spinand_reset_op(spinand);
if (ret)
return;
return spinand_init_flash();
}
And spinand_init() should look something like:
int spinand_init()
{
...
spinand->oobbuf = ...
spinand_init_flash();
spinand_create_dirmaps();
...
}
> static int spinand_init(struct spinand_device *spinand)
> {
> struct device *dev = &spinand->spimem->spi->dev;
> @@ -1186,6 +1218,7 @@ static int spinand_init(struct spinand_device *spinand)
> mtd->_block_isreserved = spinand_mtd_block_isreserved;
> mtd->_erase = spinand_mtd_erase;
> mtd->_max_bad_blocks = nanddev_mtd_max_bad_blocks;
> + mtd->_resume = spinand_mtd_resume;
>
> if (nand->ecc.engine) {
> ret = mtd_ooblayout_count_freebytes(mtd);
> --
> 2.17.1
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-28 12:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 16:12 [PATCH v3 0/3] mtd: spinand: add SPI-NAND MTD resume handler patrice.chotard
2021-05-27 16:12 ` [PATCH v3 1/3] mtd: spinand: Add spinand_block_unlock() helper patrice.chotard
2021-05-27 16:12 ` [PATCH v3 2/3] mtd: spinand: add spinand_read_cfg() helper patrice.chotard
2021-05-27 16:12 ` [PATCH v3 3/3] mtd: spinand: add SPI-NAND MTD resume handler patrice.chotard
2021-05-27 16:23 ` Miquel Raynal
2021-05-28 8:22 ` Patrice CHOTARD
2021-05-28 12:05 ` Pratyush Yadav [this message]
2021-05-28 12:51 ` Patrice CHOTARD
2021-05-28 13:17 ` Pratyush Yadav
2021-05-28 14:31 ` Patrice CHOTARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528120508.f6viglv3gkzgweqq@ti.com \
--to=p.yadav@ti.com \
--cc=alexandre.torgue@foss.st.com \
--cc=boris.brezillon@collabora.com \
--cc=broonie@kernel.org \
--cc=christophe.kerello@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=miquel.raynal@bootlin.com \
--cc=patrice.chotard@foss.st.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).