* [PATCH v1] drm/mediatek: Add component_del in OVL remove function
@ 2021-07-09 3:43 jason-jh.lin
2021-08-10 1:58 ` CK Hu
0 siblings, 1 reply; 2+ messages in thread
From: jason-jh.lin @ 2021-07-09 3:43 UTC (permalink / raw)
To: chunkuang.hu, matthias.bgg
Cc: linux-arm-kernel, linux-mediatek, linux-kernel, devicetree,
Project_Global_Chrome_Upstream_Group, fshao, jason-jh.lin,
nancy.lin, singo.chang
Add component_del in OVL remove function to make it symmetrical
to component_add in probe function.
Fixes: ff1395609e20 ("drm/mediatek: Move mtk_ddp_comp_init() from sub driver to DRM driver")
Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
index 961f87f8d4d1..081c96aa7f72 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
@@ -158,7 +158,6 @@ void mtk_ovl_stop(struct device *dev)
reg = reg & ~OVL_LAYER_SMI_ID_EN;
writel_relaxed(reg, ovl->regs + DISP_REG_OVL_DATAPATH_CON);
}
-
}
void mtk_ovl_config(struct device *dev, unsigned int w,
@@ -424,6 +423,8 @@ static int mtk_disp_ovl_probe(struct platform_device *pdev)
static int mtk_disp_ovl_remove(struct platform_device *pdev)
{
+ component_del(&pdev->dev, &mtk_disp_ovl_component_ops);
+
return 0;
}
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] drm/mediatek: Add component_del in OVL remove function
2021-07-09 3:43 [PATCH v1] drm/mediatek: Add component_del in OVL remove function jason-jh.lin
@ 2021-08-10 1:58 ` CK Hu
0 siblings, 0 replies; 2+ messages in thread
From: CK Hu @ 2021-08-10 1:58 UTC (permalink / raw)
To: jason-jh.lin
Cc: chunkuang.hu, matthias.bgg, linux-arm-kernel, linux-mediatek,
linux-kernel, devicetree, Project_Global_Chrome_Upstream_Group,
fshao, nancy.lin, singo.chang
Hi, Jason:
On Fri, 2021-07-09 at 11:43 +0800, jason-jh.lin wrote:
> Add component_del in OVL remove function to make it symmetrical
> to component_add in probe function.
>
> Fixes: ff1395609e20 ("drm/mediatek: Move mtk_ddp_comp_init() from sub driver to DRM driver")
>
In patch [1], both OVL and COLOR has the same problem. I would like you
to fix both bug. It could be in one patch.
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.14-rc5&id=ff1395609e20c1cd98b3ec65d16dc18f0471dca3
Regards,
CK
> Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> index 961f87f8d4d1..081c96aa7f72 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> @@ -158,7 +158,6 @@ void mtk_ovl_stop(struct device *dev)
> reg = reg & ~OVL_LAYER_SMI_ID_EN;
> writel_relaxed(reg, ovl->regs + DISP_REG_OVL_DATAPATH_CON);
> }
> -
> }
>
> void mtk_ovl_config(struct device *dev, unsigned int w,
> @@ -424,6 +423,8 @@ static int mtk_disp_ovl_probe(struct platform_device *pdev)
>
> static int mtk_disp_ovl_remove(struct platform_device *pdev)
> {
> + component_del(&pdev->dev, &mtk_disp_ovl_component_ops);
> +
> return 0;
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-10 2:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09 3:43 [PATCH v1] drm/mediatek: Add component_del in OVL remove function jason-jh.lin
2021-08-10 1:58 ` CK Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).