* [PATCH RESEND] dt-bindings: i2c: brcm, iproc-i2c: convert to the json-schema
@ 2021-07-13 9:31 Rafał Miłecki
2021-07-15 17:13 ` [PATCH RESEND] dt-bindings: i2c: brcm,iproc-i2c: " Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Rafał Miłecki @ 2021-07-13 9:31 UTC (permalink / raw)
To: Rob Herring, Florian Fainelli, linux-i2c
Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, devicetree,
linux-arm-kernel, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
This helps validating DTS files.
Introduced changes:
1. Added arm-gic.h include
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
RESEND: commit 11480dbfe1d5 ("ASoC: wm8750: convert to the json-schema")
is part of the 5.14-rc1 so Rob's bot should be happy this time.
---
.../bindings/i2c/brcm,iproc-i2c.txt | 46 ------------
.../bindings/i2c/brcm,iproc-i2c.yaml | 71 +++++++++++++++++++
2 files changed, 71 insertions(+), 46 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
create mode 100644 Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.yaml
diff --git a/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
deleted file mode 100644
index d12cc33cca6c..000000000000
--- a/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
+++ /dev/null
@@ -1,46 +0,0 @@
-Broadcom iProc I2C controller
-
-Required properties:
-
-- compatible:
- Must be "brcm,iproc-i2c" or "brcm,iproc-nic-i2c"
-
-- reg:
- Define the base and range of the I/O address space that contain the iProc
- I2C controller registers
-
-- clock-frequency:
- This is the I2C bus clock. Need to be either 100000 or 400000
-
-- #address-cells:
- Always 1 (for I2C addresses)
-
-- #size-cells:
- Always 0
-
-Optional properties:
-
-- interrupts:
- Should contain the I2C interrupt. For certain revisions of the I2C
- controller, I2C interrupt is unwired to the interrupt controller. In such
- case, this property should be left unspecified, and driver will fall back
- to polling mode
-
-- brcm,ape-hsls-addr-mask:
- Required for "brcm,iproc-nic-i2c". Host view of address mask into the
- 'APE' co-processor. Value must be unsigned, 32-bit
-
-Example:
- i2c0: i2c@18008000 {
- compatible = "brcm,iproc-i2c";
- reg = <0x18008000 0x100>;
- #address-cells = <1>;
- #size-cells = <0>;
- interrupts = <GIC_SPI 85 IRQ_TYPE_NONE>;
- clock-frequency = <100000>;
-
- codec: wm8750@1a {
- compatible = "wlf,wm8750";
- reg = <0x1a>;
- };
- };
diff --git a/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.yaml b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.yaml
new file mode 100644
index 000000000000..2aa75b7add7b
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.yaml
@@ -0,0 +1,71 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/brcm,iproc-i2c.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom iProc I2C controller
+
+maintainers:
+ - Rafał Miłecki <rafal@milecki.pl>
+
+properties:
+ compatible:
+ enum:
+ - brcm,iproc-i2c
+ - brcm,iproc-nic-i2c
+
+ reg:
+ maxItems: 1
+
+ clock-frequency:
+ enum: [ 100000, 400000 ]
+
+ interrupts:
+ description: |
+ Should contain the I2C interrupt. For certain revisions of the I2C
+ controller, I2C interrupt is unwired to the interrupt controller. In such
+ case, this property should be left unspecified, and driver will fall back
+ to polling mode
+ maxItems: 1
+
+ brcm,ape-hsls-addr-mask:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Host view of address mask into the 'APE' co-processor
+
+allOf:
+ - $ref: /schemas/i2c/i2c-controller.yaml#
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: brcm,iproc-nic-i2c
+ then:
+ required:
+ - brcm,ape-hsls-addr-mask
+
+unevaluatedProperties: false
+
+required:
+ - reg
+ - clock-frequency
+ - '#address-cells'
+ - '#size-cells'
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ i2c@18008000 {
+ compatible = "brcm,iproc-i2c";
+ reg = <0x18008000 0x100>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupts = <GIC_SPI 85 IRQ_TYPE_NONE>;
+ clock-frequency = <100000>;
+
+ wm8750@1a {
+ compatible = "wlf,wm8750";
+ reg = <0x1a>;
+ };
+ };
--
2.26.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] dt-bindings: i2c: brcm,iproc-i2c: convert to the json-schema
2021-07-13 9:31 [PATCH RESEND] dt-bindings: i2c: brcm, iproc-i2c: convert to the json-schema Rafał Miłecki
@ 2021-07-15 17:13 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2021-07-15 17:13 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Florian Fainelli, Ray Jui, Scott Branden,
Rafał Miłecki, Rob Herring, devicetree,
linux-arm-kernel, bcm-kernel-feedback-list, linux-i2c
On Tue, 13 Jul 2021 11:31:55 +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This helps validating DTS files.
>
> Introduced changes:
> 1. Added arm-gic.h include
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> RESEND: commit 11480dbfe1d5 ("ASoC: wm8750: convert to the json-schema")
> is part of the 5.14-rc1 so Rob's bot should be happy this time.
> ---
> .../bindings/i2c/brcm,iproc-i2c.txt | 46 ------------
> .../bindings/i2c/brcm,iproc-i2c.yaml | 71 +++++++++++++++++++
> 2 files changed, 71 insertions(+), 46 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
> create mode 100644 Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.yaml
>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-15 17:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-13 9:31 [PATCH RESEND] dt-bindings: i2c: brcm, iproc-i2c: convert to the json-schema Rafał Miłecki
2021-07-15 17:13 ` [PATCH RESEND] dt-bindings: i2c: brcm,iproc-i2c: " Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).