* [PATCH] iio: adc: fsl-imx25-gcq: Use the defined variable to clean code
@ 2021-07-20 12:59 Tang Bin
2021-07-24 15:27 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2021-07-20 12:59 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw, shawnguo, s.hauer, kernel,
broonie, lgirdwood
Cc: linux-iio, linux-arm-kernel, linux-kernel, Tang Bin, Zhang Shengju
Use the defined variable "dev" to make the code cleaner.
Co-developed-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/iio/adc/fsl-imx25-gcq.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
index d28976f21..01fe5b137 100644
--- a/drivers/iio/adc/fsl-imx25-gcq.c
+++ b/drivers/iio/adc/fsl-imx25-gcq.c
@@ -192,11 +192,11 @@ static int mx25_gcq_setup_cfgs(struct platform_device *pdev,
*/
priv->vref[MX25_ADC_REFP_INT] = NULL;
priv->vref[MX25_ADC_REFP_EXT] =
- devm_regulator_get_optional(&pdev->dev, "vref-ext");
+ devm_regulator_get_optional(dev, "vref-ext");
priv->vref[MX25_ADC_REFP_XP] =
- devm_regulator_get_optional(&pdev->dev, "vref-xp");
+ devm_regulator_get_optional(dev, "vref-xp");
priv->vref[MX25_ADC_REFP_YP] =
- devm_regulator_get_optional(&pdev->dev, "vref-yp");
+ devm_regulator_get_optional(dev, "vref-yp");
for_each_child_of_node(np, child) {
u32 reg;
@@ -298,7 +298,7 @@ static int mx25_gcq_probe(struct platform_device *pdev)
int ret;
int i;
- indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*priv));
+ indio_dev = devm_iio_device_alloc(dev, sizeof(*priv));
if (!indio_dev)
return -ENOMEM;
--
2.20.1.windows.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: fsl-imx25-gcq: Use the defined variable to clean code
2021-07-20 12:59 [PATCH] iio: adc: fsl-imx25-gcq: Use the defined variable to clean code Tang Bin
@ 2021-07-24 15:27 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2021-07-24 15:27 UTC (permalink / raw)
To: Tang Bin
Cc: knaack.h, lars, pmeerw, shawnguo, s.hauer, kernel, broonie,
lgirdwood, linux-iio, linux-arm-kernel, linux-kernel,
Zhang Shengju
On Tue, 20 Jul 2021 20:59:45 +0800
Tang Bin <tangbin@cmss.chinamobile.com> wrote:
> Use the defined variable "dev" to make the code cleaner.
>
> Co-developed-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/adc/fsl-imx25-gcq.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
> index d28976f21..01fe5b137 100644
> --- a/drivers/iio/adc/fsl-imx25-gcq.c
> +++ b/drivers/iio/adc/fsl-imx25-gcq.c
> @@ -192,11 +192,11 @@ static int mx25_gcq_setup_cfgs(struct platform_device *pdev,
> */
> priv->vref[MX25_ADC_REFP_INT] = NULL;
> priv->vref[MX25_ADC_REFP_EXT] =
> - devm_regulator_get_optional(&pdev->dev, "vref-ext");
> + devm_regulator_get_optional(dev, "vref-ext");
> priv->vref[MX25_ADC_REFP_XP] =
> - devm_regulator_get_optional(&pdev->dev, "vref-xp");
> + devm_regulator_get_optional(dev, "vref-xp");
> priv->vref[MX25_ADC_REFP_YP] =
> - devm_regulator_get_optional(&pdev->dev, "vref-yp");
> + devm_regulator_get_optional(dev, "vref-yp");
>
> for_each_child_of_node(np, child) {
> u32 reg;
> @@ -298,7 +298,7 @@ static int mx25_gcq_probe(struct platform_device *pdev)
> int ret;
> int i;
>
> - indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*priv));
> + indio_dev = devm_iio_device_alloc(dev, sizeof(*priv));
> if (!indio_dev)
> return -ENOMEM;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-24 15:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 12:59 [PATCH] iio: adc: fsl-imx25-gcq: Use the defined variable to clean code Tang Bin
2021-07-24 15:27 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).