* [PATCH] media: rockchip: rkisp1: use device name for debugfs subdir name
@ 2021-10-10 17:54 Mikhail Rudenko
2021-10-12 3:24 ` Ezequiel Garcia
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mikhail Rudenko @ 2021-10-10 17:54 UTC (permalink / raw)
To: linux-media
Cc: Mikhail Rudenko, Helen Koike, Dafna Hirschfeld,
Mauro Carvalho Chehab, Heiko Stuebner, linux-rockchip,
linux-arm-kernel, linux-kernel
While testing Rockchip RK3399 with both ISPs enabled, a dmesg error
was observed:
```
[ 15.559141] debugfs: Directory 'rkisp1' with parent '/' already present!
```
Fix it by using the device name for the debugfs subdirectory name
instead of the driver name, thus preventing name collision.
Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
index 7474150b94ed..560f928c3752 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
@@ -426,7 +426,7 @@ static void rkisp1_debug_init(struct rkisp1_device *rkisp1)
{
struct rkisp1_debug *debug = &rkisp1->debug;
- debug->debugfs_dir = debugfs_create_dir(RKISP1_DRIVER_NAME, NULL);
+ debug->debugfs_dir = debugfs_create_dir(dev_name(rkisp1->dev), NULL);
debugfs_create_ulong("data_loss", 0444, debug->debugfs_dir,
&debug->data_loss);
debugfs_create_ulong("outform_size_err", 0444, debug->debugfs_dir,
--
2.33.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] media: rockchip: rkisp1: use device name for debugfs subdir name
2021-10-10 17:54 [PATCH] media: rockchip: rkisp1: use device name for debugfs subdir name Mikhail Rudenko
@ 2021-10-12 3:24 ` Ezequiel Garcia
2021-10-12 12:50 ` Kieran Bingham
2021-11-13 23:33 ` Mikhail Rudenko
2 siblings, 0 replies; 4+ messages in thread
From: Ezequiel Garcia @ 2021-10-12 3:24 UTC (permalink / raw)
To: Mikhail Rudenko
Cc: linux-media, Helen Koike, Dafna Hirschfeld,
Mauro Carvalho Chehab, Heiko Stuebner, linux-rockchip,
linux-arm-kernel, linux-kernel
On Sun, Oct 10, 2021 at 08:54:57PM +0300, Mikhail Rudenko wrote:
> While testing Rockchip RK3399 with both ISPs enabled, a dmesg error
> was observed:
> ```
> [ 15.559141] debugfs: Directory 'rkisp1' with parent '/' already present!
> ```
>
> Fix it by using the device name for the debugfs subdirectory name
> instead of the driver name, thus preventing name collision.
>
> Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Thanks!
> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> index 7474150b94ed..560f928c3752 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> @@ -426,7 +426,7 @@ static void rkisp1_debug_init(struct rkisp1_device *rkisp1)
> {
> struct rkisp1_debug *debug = &rkisp1->debug;
>
> - debug->debugfs_dir = debugfs_create_dir(RKISP1_DRIVER_NAME, NULL);
> + debug->debugfs_dir = debugfs_create_dir(dev_name(rkisp1->dev), NULL);
> debugfs_create_ulong("data_loss", 0444, debug->debugfs_dir,
> &debug->data_loss);
> debugfs_create_ulong("outform_size_err", 0444, debug->debugfs_dir,
> --
> 2.33.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: rockchip: rkisp1: use device name for debugfs subdir name
2021-10-10 17:54 [PATCH] media: rockchip: rkisp1: use device name for debugfs subdir name Mikhail Rudenko
2021-10-12 3:24 ` Ezequiel Garcia
@ 2021-10-12 12:50 ` Kieran Bingham
2021-11-13 23:33 ` Mikhail Rudenko
2 siblings, 0 replies; 4+ messages in thread
From: Kieran Bingham @ 2021-10-12 12:50 UTC (permalink / raw)
To: Mikhail Rudenko, linux-media
Cc: Mikhail Rudenko, Helen Koike, Dafna Hirschfeld,
Mauro Carvalho Chehab, Heiko Stuebner, linux-rockchip,
linux-arm-kernel, linux-kernel
Hi Mikhail,
Quoting Mikhail Rudenko (2021-10-10 18:54:57)
> While testing Rockchip RK3399 with both ISPs enabled, a dmesg error
> was observed:
> ```
> [ 15.559141] debugfs: Directory 'rkisp1' with parent '/' already present!
> ```
>
> Fix it by using the device name for the debugfs subdirectory name
> instead of the driver name, thus preventing name collision.
>
> Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> index 7474150b94ed..560f928c3752 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> @@ -426,7 +426,7 @@ static void rkisp1_debug_init(struct rkisp1_device *rkisp1)
> {
> struct rkisp1_debug *debug = &rkisp1->debug;
>
> - debug->debugfs_dir = debugfs_create_dir(RKISP1_DRIVER_NAME, NULL);
> + debug->debugfs_dir = debugfs_create_dir(dev_name(rkisp1->dev), NULL);
I would wonder if they should be grouped under a subdir called rkisp1
... but that would then still keep the same issue that whichever was
second to probe would find that /rkisp1 was already present. I suspect
debugfs would make it possible to check if the parent was already there
and only create it if it exists, but anyway, it would then be harder to
clean up too.
So separate based on the nodes sounds perfectly reasonable to me.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> debugfs_create_ulong("data_loss", 0444, debug->debugfs_dir,
> &debug->data_loss);
> debugfs_create_ulong("outform_size_err", 0444, debug->debugfs_dir,
> --
> 2.33.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: rockchip: rkisp1: use device name for debugfs subdir name
2021-10-10 17:54 [PATCH] media: rockchip: rkisp1: use device name for debugfs subdir name Mikhail Rudenko
2021-10-12 3:24 ` Ezequiel Garcia
2021-10-12 12:50 ` Kieran Bingham
@ 2021-11-13 23:33 ` Mikhail Rudenko
2 siblings, 0 replies; 4+ messages in thread
From: Mikhail Rudenko @ 2021-11-13 23:33 UTC (permalink / raw)
To: linux-media
Cc: Mikhail Rudenko, Helen Koike, Dafna Hirschfeld,
Mauro Carvalho Chehab, Heiko Stuebner, linux-rockchip,
linux-arm-kernel, linux-kernel
On 2021-10-10 at 20:54 +03, Mikhail Rudenko <mike.rudenko@gmail.com> wrote:
> While testing Rockchip RK3399 with both ISPs enabled, a dmesg error
> was observed:
> ```
> [ 15.559141] debugfs: Directory 'rkisp1' with parent '/' already present!
> ```
>
> Fix it by using the device name for the debugfs subdirectory name
> instead of the driver name, thus preventing name collision.
>
> Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> index 7474150b94ed..560f928c3752 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> @@ -426,7 +426,7 @@ static void rkisp1_debug_init(struct rkisp1_device *rkisp1)
> {
> struct rkisp1_debug *debug = &rkisp1->debug;
>
> - debug->debugfs_dir = debugfs_create_dir(RKISP1_DRIVER_NAME, NULL);
> + debug->debugfs_dir = debugfs_create_dir(dev_name(rkisp1->dev), NULL);
> debugfs_create_ulong("data_loss", 0444, debug->debugfs_dir,
> &debug->data_loss);
> debugfs_create_ulong("outform_size_err", 0444, debug->debugfs_dir,
Gentle ping. Could this be merged please?
--
Best regards,
Mikhail Rudenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-13 23:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-10 17:54 [PATCH] media: rockchip: rkisp1: use device name for debugfs subdir name Mikhail Rudenko
2021-10-12 3:24 ` Ezequiel Garcia
2021-10-12 12:50 ` Kieran Bingham
2021-11-13 23:33 ` Mikhail Rudenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).