* [PATCH 01/22] usb: host: ehci-exynos: deny IRQ0
[not found] <20211018183930.8448-1-s.shtylyov@omp.ru>
@ 2021-10-18 18:39 ` Sergey Shtylyov
2021-10-18 18:39 ` [PATCH 05/22] usb: host: ehci-platform: " Sergey Shtylyov
` (6 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Sergey Shtylyov @ 2021-10-18 18:39 UTC (permalink / raw)
To: linux-usb, Alan Stern, Greg Kroah-Hartman
Cc: Krzysztof Kozlowski, linux-arm-kernel, linux-samsung-soc
If platform_get_irq() returns IRQ0 (considered invalid according to Linus)
the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ
at all. Deny IRQ0 right away, returning -EINVAL from the probe() method...
Fixes: 44ed240d6273 ("usb: host: ehci-exynos: Fix error check in exynos_ehci_probe()")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/usb/host/ehci-exynos.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
index 1a9b7572e17f..ff4e1261801a 100644
--- a/drivers/usb/host/ehci-exynos.c
+++ b/drivers/usb/host/ehci-exynos.c
@@ -207,6 +207,10 @@ static int exynos_ehci_probe(struct platform_device *pdev)
err = irq;
goto fail_io;
}
+ if (!irq) {
+ err = -EINVAL;
+ goto fail_io;
+ }
err = exynos_ehci_phy_enable(&pdev->dev);
if (err) {
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 05/22] usb: host: ehci-platform: deny IRQ0
[not found] <20211018183930.8448-1-s.shtylyov@omp.ru>
2021-10-18 18:39 ` [PATCH 01/22] usb: host: ehci-exynos: deny IRQ0 Sergey Shtylyov
@ 2021-10-18 18:39 ` Sergey Shtylyov
2021-10-18 18:39 ` [PATCH 07/22] usb: host: ehci-st: " Sergey Shtylyov
` (5 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Sergey Shtylyov @ 2021-10-18 18:39 UTC (permalink / raw)
To: linux-usb, Alan Stern, Greg Kroah-Hartman; +Cc: linux-arm-kernel
If platform_get_irq() returns IRQ0 (considered invalid according to Linus)
the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ
at all. Deny IRQ0 right away, returning -EINVAL from the probe() method...
Fixes: 7a7a4a592f42 ("USB: EHCI: Add a generic platform device driver")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/usb/host/ehci-platform.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
index c70f2d0b4aaf..1b20af65d799 100644
--- a/drivers/usb/host/ehci-platform.c
+++ b/drivers/usb/host/ehci-platform.c
@@ -265,6 +265,8 @@ static int ehci_platform_probe(struct platform_device *dev)
irq = platform_get_irq(dev, 0);
if (irq < 0)
return irq;
+ if (!irq)
+ return -EINVAL;
hcd = usb_create_hcd(&ehci_platform_hc_driver, &dev->dev,
dev_name(&dev->dev));
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 07/22] usb: host: ehci-st: deny IRQ0
[not found] <20211018183930.8448-1-s.shtylyov@omp.ru>
2021-10-18 18:39 ` [PATCH 01/22] usb: host: ehci-exynos: deny IRQ0 Sergey Shtylyov
2021-10-18 18:39 ` [PATCH 05/22] usb: host: ehci-platform: " Sergey Shtylyov
@ 2021-10-18 18:39 ` Sergey Shtylyov
2021-10-18 18:39 ` [PATCH 08/22] usb: host: ohci-at91: " Sergey Shtylyov
` (4 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Sergey Shtylyov @ 2021-10-18 18:39 UTC (permalink / raw)
To: linux-usb, Alan Stern, Greg Kroah-Hartman
Cc: Patrice Chotard, linux-arm-kernel
If platform_get_irq() returns IRQ0 (considered invalid according to Linus)
the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ
at all. Deny IRQ0 right away, returning -EINVAL from the probe() method...
Fixes: e47c5a0906f9 ("usb: host: ehci-st: Add EHCI support for ST STB devices")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/usb/host/ehci-st.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c
index f74433aac948..5f53c313f943 100644
--- a/drivers/usb/host/ehci-st.c
+++ b/drivers/usb/host/ehci-st.c
@@ -160,6 +160,8 @@ static int st_ehci_platform_probe(struct platform_device *dev)
irq = platform_get_irq(dev, 0);
if (irq < 0)
return irq;
+ if (!irq)
+ return -EINVAL;
res_mem = platform_get_resource(dev, IORESOURCE_MEM, 0);
if (!res_mem) {
dev_err(&dev->dev, "no memory resource provided");
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 08/22] usb: host: ohci-at91: deny IRQ0
[not found] <20211018183930.8448-1-s.shtylyov@omp.ru>
` (2 preceding siblings ...)
2021-10-18 18:39 ` [PATCH 07/22] usb: host: ehci-st: " Sergey Shtylyov
@ 2021-10-18 18:39 ` Sergey Shtylyov
2021-10-18 18:39 ` [PATCH 10/22] usb: host: ohci-exynos: " Sergey Shtylyov
` (3 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Sergey Shtylyov @ 2021-10-18 18:39 UTC (permalink / raw)
To: linux-usb, Alan Stern, Greg Kroah-Hartman
Cc: Alexandre Belloni, Ludovic Desroches, linux-arm-kernel
If platform_get_irq() returns IRQ0 (considered invalid according to Linus)
the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ
at all. Deny IRQ0 right away, returning -EINVAL from the probe() method...
Fixes: fb5f1834c322 ("usb: ohci-at91: fix irq and iomem resource retrieval")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/usb/host/ohci-at91.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index a24aea3d2759..6a7276a730d1 100644
--- a/drivers/usb/host/ohci-at91.c
+++ b/drivers/usb/host/ohci-at91.c
@@ -181,6 +181,8 @@ static int usb_hcd_at91_probe(const struct hc_driver *driver,
dev_dbg(dev, "hcd probe: missing irq resource\n");
return irq;
}
+ if (!irq)
+ return -EINVAL;
hcd = usb_create_hcd(driver, dev, "at91");
if (!hcd)
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 10/22] usb: host: ohci-exynos: deny IRQ0
[not found] <20211018183930.8448-1-s.shtylyov@omp.ru>
` (3 preceding siblings ...)
2021-10-18 18:39 ` [PATCH 08/22] usb: host: ohci-at91: " Sergey Shtylyov
@ 2021-10-18 18:39 ` Sergey Shtylyov
2021-10-18 18:39 ` [PATCH 11/22] usb: host: ohci-at91: " Sergey Shtylyov
` (2 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Sergey Shtylyov @ 2021-10-18 18:39 UTC (permalink / raw)
To: linux-usb, Alan Stern, Greg Kroah-Hartman
Cc: Krzysztof Kozlowski, linux-arm-kernel, linux-samsung-soc
If platform_get_irq() returns IRQ0 (considered invalid according to Linus)
the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ
at all. Deny IRQ0 right away, returning -EINVAL from the probe() method...
Fixes: 1d4169834628 ("usb: host: ohci-exynos: Fix error handling in exynos_ohci_probe()")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/usb/host/ohci-exynos.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c
index 5f5e8a64c8e2..f28f28e42f43 100644
--- a/drivers/usb/host/ohci-exynos.c
+++ b/drivers/usb/host/ohci-exynos.c
@@ -175,6 +175,10 @@ static int exynos_ohci_probe(struct platform_device *pdev)
err = irq;
goto fail_io;
}
+ if (!irq) {
+ err = -EINVAL;
+ goto fail_io;
+ }
platform_set_drvdata(pdev, hcd);
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 11/22] usb: host: ohci-at91: deny IRQ0
[not found] <20211018183930.8448-1-s.shtylyov@omp.ru>
` (4 preceding siblings ...)
2021-10-18 18:39 ` [PATCH 10/22] usb: host: ohci-exynos: " Sergey Shtylyov
@ 2021-10-18 18:39 ` Sergey Shtylyov
2021-10-19 11:15 ` Alexander Dahl
2021-10-18 18:39 ` [PATCH 17/22] usb: host: ohci-st: " Sergey Shtylyov
2021-10-18 18:39 ` [PATCH 20/22] usb: host: xhci-mtk: " Sergey Shtylyov
7 siblings, 1 reply; 11+ messages in thread
From: Sergey Shtylyov @ 2021-10-18 18:39 UTC (permalink / raw)
To: linux-usb, Alan Stern, Greg Kroah-Hartman
Cc: Vladimir Zapolskiy, linux-arm-kernel
If platform_get_irq() returns IRQ0 (considered invalid according to Linus)
the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ
at all. Deny IRQ0 right away, returning -EINVAL from the probe() method...
Fixes: 60bbfc84b6d9 ("USB OHCI controller support for PNX4008")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/usb/host/ohci-nxp.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
index 85878e8ad331..afb9c2fc85c3 100644
--- a/drivers/usb/host/ohci-nxp.c
+++ b/drivers/usb/host/ohci-nxp.c
@@ -215,6 +215,10 @@ static int ohci_hcd_nxp_probe(struct platform_device *pdev)
ret = -ENXIO;
goto fail_resource;
}
+ if (!irq) {
+ ret = -EINVAL;
+ goto fail_resource;
+ }
ohci_nxp_start_hc();
platform_set_drvdata(pdev, hcd);
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 11/22] usb: host: ohci-at91: deny IRQ0
2021-10-18 18:39 ` [PATCH 11/22] usb: host: ohci-at91: " Sergey Shtylyov
@ 2021-10-19 11:15 ` Alexander Dahl
2021-10-19 16:51 ` Sergey Shtylyov
0 siblings, 1 reply; 11+ messages in thread
From: Alexander Dahl @ 2021-10-19 11:15 UTC (permalink / raw)
To: Sergey Shtylyov
Cc: linux-usb, Alan Stern, Greg Kroah-Hartman, Vladimir Zapolskiy,
linux-arm-kernel
Hello Sergey,
Am Mon, Oct 18, 2021 at 09:39:19PM +0300 schrieb Sergey Shtylyov:
> If platform_get_irq() returns IRQ0 (considered invalid according to Linus)
> the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ
> at all. Deny IRQ0 right away, returning -EINVAL from the probe() method...
>
> Fixes: 60bbfc84b6d9 ("USB OHCI controller support for PNX4008")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> ---
> drivers/usb/host/ohci-nxp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
> index 85878e8ad331..afb9c2fc85c3 100644
> --- a/drivers/usb/host/ohci-nxp.c
> +++ b/drivers/usb/host/ohci-nxp.c
> @@ -215,6 +215,10 @@ static int ohci_hcd_nxp_probe(struct platform_device *pdev)
> ret = -ENXIO;
> goto fail_resource;
> }
> + if (!irq) {
> + ret = -EINVAL;
> + goto fail_resource;
> + }
>
> ohci_nxp_start_hc();
> platform_set_drvdata(pdev, hcd);
Subject refers to at91 while content is about nxp.
Greets
Alex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 11/22] usb: host: ohci-at91: deny IRQ0
2021-10-19 11:15 ` Alexander Dahl
@ 2021-10-19 16:51 ` Sergey Shtylyov
0 siblings, 0 replies; 11+ messages in thread
From: Sergey Shtylyov @ 2021-10-19 16:51 UTC (permalink / raw)
To: linux-usb, Alan Stern, Greg Kroah-Hartman, Vladimir Zapolskiy,
linux-arm-kernel
On 10/19/21 2:15 PM, Alexander Dahl wrote:
>> If platform_get_irq() returns IRQ0 (considered invalid according to Linus)
>> the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ
>> at all. Deny IRQ0 right away, returning -EINVAL from the probe() method...
>>
>> Fixes: 60bbfc84b6d9 ("USB OHCI controller support for PNX4008")
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>> ---
>> drivers/usb/host/ohci-nxp.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
>> index 85878e8ad331..afb9c2fc85c3 100644
>> --- a/drivers/usb/host/ohci-nxp.c
>> +++ b/drivers/usb/host/ohci-nxp.c
>> @@ -215,6 +215,10 @@ static int ohci_hcd_nxp_probe(struct platform_device *pdev)
>> ret = -ENXIO;
>> goto fail_resource;
>> }
>> + if (!irq) {
>> + ret = -EINVAL;
>> + goto fail_resource;
>> + }
>>
>> ohci_nxp_start_hc();
>> platform_set_drvdata(pdev, hcd);
>
> Subject refers to at91 while content is about nxp.
Oops, sorry! :-<
That's what you get when you send 22 patches fixing the same issue... :-)
> Greets
> Alex
MBR, Sergey
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 17/22] usb: host: ohci-st: deny IRQ0
[not found] <20211018183930.8448-1-s.shtylyov@omp.ru>
` (5 preceding siblings ...)
2021-10-18 18:39 ` [PATCH 11/22] usb: host: ohci-at91: " Sergey Shtylyov
@ 2021-10-18 18:39 ` Sergey Shtylyov
2021-10-18 18:39 ` [PATCH 20/22] usb: host: xhci-mtk: " Sergey Shtylyov
7 siblings, 0 replies; 11+ messages in thread
From: Sergey Shtylyov @ 2021-10-18 18:39 UTC (permalink / raw)
To: linux-usb, Alan Stern, Greg Kroah-Hartman
Cc: Patrice Chotard, linux-arm-kernel
If platform_get_irq() returns IRQ0 (considered invalid according to Linus)
the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ
at all. Deny IRQ0 right away, returning -EINVAL from the probe() method...
Fixes: d115837259ad ("usb: host: ohci-st: Add OHCI driver support for ST STB devices")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/usb/host/ohci-st.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/ohci-st.c b/drivers/usb/host/ohci-st.c
index ac796ccd93ef..b9200071ce6c 100644
--- a/drivers/usb/host/ohci-st.c
+++ b/drivers/usb/host/ohci-st.c
@@ -140,6 +140,8 @@ static int st_ohci_platform_probe(struct platform_device *dev)
irq = platform_get_irq(dev, 0);
if (irq < 0)
return irq;
+ if (!irq)
+ return -EINVAL;
res_mem = platform_get_resource(dev, IORESOURCE_MEM, 0);
if (!res_mem) {
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 20/22] usb: host: xhci-mtk: deny IRQ0
[not found] <20211018183930.8448-1-s.shtylyov@omp.ru>
` (6 preceding siblings ...)
2021-10-18 18:39 ` [PATCH 17/22] usb: host: ohci-st: " Sergey Shtylyov
@ 2021-10-18 18:39 ` Sergey Shtylyov
2021-10-20 7:32 ` Chunfeng Yun
7 siblings, 1 reply; 11+ messages in thread
From: Sergey Shtylyov @ 2021-10-18 18:39 UTC (permalink / raw)
To: linux-usb, Mathias Nyman, Greg Kroah-Hartman
Cc: Chunfeng Yun, Matthias Brugger, linux-arm-kernel, linux-mediatek
If platform_get_irq() returns IRQ0 (considered invalid according to Linus)
the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ
at all. Deny IRQ0 right away, returning -EINVAL from the probe() method...
Fixes: 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/usb/host/xhci-mtk.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index c53f6f276d5c..d2dc8d9863ee 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -495,7 +495,7 @@ static int xhci_mtk_probe(struct platform_device *pdev)
return ret;
irq = platform_get_irq_byname_optional(pdev, "host");
- if (irq < 0) {
+ if (irq <= 0) {
if (irq == -EPROBE_DEFER)
return irq;
@@ -503,6 +503,8 @@ static int xhci_mtk_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
+ if (!irq)
+ return -EINVAL;
}
wakeup_irq = platform_get_irq_byname_optional(pdev, "wakeup");
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 20/22] usb: host: xhci-mtk: deny IRQ0
2021-10-18 18:39 ` [PATCH 20/22] usb: host: xhci-mtk: " Sergey Shtylyov
@ 2021-10-20 7:32 ` Chunfeng Yun
0 siblings, 0 replies; 11+ messages in thread
From: Chunfeng Yun @ 2021-10-20 7:32 UTC (permalink / raw)
To: Sergey Shtylyov, linux-usb, Mathias Nyman, Greg Kroah-Hartman
Cc: Matthias Brugger, linux-arm-kernel, linux-mediatek
On Mon, 2021-10-18 at 21:39 +0300, Sergey Shtylyov wrote:
> If platform_get_irq() returns IRQ0 (considered invalid according to
> Linus)
> the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no
> IRQ
> at all. Deny IRQ0 right away, returning -EINVAL from the probe()
> method...
>
> Fixes: 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host
> controller")
Fixes the following patch:
04284eb74e0c usb: xhci-mtk: add support runtime PM
It introduced the 'host' irq
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> ---
> drivers/usb/host/xhci-mtk.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-
> mtk.c
> index c53f6f276d5c..d2dc8d9863ee 100644
> --- a/drivers/usb/host/xhci-mtk.c
> +++ b/drivers/usb/host/xhci-mtk.c
> @@ -495,7 +495,7 @@ static int xhci_mtk_probe(struct platform_device
> *pdev)
> return ret;
>
> irq = platform_get_irq_byname_optional(pdev, "host");
> - if (irq < 0) {
> + if (irq <= 0) {
> if (irq == -EPROBE_DEFER)
> return irq;
>
> @@ -503,6 +503,8 @@ static int xhci_mtk_probe(struct platform_device
> *pdev)
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> return irq;
> + if (!irq)
if (irq <= 0) ?
Thanks
> + return -EINVAL;
> }
>
> wakeup_irq = platform_get_irq_byname_optional(pdev, "wakeup");
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread