From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
joel@jms.id.au, andrew@aj.id.au, lee.jones@linaro.org,
thierry.reding@gmail.com, p.zabel@pengutronix.de,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, BMC-SW@aspeedtech.com
Subject: Re: [v13 2/2] pwm: Add Aspeed ast2600 PWM support
Date: Mon, 29 Nov 2021 21:51:54 +0100 [thread overview]
Message-ID: <20211129205154.jtm4ehvvfo52toth@pengutronix.de> (raw)
In-Reply-To: <20211129064329.27006-3-billy_tsai@aspeedtech.com>
[-- Attachment #1.1: Type: text/plain, Size: 1688 bytes --]
Hello Billy,
just two minor thing left to criticise:
On Mon, Nov 29, 2021 at 02:43:29PM +0800, Billy Tsai wrote:
> + if (clk_en && duty_pt) {
> + dividend = (u64)NSEC_PER_SEC * (div_l + 1) * duty_pt
> + << div_h;
> + state->duty_cycle = DIV_ROUND_UP_ULL(dividend, rate);
> + } else
> + state->duty_cycle = clk_en ? state->period : 0;
I wonder about checkpatch not criticising this construct. See
Documentation/process/coding-style.rst:
Do not unnecessarily use braces where a single statement will
do. [...] This does not apply if only one branch of a
conditional statement is a single statement; in the latter case
use braces in both branches
> [...]
> +static int aspeed_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
> + const struct pwm_state *state)
> +{
> + struct device *dev = chip->dev;
> + struct aspeed_pwm_data *priv = aspeed_pwm_chip_to_data(chip);
> + u32 hwpwm = pwm->hwpwm, duty_pt;
> + unsigned long rate;
> + u64 div_h, div_l, divisor, expect_period;
> + bool clk_en;
> +
> + expect_period = state->period;
> + dev_dbg(dev, "expect period: %lldns, duty_cycle: %lldns", expect_period,
> + state->duty_cycle);
> +
> + rate = clk_get_rate(priv->clk);
> + if (expect_period > div64_u64(ULLONG_MAX, (u64)rate))
> + expect_period = div64_u64(ULLONG_MAX, (u64)rate);
If you write that as
expect_period = min(div64_u64(ULLONG_MAX, (u64)rate), expect_period);
you make sure that the division is only calculated once.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-29 21:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 6:43 [v13 0/2] Support pwm driver for aspeed ast26xx Billy Tsai
2021-11-29 6:43 ` [v13 1/2] dt-bindings: Add bindings for aspeed pwm-tach Billy Tsai
2021-11-29 6:43 ` [v13 2/2] pwm: Add Aspeed ast2600 PWM support Billy Tsai
2021-11-29 20:51 ` Uwe Kleine-König [this message]
2021-11-30 9:52 ` Philipp Zabel
2021-12-01 3:30 ` Billy Tsai
2021-12-01 9:11 ` Philipp Zabel
2021-12-01 10:53 ` Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211129205154.jtm4ehvvfo52toth@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).