From: Philipp Zabel <p.zabel@pengutronix.de>
To: Billy Tsai <billy_tsai@aspeedtech.com>,
jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
joel@jms.id.au, andrew@aj.id.au, lee.jones@linaro.org,
thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org
Cc: BMC-SW@aspeedtech.com
Subject: Re: [v13 2/2] pwm: Add Aspeed ast2600 PWM support
Date: Tue, 30 Nov 2021 10:52:17 +0100 [thread overview]
Message-ID: <e28a5d5de9b940717e6444f019eab63ab1bb0b75.camel@pengutronix.de> (raw)
In-Reply-To: <20211129064329.27006-3-billy_tsai@aspeedtech.com>
On Mon, 2021-11-29 at 14:43 +0800, Billy Tsai wrote:
[...]
> + ret = clk_prepare_enable(priv->clk);
> + if (ret)
> + return dev_err_probe(dev, ret, "Couldn't enable clock\n");
> +
> + ret = reset_control_deassert(priv->reset);
> + if (ret) {
> + dev_err_probe(dev, ret, "Couldn't deassert reset control\n");
> + goto err_disable_clk;
> + }
Is there any reason to keep the clocks running and the controller out of
reset while the PWM outputs are disabled?
regards
Philipp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-30 10:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 6:43 [v13 0/2] Support pwm driver for aspeed ast26xx Billy Tsai
2021-11-29 6:43 ` [v13 1/2] dt-bindings: Add bindings for aspeed pwm-tach Billy Tsai
2021-11-29 6:43 ` [v13 2/2] pwm: Add Aspeed ast2600 PWM support Billy Tsai
2021-11-29 20:51 ` Uwe Kleine-König
2021-11-30 9:52 ` Philipp Zabel [this message]
2021-12-01 3:30 ` Billy Tsai
2021-12-01 9:11 ` Philipp Zabel
2021-12-01 10:53 ` Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e28a5d5de9b940717e6444f019eab63ab1bb0b75.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).