* [PATCH 0/3] Add STM32MP13 EXTI support
@ 2021-12-08 13:04 Alexandre Torgue
2021-12-08 13:04 ` [PATCH 1/3] dt-bindings: interrupt-controller: stm32-exti: document st, stm32mp13-exti Alexandre Torgue
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Alexandre Torgue @ 2021-12-08 13:04 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier, Rob Herring
Cc: linux-arm-kernel, linux-kernel, linux-stm32, devicetree,
alexandre.torgue
Enhance stm32-exti driver to support STM32MP13 SoC. This SoC uses the same
hardware version than STM32MP15. Only EXTI line mapping is changed and
following EXTI lines are supported: GPIO, RTC, I2C[1-5], UxART[1-8],
USBH_EHCI, USBH_OHCI, USB_OTG, LPTIM[1-5], ETH[1-2].
regards
Alex
Alexandre Torgue (3):
dt-bindings: interrupt-controller: stm32-exti: document
st,stm32mp13-exti
irqchip/stm32-exti: add STM32MP13 support
ARM: dts: stm32: Enable EXTI on stm32mp13
.../interrupt-controller/st,stm32-exti.yaml | 1 +
arch/arm/boot/dts/stm32mp131.dtsi | 7 +++
drivers/irqchip/irq-stm32-exti.c | 50 +++++++++++++++++++
3 files changed, 58 insertions(+)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/3] dt-bindings: interrupt-controller: stm32-exti: document st, stm32mp13-exti
2021-12-08 13:04 [PATCH 0/3] Add STM32MP13 EXTI support Alexandre Torgue
@ 2021-12-08 13:04 ` Alexandre Torgue
2021-12-08 13:04 ` [PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support Alexandre Torgue
2021-12-08 13:04 ` [PATCH 3/3] ARM: dts: stm32: Enable EXTI on stm32mp13 Alexandre Torgue
2 siblings, 0 replies; 8+ messages in thread
From: Alexandre Torgue @ 2021-12-08 13:04 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier, Rob Herring
Cc: linux-arm-kernel, linux-kernel, linux-stm32, devicetree,
alexandre.torgue
Support of STM32MP13 SoC implies to create a new compatible in order to
manage EXTI/GIC mapping changes.
Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
diff --git a/Documentation/devicetree/bindings/interrupt-controller/st,stm32-exti.yaml b/Documentation/devicetree/bindings/interrupt-controller/st,stm32-exti.yaml
index d19c881b4abc..e44daa09b137 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/st,stm32-exti.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/st,stm32-exti.yaml
@@ -20,6 +20,7 @@ properties:
- items:
- enum:
- st,stm32mp1-exti
+ - st,stm32mp13-exti
- const: syscon
"#interrupt-cells":
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support
2021-12-08 13:04 [PATCH 0/3] Add STM32MP13 EXTI support Alexandre Torgue
2021-12-08 13:04 ` [PATCH 1/3] dt-bindings: interrupt-controller: stm32-exti: document st, stm32mp13-exti Alexandre Torgue
@ 2021-12-08 13:04 ` Alexandre Torgue
2021-12-08 13:41 ` Marc Zyngier
2021-12-08 13:04 ` [PATCH 3/3] ARM: dts: stm32: Enable EXTI on stm32mp13 Alexandre Torgue
2 siblings, 1 reply; 8+ messages in thread
From: Alexandre Torgue @ 2021-12-08 13:04 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier, Rob Herring
Cc: linux-arm-kernel, linux-kernel, linux-stm32, devicetree,
alexandre.torgue
Enhance stm32-exti driver to support STM32MP13 SoC. This SoC uses the same
hardware version than STM32MP15. Only EXTI line mapping is changed and
following EXTI lines are supported: GPIO, RTC, I2C[1-5], UxART[1-8],
USBH_EHCI, USBH_OHCI, USB_OTG, LPTIM[1-5], ETH[1-2].
Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
index b7cb2da71888..9d18f47040eb 100644
--- a/drivers/irqchip/irq-stm32-exti.c
+++ b/drivers/irqchip/irq-stm32-exti.c
@@ -214,6 +214,48 @@ static const struct stm32_desc_irq stm32mp1_desc_irq[] = {
{ .exti = 73, .irq_parent = 129, .chip = &stm32_exti_h_chip },
};
+static const struct stm32_desc_irq stm32mp13_desc_irq[] = {
+ { .exti = 0, .irq_parent = 6, .chip = &stm32_exti_h_chip },
+ { .exti = 1, .irq_parent = 7, .chip = &stm32_exti_h_chip },
+ { .exti = 2, .irq_parent = 8, .chip = &stm32_exti_h_chip },
+ { .exti = 3, .irq_parent = 9, .chip = &stm32_exti_h_chip },
+ { .exti = 4, .irq_parent = 10, .chip = &stm32_exti_h_chip },
+ { .exti = 5, .irq_parent = 24, .chip = &stm32_exti_h_chip },
+ { .exti = 6, .irq_parent = 65, .chip = &stm32_exti_h_chip },
+ { .exti = 7, .irq_parent = 66, .chip = &stm32_exti_h_chip },
+ { .exti = 8, .irq_parent = 67, .chip = &stm32_exti_h_chip },
+ { .exti = 9, .irq_parent = 68, .chip = &stm32_exti_h_chip },
+ { .exti = 10, .irq_parent = 41, .chip = &stm32_exti_h_chip },
+ { .exti = 11, .irq_parent = 43, .chip = &stm32_exti_h_chip },
+ { .exti = 12, .irq_parent = 77, .chip = &stm32_exti_h_chip },
+ { .exti = 13, .irq_parent = 78, .chip = &stm32_exti_h_chip },
+ { .exti = 14, .irq_parent = 106, .chip = &stm32_exti_h_chip },
+ { .exti = 15, .irq_parent = 109, .chip = &stm32_exti_h_chip },
+ { .exti = 16, .irq_parent = 1, .chip = &stm32_exti_h_chip },
+ { .exti = 19, .irq_parent = 3, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 21, .irq_parent = 32, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 22, .irq_parent = 34, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 23, .irq_parent = 73, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 24, .irq_parent = 93, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 25, .irq_parent = 114, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 26, .irq_parent = 38, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 27, .irq_parent = 39, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 28, .irq_parent = 40, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 29, .irq_parent = 72, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 30, .irq_parent = 53, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 31, .irq_parent = 54, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 32, .irq_parent = 83, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 33, .irq_parent = 84, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 44, .irq_parent = 96, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 47, .irq_parent = 92, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 48, .irq_parent = 116, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 50, .irq_parent = 117, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 52, .irq_parent = 118, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 53, .irq_parent = 119, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 68, .irq_parent = 63, .chip = &stm32_exti_h_chip_direct },
+ { .exti = 70, .irq_parent = 98, .chip = &stm32_exti_h_chip_direct },
+};
+
static const struct stm32_exti_drv_data stm32mp1_drv_data = {
.exti_banks = stm32mp1_exti_banks,
.bank_nr = ARRAY_SIZE(stm32mp1_exti_banks),
@@ -221,6 +263,13 @@ static const struct stm32_exti_drv_data stm32mp1_drv_data = {
.irq_nr = ARRAY_SIZE(stm32mp1_desc_irq),
};
+static const struct stm32_exti_drv_data stm32mp13_drv_data = {
+ .exti_banks = stm32mp1_exti_banks,
+ .bank_nr = ARRAY_SIZE(stm32mp1_exti_banks),
+ .desc_irqs = stm32mp13_desc_irq,
+ .irq_nr = ARRAY_SIZE(stm32mp13_desc_irq),
+};
+
static const struct
stm32_desc_irq *stm32_exti_get_desc(const struct stm32_exti_drv_data *drv_data,
irq_hw_number_t hwirq)
@@ -922,6 +971,7 @@ static int stm32_exti_probe(struct platform_device *pdev)
/* platform driver only for MP1 */
static const struct of_device_id stm32_exti_ids[] = {
{ .compatible = "st,stm32mp1-exti", .data = &stm32mp1_drv_data},
+ { .compatible = "st,stm32mp13-exti", .data = &stm32mp13_drv_data},
{},
};
MODULE_DEVICE_TABLE(of, stm32_exti_ids);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] ARM: dts: stm32: Enable EXTI on stm32mp13
2021-12-08 13:04 [PATCH 0/3] Add STM32MP13 EXTI support Alexandre Torgue
2021-12-08 13:04 ` [PATCH 1/3] dt-bindings: interrupt-controller: stm32-exti: document st, stm32mp13-exti Alexandre Torgue
2021-12-08 13:04 ` [PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support Alexandre Torgue
@ 2021-12-08 13:04 ` Alexandre Torgue
2 siblings, 0 replies; 8+ messages in thread
From: Alexandre Torgue @ 2021-12-08 13:04 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier, Rob Herring
Cc: linux-arm-kernel, linux-kernel, linux-stm32, devicetree,
alexandre.torgue
As EXTI/GIC mapping has changed between STM32MP15 and STM32MP13, a
a new compatible is needed to choose mp13 mapping table in stm32-exti
driver.
Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
diff --git a/arch/arm/boot/dts/stm32mp131.dtsi b/arch/arm/boot/dts/stm32mp131.dtsi
index 86126dc0d898..c249dbe64354 100644
--- a/arch/arm/boot/dts/stm32mp131.dtsi
+++ b/arch/arm/boot/dts/stm32mp131.dtsi
@@ -115,6 +115,13 @@
status = "disabled";
};
+ exti: interrupt-controller@5000d000 {
+ compatible = "st,stm32mp13-exti", "syscon";
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ reg = <0x5000d000 0x400>;
+ };
+
syscfg: syscon@50020000 {
compatible = "st,stm32mp157-syscfg", "syscon";
reg = <0x50020000 0x400>;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support
2021-12-08 13:04 ` [PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support Alexandre Torgue
@ 2021-12-08 13:41 ` Marc Zyngier
2021-12-08 13:58 ` Alexandre TORGUE
0 siblings, 1 reply; 8+ messages in thread
From: Marc Zyngier @ 2021-12-08 13:41 UTC (permalink / raw)
To: Alexandre Torgue
Cc: Thomas Gleixner, Rob Herring, linux-arm-kernel, linux-kernel,
linux-stm32, devicetree
On Wed, 08 Dec 2021 13:04:55 +0000,
Alexandre Torgue <alexandre.torgue@foss.st.com> wrote:
>
> Enhance stm32-exti driver to support STM32MP13 SoC. This SoC uses the same
> hardware version than STM32MP15. Only EXTI line mapping is changed and
> following EXTI lines are supported: GPIO, RTC, I2C[1-5], UxART[1-8],
> USBH_EHCI, USBH_OHCI, USB_OTG, LPTIM[1-5], ETH[1-2].
>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>
> diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
> index b7cb2da71888..9d18f47040eb 100644
> --- a/drivers/irqchip/irq-stm32-exti.c
> +++ b/drivers/irqchip/irq-stm32-exti.c
> @@ -214,6 +214,48 @@ static const struct stm32_desc_irq stm32mp1_desc_irq[] = {
> { .exti = 73, .irq_parent = 129, .chip = &stm32_exti_h_chip },
> };
>
> +static const struct stm32_desc_irq stm32mp13_desc_irq[] = {
> + { .exti = 0, .irq_parent = 6, .chip = &stm32_exti_h_chip },
> + { .exti = 1, .irq_parent = 7, .chip = &stm32_exti_h_chip },
> + { .exti = 2, .irq_parent = 8, .chip = &stm32_exti_h_chip },
> + { .exti = 3, .irq_parent = 9, .chip = &stm32_exti_h_chip },
> + { .exti = 4, .irq_parent = 10, .chip = &stm32_exti_h_chip },
> + { .exti = 5, .irq_parent = 24, .chip = &stm32_exti_h_chip },
> + { .exti = 6, .irq_parent = 65, .chip = &stm32_exti_h_chip },
> + { .exti = 7, .irq_parent = 66, .chip = &stm32_exti_h_chip },
> + { .exti = 8, .irq_parent = 67, .chip = &stm32_exti_h_chip },
> + { .exti = 9, .irq_parent = 68, .chip = &stm32_exti_h_chip },
> + { .exti = 10, .irq_parent = 41, .chip = &stm32_exti_h_chip },
> + { .exti = 11, .irq_parent = 43, .chip = &stm32_exti_h_chip },
> + { .exti = 12, .irq_parent = 77, .chip = &stm32_exti_h_chip },
> + { .exti = 13, .irq_parent = 78, .chip = &stm32_exti_h_chip },
> + { .exti = 14, .irq_parent = 106, .chip = &stm32_exti_h_chip },
> + { .exti = 15, .irq_parent = 109, .chip = &stm32_exti_h_chip },
> + { .exti = 16, .irq_parent = 1, .chip = &stm32_exti_h_chip },
> + { .exti = 19, .irq_parent = 3, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 21, .irq_parent = 32, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 22, .irq_parent = 34, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 23, .irq_parent = 73, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 24, .irq_parent = 93, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 25, .irq_parent = 114, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 26, .irq_parent = 38, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 27, .irq_parent = 39, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 28, .irq_parent = 40, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 29, .irq_parent = 72, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 30, .irq_parent = 53, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 31, .irq_parent = 54, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 32, .irq_parent = 83, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 33, .irq_parent = 84, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 44, .irq_parent = 96, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 47, .irq_parent = 92, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 48, .irq_parent = 116, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 50, .irq_parent = 117, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 52, .irq_parent = 118, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 53, .irq_parent = 119, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 68, .irq_parent = 63, .chip = &stm32_exti_h_chip_direct },
> + { .exti = 70, .irq_parent = 98, .chip = &stm32_exti_h_chip_direct },
> +};
Why does the driver need to carry these tables? This sort of
information should really come from DT, instead of being hardcoded in
the driver and bloating it for no reason. This all has a funny taste
of the board files we used to have pre-DT.
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support
2021-12-08 13:41 ` Marc Zyngier
@ 2021-12-08 13:58 ` Alexandre TORGUE
2021-12-08 14:22 ` Marc Zyngier
0 siblings, 1 reply; 8+ messages in thread
From: Alexandre TORGUE @ 2021-12-08 13:58 UTC (permalink / raw)
To: Marc Zyngier
Cc: Thomas Gleixner, Rob Herring, linux-arm-kernel, linux-kernel,
linux-stm32, devicetree
Hi Marc
On 12/8/21 2:41 PM, Marc Zyngier wrote:
> On Wed, 08 Dec 2021 13:04:55 +0000,
> Alexandre Torgue <alexandre.torgue@foss.st.com> wrote:
>>
>> Enhance stm32-exti driver to support STM32MP13 SoC. This SoC uses the same
>> hardware version than STM32MP15. Only EXTI line mapping is changed and
>> following EXTI lines are supported: GPIO, RTC, I2C[1-5], UxART[1-8],
>> USBH_EHCI, USBH_OHCI, USB_OTG, LPTIM[1-5], ETH[1-2].
>>
>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>
>> diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
>> index b7cb2da71888..9d18f47040eb 100644
>> --- a/drivers/irqchip/irq-stm32-exti.c
>> +++ b/drivers/irqchip/irq-stm32-exti.c
>> @@ -214,6 +214,48 @@ static const struct stm32_desc_irq stm32mp1_desc_irq[] = {
>> { .exti = 73, .irq_parent = 129, .chip = &stm32_exti_h_chip },
>> };
>>
>> +static const struct stm32_desc_irq stm32mp13_desc_irq[] = {
>> + { .exti = 0, .irq_parent = 6, .chip = &stm32_exti_h_chip },
>> + { .exti = 1, .irq_parent = 7, .chip = &stm32_exti_h_chip },
>> + { .exti = 2, .irq_parent = 8, .chip = &stm32_exti_h_chip },
>> + { .exti = 3, .irq_parent = 9, .chip = &stm32_exti_h_chip },
>> + { .exti = 4, .irq_parent = 10, .chip = &stm32_exti_h_chip },
>> + { .exti = 5, .irq_parent = 24, .chip = &stm32_exti_h_chip },
>> + { .exti = 6, .irq_parent = 65, .chip = &stm32_exti_h_chip },
>> + { .exti = 7, .irq_parent = 66, .chip = &stm32_exti_h_chip },
>> + { .exti = 8, .irq_parent = 67, .chip = &stm32_exti_h_chip },
>> + { .exti = 9, .irq_parent = 68, .chip = &stm32_exti_h_chip },
>> + { .exti = 10, .irq_parent = 41, .chip = &stm32_exti_h_chip },
>> + { .exti = 11, .irq_parent = 43, .chip = &stm32_exti_h_chip },
>> + { .exti = 12, .irq_parent = 77, .chip = &stm32_exti_h_chip },
>> + { .exti = 13, .irq_parent = 78, .chip = &stm32_exti_h_chip },
>> + { .exti = 14, .irq_parent = 106, .chip = &stm32_exti_h_chip },
>> + { .exti = 15, .irq_parent = 109, .chip = &stm32_exti_h_chip },
>> + { .exti = 16, .irq_parent = 1, .chip = &stm32_exti_h_chip },
>> + { .exti = 19, .irq_parent = 3, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 21, .irq_parent = 32, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 22, .irq_parent = 34, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 23, .irq_parent = 73, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 24, .irq_parent = 93, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 25, .irq_parent = 114, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 26, .irq_parent = 38, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 27, .irq_parent = 39, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 28, .irq_parent = 40, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 29, .irq_parent = 72, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 30, .irq_parent = 53, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 31, .irq_parent = 54, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 32, .irq_parent = 83, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 33, .irq_parent = 84, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 44, .irq_parent = 96, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 47, .irq_parent = 92, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 48, .irq_parent = 116, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 50, .irq_parent = 117, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 52, .irq_parent = 118, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 53, .irq_parent = 119, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 68, .irq_parent = 63, .chip = &stm32_exti_h_chip_direct },
>> + { .exti = 70, .irq_parent = 98, .chip = &stm32_exti_h_chip_direct },
>> +};
>
> Why does the driver need to carry these tables? This sort of
> information should really come from DT, instead of being hardcoded in
> the driver and bloating it for no reason. This all has a funny taste
> of the board files we used to have pre-DT.
>
There are absolutely no reason to have it in driver. Honestly It has
been done in this way to have minimal changes adding this new SoC
support (and it's not smart, I agree).
I think it is better to abandon this series. I will create a new one
which moves mapping table for MP15 and adds MP13 support to.
thanks
Alex
> M.
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support
2021-12-08 13:58 ` Alexandre TORGUE
@ 2021-12-08 14:22 ` Marc Zyngier
2021-12-08 14:51 ` Alexandre TORGUE
0 siblings, 1 reply; 8+ messages in thread
From: Marc Zyngier @ 2021-12-08 14:22 UTC (permalink / raw)
To: Alexandre TORGUE
Cc: Thomas Gleixner, Rob Herring, linux-arm-kernel, linux-kernel,
linux-stm32, devicetree
Hi Alexandre,
On Wed, 08 Dec 2021 13:58:46 +0000,
Alexandre TORGUE <alexandre.torgue@foss.st.com> wrote:
>
> > Why does the driver need to carry these tables? This sort of
> > information should really come from DT, instead of being hardcoded in
> > the driver and bloating it for no reason. This all has a funny taste
> > of the board files we used to have pre-DT.
> >
>
> There are absolutely no reason to have it in driver. Honestly It has
> been done in this way to have minimal changes adding this new SoC
> support (and it's not smart, I agree).
>
> I think it is better to abandon this series. I will create a new one
> which moves mapping table for MP15 and adds MP13 support to.
I'm afraid you'll have to keep the in-kernel table for MP15, since the
driver needs to work with old DTs. For new SoCs (such as MP13), moving
the table into DT would be good.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support
2021-12-08 14:22 ` Marc Zyngier
@ 2021-12-08 14:51 ` Alexandre TORGUE
0 siblings, 0 replies; 8+ messages in thread
From: Alexandre TORGUE @ 2021-12-08 14:51 UTC (permalink / raw)
To: Marc Zyngier
Cc: Thomas Gleixner, Rob Herring, linux-arm-kernel, linux-kernel,
linux-stm32, devicetree
On 12/8/21 3:22 PM, Marc Zyngier wrote:
> Hi Alexandre,
>
> On Wed, 08 Dec 2021 13:58:46 +0000,
> Alexandre TORGUE <alexandre.torgue@foss.st.com> wrote:
>>
>>> Why does the driver need to carry these tables? This sort of
>>> information should really come from DT, instead of being hardcoded in
>>> the driver and bloating it for no reason. This all has a funny taste
>>> of the board files we used to have pre-DT.
>>>
>>
>> There are absolutely no reason to have it in driver. Honestly It has
>> been done in this way to have minimal changes adding this new SoC
>> support (and it's not smart, I agree).
>>
>> I think it is better to abandon this series. I will create a new one
>> which moves mapping table for MP15 and adds MP13 support to.
>
> I'm afraid you'll have to keep the in-kernel table for MP15, since the
> driver needs to work with old DTs. For new SoCs (such as MP13), moving
> the table into DT would be good.
I can try to have both for MP15:use new mechanism as MP13 and keep the
table inside the driver as a fallback if DT mapping is not provided (for
old DT).
Thanks
>
> Thanks,
>
> M.
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-12-08 14:54 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-08 13:04 [PATCH 0/3] Add STM32MP13 EXTI support Alexandre Torgue
2021-12-08 13:04 ` [PATCH 1/3] dt-bindings: interrupt-controller: stm32-exti: document st, stm32mp13-exti Alexandre Torgue
2021-12-08 13:04 ` [PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support Alexandre Torgue
2021-12-08 13:41 ` Marc Zyngier
2021-12-08 13:58 ` Alexandre TORGUE
2021-12-08 14:22 ` Marc Zyngier
2021-12-08 14:51 ` Alexandre TORGUE
2021-12-08 13:04 ` [PATCH 3/3] ARM: dts: stm32: Enable EXTI on stm32mp13 Alexandre Torgue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).