* [PATCH] firmware: arm_scmi: replace resevered identifiers in macros
@ 2021-12-22 17:25 trix
2021-12-22 18:15 ` Sudeep Holla
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2021-12-22 17:25 UTC (permalink / raw)
To: sudeep.holla, cristian.marussi; +Cc: linux-arm-kernel, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
Identifiers starting with __ are resevered. Replace __X with X.
The arguments to these macros are pointers. The macros only reads
values. There is no need to make copies of the pointers, use them
directly.
Fixes: a287126c31ab ("firmware: arm_scmi: Add configurable polling mode for transports")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/firmware/arm_scmi/driver.c | 31 ++++++++----------------------
1 file changed, 8 insertions(+), 23 deletions(-)
diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index b4bbfe89368df..d2fcfa9da931c 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -36,29 +36,14 @@
#define CREATE_TRACE_POINTS
#include <trace/events/scmi.h>
-#define IS_POLLING_REQUIRED(__c, __i) \
- ((__c)->no_completion_irq || (__i)->desc->force_polling) \
-
-#define IS_TRANSPORT_POLLING_CAPABLE(__i) \
-({ \
- bool __ret; \
- typeof(__i) i_ = __i; \
- \
- __ret = ((i_)->desc->ops->poll_done || \
- (i_)->desc->sync_cmds_completed_on_ret); \
- __ret; \
-})
-
-#define IS_POLLING_ENABLED(__c, __i) \
-({ \
- bool __ret; \
- typeof(__c) c_ = __c; \
- typeof(__i) i_ = __i; \
- \
- __ret = (IS_POLLING_REQUIRED(c_, i_) && \
- IS_TRANSPORT_POLLING_CAPABLE(i_)); \
- __ret; \
-})
+#define IS_POLLING_REQUIRED(c, i) \
+ ((c)->no_completion_irq || (i)->desc->force_polling)
+
+#define IS_TRANSPORT_POLLING_CAPABLE(i) \
+ ((i)->desc->ops->poll_done || (i)->desc->sync_cmds_completed_on_ret)
+
+#define IS_POLLING_ENABLED(c, i) \
+ (IS_POLLING_REQUIRED(c, i) && IS_TRANSPORT_POLLING_CAPABLE(i))
enum scmi_error_codes {
SCMI_SUCCESS = 0, /* Success */
--
2.26.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] firmware: arm_scmi: replace resevered identifiers in macros
2021-12-22 17:25 [PATCH] firmware: arm_scmi: replace resevered identifiers in macros trix
@ 2021-12-22 18:15 ` Sudeep Holla
0 siblings, 0 replies; 2+ messages in thread
From: Sudeep Holla @ 2021-12-22 18:15 UTC (permalink / raw)
To: trix; +Cc: cristian.marussi, linux-arm-kernel, Sudeep Holla, linux-kernel
On Wed, Dec 22, 2021 at 09:25:19AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Identifiers starting with __ are resevered. Replace __X with X.
>
> The arguments to these macros are pointers. The macros only reads
> values. There is no need to make copies of the pointers, use them
> directly.
>
Agreed and thanks for the patch.
However the original patch was modified and these macros were moved
to inline functions[0] after the initial build warnings from the
build bot[1]. Sorry my reply to the bot seems to have got lost and didn't
make it to the list.
--
Regards,
Sudeep
[0] https://git.kernel.org/sudeep.holla/c/a690b7e6e7
[1] https://lore.kernel.org/lkml/202112211457.TlWRYcoq-lkp@intel.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-22 18:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-22 17:25 [PATCH] firmware: arm_scmi: replace resevered identifiers in macros trix
2021-12-22 18:15 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).