linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clocksource/drivers/imx-tpm: exclude sched clock for ARM64
@ 2022-01-05 12:43 Peng Fan (OSS)
  2022-02-16 12:29 ` Peng Fan
  0 siblings, 1 reply; 2+ messages in thread
From: Peng Fan (OSS) @ 2022-01-05 12:43 UTC (permalink / raw)
  To: daniel.lezcano, tglx
  Cc: shawnguo, s.hauer, kernel, festevam, linux-imx, linux-kernel,
	linux-arm-kernel, Peng Fan

From: Peng Fan <peng.fan@nxp.com>

For ARM64 platform such as i.MX8ULP which has ARMv8 generic timer as sched
clock, which is much faster compared with tpm sched clock. Reading the
tpm count register in i.MX8ULP requires about 290ns, this is slow and
introduce scheduler latency. So exclude tpm sched clock for ARM64
platform.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/clocksource/timer-imx-tpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-imx-tpm.c b/drivers/clocksource/timer-imx-tpm.c
index 2cdc077a39f5..2bd530b9adc4 100644
--- a/drivers/clocksource/timer-imx-tpm.c
+++ b/drivers/clocksource/timer-imx-tpm.c
@@ -150,10 +150,10 @@ static int __init tpm_clocksource_init(void)
 	tpm_delay_timer.read_current_timer = &tpm_read_current_timer;
 	tpm_delay_timer.freq = timer_of_rate(&to_tpm) >> 3;
 	register_current_timer_delay(&tpm_delay_timer);
-#endif
 
 	sched_clock_register(tpm_read_sched_clock, counter_width,
 			     timer_of_rate(&to_tpm) >> 3);
+#endif
 
 	return clocksource_mmio_init(timer_base + TPM_CNT,
 				     "imx-tpm",
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH] clocksource/drivers/imx-tpm: exclude sched clock for ARM64
  2022-01-05 12:43 [PATCH] clocksource/drivers/imx-tpm: exclude sched clock for ARM64 Peng Fan (OSS)
@ 2022-02-16 12:29 ` Peng Fan
  0 siblings, 0 replies; 2+ messages in thread
From: Peng Fan @ 2022-02-16 12:29 UTC (permalink / raw)
  To: Peng Fan (OSS), daniel.lezcano, tglx
  Cc: shawnguo, s.hauer, kernel, festevam, dl-linux-imx, linux-kernel,
	linux-arm-kernel

> Subject: [PATCH] clocksource/drivers/imx-tpm: exclude sched clock for
> ARM64

Gentle ping..

Thanks,
Peng.

> 
> From: Peng Fan <peng.fan@nxp.com>
> 
> For ARM64 platform such as i.MX8ULP which has ARMv8 generic timer as
> sched clock, which is much faster compared with tpm sched clock. Reading
> the tpm count register in i.MX8ULP requires about 290ns, this is slow and
> introduce scheduler latency. So exclude tpm sched clock for ARM64 platform.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/clocksource/timer-imx-tpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/timer-imx-tpm.c
> b/drivers/clocksource/timer-imx-tpm.c
> index 2cdc077a39f5..2bd530b9adc4 100644
> --- a/drivers/clocksource/timer-imx-tpm.c
> +++ b/drivers/clocksource/timer-imx-tpm.c
> @@ -150,10 +150,10 @@ static int __init tpm_clocksource_init(void)
>  	tpm_delay_timer.read_current_timer = &tpm_read_current_timer;
>  	tpm_delay_timer.freq = timer_of_rate(&to_tpm) >> 3;
>  	register_current_timer_delay(&tpm_delay_timer);
> -#endif
> 
>  	sched_clock_register(tpm_read_sched_clock, counter_width,
>  			     timer_of_rate(&to_tpm) >> 3);
> +#endif
> 
>  	return clocksource_mmio_init(timer_base + TPM_CNT,
>  				     "imx-tpm",
> --
> 2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-16 12:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-05 12:43 [PATCH] clocksource/drivers/imx-tpm: exclude sched clock for ARM64 Peng Fan (OSS)
2022-02-16 12:29 ` Peng Fan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).