* [v2 0/2] add i2c support for mt8186
@ 2022-01-25 11:04 Kewei Xu
2022-01-25 11:04 ` [v2 1/2] dt-bindings: i2c: update bindings for MT8186 SoC Kewei Xu
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Kewei Xu @ 2022-01-25 11:04 UTC (permalink / raw)
To: wsa
Cc: matthias.bgg, robh+dt, linux-i2c, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, srv_heupstream, leilk.liu,
qii.wang, liguo.zhang, caiyu.chen, housong.zhang, yuhan.wei,
kewei.xu, ryan-jh.yu
V1:
Add i2c compatible for MT8186. Compare to MT8192 i2c controller,
MT8186 doesn't need handshake signal with apdma.
Kewei Xu (2):
dt-bindings: i2c: update bindings for MT8186 SoC
i2c: mediatek: Add i2c compatible for Mediatek MT8186
.../devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
2 files changed, 15 insertions(+)
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [v2 1/2] dt-bindings: i2c: update bindings for MT8186 SoC
2022-01-25 11:04 [v2 0/2] add i2c support for mt8186 Kewei Xu
@ 2022-01-25 11:04 ` Kewei Xu
2022-01-25 11:26 ` Qii Wang
2022-01-28 21:46 ` Wolfram Sang
2022-01-25 11:04 ` [v2 2/2] i2c: mediatek: Add i2c compatible for Mediatek MT8186 Kewei Xu
2022-01-28 21:46 ` [v2 0/2] add i2c support for mt8186 Wolfram Sang
2 siblings, 2 replies; 9+ messages in thread
From: Kewei Xu @ 2022-01-25 11:04 UTC (permalink / raw)
To: wsa
Cc: matthias.bgg, robh+dt, linux-i2c, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, srv_heupstream, leilk.liu,
qii.wang, liguo.zhang, caiyu.chen, housong.zhang, yuhan.wei,
kewei.xu, ryan-jh.yu
Add a DT binding documentation for the MT8186 soc.
Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
---
Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
index 5ea216ae7084..88f74a3c81ec 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
@@ -14,6 +14,7 @@ Required properties:
"mediatek,mt7629-i2c", "mediatek,mt2712-i2c": for MediaTek MT7629
"mediatek,mt8173-i2c": for MediaTek MT8173
"mediatek,mt8183-i2c": for MediaTek MT8183
+ "mediatek,mt8186-i2c": for MediaTek MT8186
"mediatek,mt8192-i2c": for MediaTek MT8192
"mediatek,mt8195-i2c", "mediatek,mt8192-i2c": for MediaTek MT8195
"mediatek,mt8516-i2c", "mediatek,mt2712-i2c": for MediaTek MT8516
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [v2 2/2] i2c: mediatek: Add i2c compatible for Mediatek MT8186
2022-01-25 11:04 [v2 0/2] add i2c support for mt8186 Kewei Xu
2022-01-25 11:04 ` [v2 1/2] dt-bindings: i2c: update bindings for MT8186 SoC Kewei Xu
@ 2022-01-25 11:04 ` Kewei Xu
2022-01-25 11:27 ` Qii Wang
2022-01-28 21:46 ` Wolfram Sang
2022-01-28 21:46 ` [v2 0/2] add i2c support for mt8186 Wolfram Sang
2 siblings, 2 replies; 9+ messages in thread
From: Kewei Xu @ 2022-01-25 11:04 UTC (permalink / raw)
To: wsa
Cc: matthias.bgg, robh+dt, linux-i2c, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, srv_heupstream, leilk.liu,
qii.wang, liguo.zhang, caiyu.chen, housong.zhang, yuhan.wei,
kewei.xu, ryan-jh.yu
Add i2c compatible for MT8186. Compare to MT8192 i2c controller,
MT8186 doesn't need handshake signal witch apdma.
Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 9ea427f53083..aa4d21838e14 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -397,6 +397,19 @@ static const struct mtk_i2c_compatible mt8183_compat = {
.max_dma_support = 33,
};
+static const struct mtk_i2c_compatible mt8186_compat = {
+ .regs = mt_i2c_regs_v2,
+ .pmic_i2c = 0,
+ .dcm = 0,
+ .auto_restart = 1,
+ .aux_len_reg = 1,
+ .timing_adjust = 1,
+ .dma_sync = 0,
+ .ltiming_adjust = 1,
+ .apdma_sync = 0,
+ .max_dma_support = 36,
+};
+
static const struct mtk_i2c_compatible mt8192_compat = {
.quirks = &mt8183_i2c_quirks,
.regs = mt_i2c_regs_v2,
@@ -418,6 +431,7 @@ static const struct of_device_id mtk_i2c_of_match[] = {
{ .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
{ .compatible = "mediatek,mt8183-i2c", .data = &mt8183_compat },
+ { .compatible = "mediatek,mt8186-i2c", .data = &mt8186_compat },
{ .compatible = "mediatek,mt8192-i2c", .data = &mt8192_compat },
{}
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [v2 1/2] dt-bindings: i2c: update bindings for MT8186 SoC
2022-01-25 11:04 ` [v2 1/2] dt-bindings: i2c: update bindings for MT8186 SoC Kewei Xu
@ 2022-01-25 11:26 ` Qii Wang
2022-01-28 21:46 ` Wolfram Sang
1 sibling, 0 replies; 9+ messages in thread
From: Qii Wang @ 2022-01-25 11:26 UTC (permalink / raw)
To: Kewei Xu, wsa
Cc: matthias.bgg, robh+dt, linux-i2c, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, srv_heupstream, leilk.liu,
liguo.zhang, caiyu.chen, housong.zhang, yuhan.wei, ryan-jh.yu
On Tue, 2022-01-25 at 19:04 +0800, Kewei Xu wrote:
> Add a DT binding documentation for the MT8186 soc.
>
> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
Reviewed-by: Qii Wang <qii.wang@mediatek.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> index 5ea216ae7084..88f74a3c81ec 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> @@ -14,6 +14,7 @@ Required properties:
> "mediatek,mt7629-i2c", "mediatek,mt2712-i2c": for MediaTek
> MT7629
> "mediatek,mt8173-i2c": for MediaTek MT8173
> "mediatek,mt8183-i2c": for MediaTek MT8183
> + "mediatek,mt8186-i2c": for MediaTek MT8186
> "mediatek,mt8192-i2c": for MediaTek MT8192
> "mediatek,mt8195-i2c", "mediatek,mt8192-i2c": for MediaTek
> MT8195
> "mediatek,mt8516-i2c", "mediatek,mt2712-i2c": for MediaTek
> MT8516
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [v2 2/2] i2c: mediatek: Add i2c compatible for Mediatek MT8186
2022-01-25 11:04 ` [v2 2/2] i2c: mediatek: Add i2c compatible for Mediatek MT8186 Kewei Xu
@ 2022-01-25 11:27 ` Qii Wang
2022-01-28 21:46 ` Wolfram Sang
1 sibling, 0 replies; 9+ messages in thread
From: Qii Wang @ 2022-01-25 11:27 UTC (permalink / raw)
To: Kewei Xu, wsa
Cc: matthias.bgg, robh+dt, linux-i2c, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, srv_heupstream, leilk.liu,
liguo.zhang, caiyu.chen, housong.zhang, yuhan.wei, ryan-jh.yu
On Tue, 2022-01-25 at 19:04 +0800, Kewei Xu wrote:
> Add i2c compatible for MT8186. Compare to MT8192 i2c controller,
> MT8186 doesn't need handshake signal witch apdma.
>
> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
Reviewed-by: Qii Wang <qii.wang@mediatek.com>
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c
> b/drivers/i2c/busses/i2c-mt65xx.c
> index 9ea427f53083..aa4d21838e14 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -397,6 +397,19 @@ static const struct mtk_i2c_compatible
> mt8183_compat = {
> .max_dma_support = 33,
> };
>
> +static const struct mtk_i2c_compatible mt8186_compat = {
> + .regs = mt_i2c_regs_v2,
> + .pmic_i2c = 0,
> + .dcm = 0,
> + .auto_restart = 1,
> + .aux_len_reg = 1,
> + .timing_adjust = 1,
> + .dma_sync = 0,
> + .ltiming_adjust = 1,
> + .apdma_sync = 0,
> + .max_dma_support = 36,
> +};
> +
> static const struct mtk_i2c_compatible mt8192_compat = {
> .quirks = &mt8183_i2c_quirks,
> .regs = mt_i2c_regs_v2,
> @@ -418,6 +431,7 @@ static const struct of_device_id
> mtk_i2c_of_match[] = {
> { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat
> },
> { .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat
> },
> { .compatible = "mediatek,mt8183-i2c", .data = &mt8183_compat
> },
> + { .compatible = "mediatek,mt8186-i2c", .data = &mt8186_compat
> },
> { .compatible = "mediatek,mt8192-i2c", .data = &mt8192_compat
> },
> {}
> };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [v2 0/2] add i2c support for mt8186
2022-01-25 11:04 [v2 0/2] add i2c support for mt8186 Kewei Xu
2022-01-25 11:04 ` [v2 1/2] dt-bindings: i2c: update bindings for MT8186 SoC Kewei Xu
2022-01-25 11:04 ` [v2 2/2] i2c: mediatek: Add i2c compatible for Mediatek MT8186 Kewei Xu
@ 2022-01-28 21:46 ` Wolfram Sang
2 siblings, 0 replies; 9+ messages in thread
From: Wolfram Sang @ 2022-01-28 21:46 UTC (permalink / raw)
To: Kewei Xu
Cc: matthias.bgg, robh+dt, linux-i2c, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, srv_heupstream, leilk.liu,
qii.wang, liguo.zhang, caiyu.chen, housong.zhang, yuhan.wei,
ryan-jh.yu
[-- Attachment #1.1: Type: text/plain, Size: 274 bytes --]
On Tue, Jan 25, 2022 at 07:04:11PM +0800, Kewei Xu wrote:
> V1:
> Add i2c compatible for MT8186. Compare to MT8192 i2c controller,
> MT8186 doesn't need handshake signal with apdma.
A description of what has changed in v2 would have been helpful. Please
add it next time.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [v2 1/2] dt-bindings: i2c: update bindings for MT8186 SoC
2022-01-25 11:04 ` [v2 1/2] dt-bindings: i2c: update bindings for MT8186 SoC Kewei Xu
2022-01-25 11:26 ` Qii Wang
@ 2022-01-28 21:46 ` Wolfram Sang
2022-02-07 2:53 ` Kewei Xu
1 sibling, 1 reply; 9+ messages in thread
From: Wolfram Sang @ 2022-01-28 21:46 UTC (permalink / raw)
To: Kewei Xu
Cc: matthias.bgg, robh+dt, linux-i2c, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, srv_heupstream, leilk.liu,
qii.wang, liguo.zhang, caiyu.chen, housong.zhang, yuhan.wei,
ryan-jh.yu
[-- Attachment #1.1: Type: text/plain, Size: 274 bytes --]
On Tue, Jan 25, 2022 at 07:04:12PM +0800, Kewei Xu wrote:
> Add a DT binding documentation for the MT8186 soc.
>
> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
Applied to for-next, thanks! But you forgot to add the ack from Rob
which he gave when you sent v1.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [v2 2/2] i2c: mediatek: Add i2c compatible for Mediatek MT8186
2022-01-25 11:04 ` [v2 2/2] i2c: mediatek: Add i2c compatible for Mediatek MT8186 Kewei Xu
2022-01-25 11:27 ` Qii Wang
@ 2022-01-28 21:46 ` Wolfram Sang
1 sibling, 0 replies; 9+ messages in thread
From: Wolfram Sang @ 2022-01-28 21:46 UTC (permalink / raw)
To: Kewei Xu
Cc: matthias.bgg, robh+dt, linux-i2c, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, srv_heupstream, leilk.liu,
qii.wang, liguo.zhang, caiyu.chen, housong.zhang, yuhan.wei,
ryan-jh.yu
[-- Attachment #1.1: Type: text/plain, Size: 269 bytes --]
On Tue, Jan 25, 2022 at 07:04:13PM +0800, Kewei Xu wrote:
> Add i2c compatible for MT8186. Compare to MT8192 i2c controller,
> MT8186 doesn't need handshake signal witch apdma.
>
> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [v2 1/2] dt-bindings: i2c: update bindings for MT8186 SoC
2022-01-28 21:46 ` Wolfram Sang
@ 2022-02-07 2:53 ` Kewei Xu
0 siblings, 0 replies; 9+ messages in thread
From: Kewei Xu @ 2022-02-07 2:53 UTC (permalink / raw)
To: Wolfram Sang
Cc: matthias.bgg, robh+dt, linux-i2c, devicetree, linux-arm-kernel,
linux-kernel, linux-mediatek, srv_heupstream, leilk.liu,
qii.wang, liguo.zhang, caiyu.chen, housong.zhang, yuhan.wei,
ryan-jh.yu
On Fri, 2022-01-28 at 22:46 +0100, Wolfram Sang wrote:
> On Tue, Jan 25, 2022 at 07:04:12PM +0800, Kewei Xu wrote:
> > Add a DT binding documentation for the MT8186 soc.
> >
> > Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
>
> Applied to for-next, thanks! But you forgot to add the ack from Rob
> which he gave when you sent v1.
>
Hi,
I'm sorry for my mistake and thank you very much for your reminder. I
will pay attention to this problem next time.
Thanks
Kewei.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-02-07 3:03 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25 11:04 [v2 0/2] add i2c support for mt8186 Kewei Xu
2022-01-25 11:04 ` [v2 1/2] dt-bindings: i2c: update bindings for MT8186 SoC Kewei Xu
2022-01-25 11:26 ` Qii Wang
2022-01-28 21:46 ` Wolfram Sang
2022-02-07 2:53 ` Kewei Xu
2022-01-25 11:04 ` [v2 2/2] i2c: mediatek: Add i2c compatible for Mediatek MT8186 Kewei Xu
2022-01-25 11:27 ` Qii Wang
2022-01-28 21:46 ` Wolfram Sang
2022-01-28 21:46 ` [v2 0/2] add i2c support for mt8186 Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).