* [PATCH 0/2] Make DTs compliant with bindings
@ 2022-03-09 18:24 Kuldeep Singh
2022-03-09 18:24 ` [PATCH 1/2] arm64: dts: lg131x: Update spi clock properties Kuldeep Singh
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Kuldeep Singh @ 2022-03-09 18:24 UTC (permalink / raw)
To: Rob Herring, devicetree, linux-kernel, linux-arm-kernel
Cc: Chanho Min, Tom Lendacky
These patches are an attempt to fix DTs which are not in compliant with
pl022 binding.
LG1312, LG1313 and amd seattle platforms require fix in clock
properties.
https://lore.kernel.org/linux-spi/20220309171847.5345-1-singh.kuldeep87k@gmail.com/T/#u
Based on git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git,
master.
Rob, could you please help in picking these patches as git tree is not
specified in MAINTAINERS.
Kuldeep Singh (2):
arm64: dts: lg131x: Update spi clock properties
arm64: dts: seattle: Update spi node properties
arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 8 ++++----
arch/arm64/boot/dts/lg/lg1312.dtsi | 8 ++++----
arch/arm64/boot/dts/lg/lg1313.dtsi | 8 ++++----
3 files changed, 12 insertions(+), 12 deletions(-)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] arm64: dts: lg131x: Update spi clock properties
2022-03-09 18:24 [PATCH 0/2] Make DTs compliant with bindings Kuldeep Singh
@ 2022-03-09 18:24 ` Kuldeep Singh
2022-03-09 18:24 ` [PATCH 2/2] arm64: dts: seattle: Update spi node properties Kuldeep Singh
2022-03-10 23:18 ` [PATCH 0/2] Make DTs compliant with bindings Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Kuldeep Singh @ 2022-03-09 18:24 UTC (permalink / raw)
To: Rob Herring, devicetree, linux-kernel, linux-arm-kernel
Cc: Chanho Min, Tom Lendacky
PL022 binding require two clocks to be defined but LG1312 and LG1213
platforms don't comply with bindings and define only one clock.
Update spi clocks and clocks-names property by adding appropriate clock
reference to make it compliant with bindings.
CC: Chanho Min <chanho.min@lge.com>
Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
---
arch/arm64/boot/dts/lg/lg1312.dtsi | 8 ++++----
arch/arm64/boot/dts/lg/lg1313.dtsi | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/lg/lg1312.dtsi b/arch/arm64/boot/dts/lg/lg1312.dtsi
index 081fe7a9f605..fa44e0b67400 100644
--- a/arch/arm64/boot/dts/lg/lg1312.dtsi
+++ b/arch/arm64/boot/dts/lg/lg1312.dtsi
@@ -172,15 +172,15 @@ spi0: spi@fe800000 {
compatible = "arm,pl022", "arm,primecell";
reg = <0x0 0xfe800000 0x1000>;
interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clk_bus>;
- clock-names = "apb_pclk";
+ clocks = <&clk_bus>, <&clk_bus>;
+ clock-names = "sspclk", "apb_pclk";
};
spi1: spi@fe900000 {
compatible = "arm,pl022", "arm,primecell";
reg = <0x0 0xfe900000 0x1000>;
interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clk_bus>;
- clock-names = "apb_pclk";
+ clocks = <&clk_bus>, <&clk_bus>;
+ clock-names = "sspclk", "apb_pclk";
};
dmac0: dma@c1128000 {
compatible = "arm,pl330", "arm,primecell";
diff --git a/arch/arm64/boot/dts/lg/lg1313.dtsi b/arch/arm64/boot/dts/lg/lg1313.dtsi
index 604bb6975337..b61b5e20189c 100644
--- a/arch/arm64/boot/dts/lg/lg1313.dtsi
+++ b/arch/arm64/boot/dts/lg/lg1313.dtsi
@@ -172,15 +172,15 @@ spi0: spi@fe800000 {
compatible = "arm,pl022", "arm,primecell";
reg = <0x0 0xfe800000 0x1000>;
interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clk_bus>;
- clock-names = "apb_pclk";
+ clocks = <&clk_bus>, <&clk_bus>;
+ clock-names = "sspclk", "apb_pclk";
};
spi1: spi@fe900000 {
compatible = "arm,pl022", "arm,primecell";
reg = <0x0 0xfe900000 0x1000>;
interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clk_bus>;
- clock-names = "apb_pclk";
+ clocks = <&clk_bus>, <&clk_bus>;
+ clock-names = "sspclk", "apb_pclk";
};
dmac0: dma@c1128000 {
compatible = "arm,pl330", "arm,primecell";
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] arm64: dts: seattle: Update spi node properties
2022-03-09 18:24 [PATCH 0/2] Make DTs compliant with bindings Kuldeep Singh
2022-03-09 18:24 ` [PATCH 1/2] arm64: dts: lg131x: Update spi clock properties Kuldeep Singh
@ 2022-03-09 18:24 ` Kuldeep Singh
2022-03-10 23:18 ` [PATCH 0/2] Make DTs compliant with bindings Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Kuldeep Singh @ 2022-03-09 18:24 UTC (permalink / raw)
To: Rob Herring, devicetree, linux-kernel, linux-arm-kernel
Cc: Chanho Min, Tom Lendacky
PL022 binding require two clocks to be defined but AMD seattle platform
does't comply with binding and define only one clock.
Update spi clocks and clocks-names property by adding appropriate clock
reference to make it compliant with bindings.
CC: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
---
arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi
index b664e7af74eb..2aa21d98d560 100644
--- a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi
+++ b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi
@@ -113,8 +113,8 @@ spi0: spi@e1020000 {
reg = <0 0xe1020000 0 0x1000>;
spi-controller;
interrupts = <0 330 4>;
- clocks = <&uartspiclk_100mhz>;
- clock-names = "apb_pclk";
+ clocks = <&uartspiclk_100mhz>, <&uartspiclk_100mhz>;
+ clock-names = "sspclk", "apb_pclk";
};
spi1: spi@e1030000 {
@@ -123,8 +123,8 @@ spi1: spi@e1030000 {
reg = <0 0xe1030000 0 0x1000>;
spi-controller;
interrupts = <0 329 4>;
- clocks = <&uartspiclk_100mhz>;
- clock-names = "apb_pclk";
+ clocks = <&uartspiclk_100mhz>, <&uartspiclk_100mhz>;
+ clock-names = "sspclk", "apb_pclk";
num-cs = <1>;
#address-cells = <1>;
#size-cells = <0>;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] Make DTs compliant with bindings
2022-03-09 18:24 [PATCH 0/2] Make DTs compliant with bindings Kuldeep Singh
2022-03-09 18:24 ` [PATCH 1/2] arm64: dts: lg131x: Update spi clock properties Kuldeep Singh
2022-03-09 18:24 ` [PATCH 2/2] arm64: dts: seattle: Update spi node properties Kuldeep Singh
@ 2022-03-10 23:18 ` Rob Herring
2022-03-11 2:59 ` Kuldeep Singh
2 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2022-03-10 23:18 UTC (permalink / raw)
To: Kuldeep Singh
Cc: devicetree, linux-kernel, linux-arm-kernel, Chanho Min, Tom Lendacky
On Wed, Mar 9, 2022 at 12:24 PM Kuldeep Singh
<singh.kuldeep87k@gmail.com> wrote:
>
> These patches are an attempt to fix DTs which are not in compliant with
> pl022 binding.
> LG1312, LG1313 and amd seattle platforms require fix in clock
> properties.
> https://lore.kernel.org/linux-spi/20220309171847.5345-1-singh.kuldeep87k@gmail.com/T/#u
>
> Based on git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git,
> master.
> Rob, could you please help in picking these patches as git tree is not
> specified in MAINTAINERS.
I don't take dts files. Resend to soc@kernel.org asking them to apply.
>
> Kuldeep Singh (2):
> arm64: dts: lg131x: Update spi clock properties
> arm64: dts: seattle: Update spi node properties
Acked-by: Rob Herring <robh@kernel.org>
>
> arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 8 ++++----
> arch/arm64/boot/dts/lg/lg1312.dtsi | 8 ++++----
> arch/arm64/boot/dts/lg/lg1313.dtsi | 8 ++++----
> 3 files changed, 12 insertions(+), 12 deletions(-)
>
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] Make DTs compliant with bindings
2022-03-10 23:18 ` [PATCH 0/2] Make DTs compliant with bindings Rob Herring
@ 2022-03-11 2:59 ` Kuldeep Singh
0 siblings, 0 replies; 5+ messages in thread
From: Kuldeep Singh @ 2022-03-11 2:59 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-kernel, linux-arm-kernel, Chanho Min, Tom Lendacky
On Thu, Mar 10, 2022 at 05:18:51PM -0600, Rob Herring wrote:
> On Wed, Mar 9, 2022 at 12:24 PM Kuldeep Singh
> <singh.kuldeep87k@gmail.com> wrote:
> >
> > These patches are an attempt to fix DTs which are not in compliant with
> > pl022 binding.
> > LG1312, LG1313 and amd seattle platforms require fix in clock
> > properties.
> > https://lore.kernel.org/linux-spi/20220309171847.5345-1-singh.kuldeep87k@gmail.com/T/#u
> >
> > Based on git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git,
> > master.
> > Rob, could you please help in picking these patches as git tree is not
> > specified in MAINTAINERS.
>
> I don't take dts files. Resend to soc@kernel.org asking them to apply.
Thanks for mentioning. I will resend this series to appropriate list.
>
> >
> > Kuldeep Singh (2):
> > arm64: dts: lg131x: Update spi clock properties
> > arm64: dts: seattle: Update spi node properties
>
> Acked-by: Rob Herring <robh@kernel.org>
Thanks for reviewing it.
>
> >
> > arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 8 ++++----
> > arch/arm64/boot/dts/lg/lg1312.dtsi | 8 ++++----
> > arch/arm64/boot/dts/lg/lg1313.dtsi | 8 ++++----
> > 3 files changed, 12 insertions(+), 12 deletions(-)
> >
> > --
> > 2.25.1
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-03-11 3:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-09 18:24 [PATCH 0/2] Make DTs compliant with bindings Kuldeep Singh
2022-03-09 18:24 ` [PATCH 1/2] arm64: dts: lg131x: Update spi clock properties Kuldeep Singh
2022-03-09 18:24 ` [PATCH 2/2] arm64: dts: seattle: Update spi node properties Kuldeep Singh
2022-03-10 23:18 ` [PATCH 0/2] Make DTs compliant with bindings Rob Herring
2022-03-11 2:59 ` Kuldeep Singh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).