* drm/mediatek: fixup ovl vblank callback data null pointer issue
@ 2022-03-14 8:08 Yongqiang Niu
2022-03-14 8:08 ` [PATCH v1, 1/1] " Yongqiang Niu
0 siblings, 1 reply; 3+ messages in thread
From: Yongqiang Niu @ 2022-03-14 8:08 UTC (permalink / raw)
To: Chun-Kuang Hu
Cc: Rob Herring, Matthias Brugger, Philipp Zabel, David Airlie,
Daniel Vetter, Jassi Brar, Yongqiang Niu, Fabien Parent,
Dennis YC Hsieh, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
Hsin-Yi Wang
base linux v5.17-rc1
Yongqiang Niu (1):
drm/mediatek: fixup ovl vblank callback data null pointer issue
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 1 -
1 file changed, 1 deletion(-)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v1, 1/1] drm/mediatek: fixup ovl vblank callback data null pointer issue
2022-03-14 8:08 drm/mediatek: fixup ovl vblank callback data null pointer issue Yongqiang Niu
@ 2022-03-14 8:08 ` Yongqiang Niu
2022-03-17 12:46 ` Rex-BC Chen
0 siblings, 1 reply; 3+ messages in thread
From: Yongqiang Niu @ 2022-03-14 8:08 UTC (permalink / raw)
To: Chun-Kuang Hu
Cc: Rob Herring, Matthias Brugger, Philipp Zabel, David Airlie,
Daniel Vetter, Jassi Brar, Yongqiang Niu, Fabien Parent,
Dennis YC Hsieh, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
Hsin-Yi Wang
ovl vblank_cb_data will be null pointer when disable ovl
vblank
Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
index 2146299e5f52..f3a450c0ef2d 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
@@ -113,7 +113,6 @@ void mtk_ovl_disable_vblank(struct device *dev)
struct mtk_disp_ovl *ovl = dev_get_drvdata(dev);
ovl->vblank_cb = NULL;
- ovl->vblank_cb_data = NULL;
writel_relaxed(0x0, ovl->regs + DISP_REG_OVL_INTEN);
}
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1, 1/1] drm/mediatek: fixup ovl vblank callback data null pointer issue
2022-03-14 8:08 ` [PATCH v1, 1/1] " Yongqiang Niu
@ 2022-03-17 12:46 ` Rex-BC Chen
0 siblings, 0 replies; 3+ messages in thread
From: Rex-BC Chen @ 2022-03-17 12:46 UTC (permalink / raw)
To: Yongqiang Niu, Chun-Kuang Hu
Cc: Rob Herring, Matthias Brugger, Philipp Zabel, David Airlie,
Daniel Vetter, Jassi Brar, Fabien Parent, Dennis YC Hsieh,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
dri-devel, Project_Global_Chrome_Upstream_Group, Hsin-Yi Wang
On Mon, 2022-03-14 at 16:08 +0800, Yongqiang Niu wrote:
> ovl vblank_cb_data will be null pointer when disable ovl
> vblank
>
Hello Yongqiang,
What issue do you encounter?
Is it a timing issue?
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> index 2146299e5f52..f3a450c0ef2d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> @@ -113,7 +113,6 @@ void mtk_ovl_disable_vblank(struct device *dev)
> struct mtk_disp_ovl *ovl = dev_get_drvdata(dev);
>
> ovl->vblank_cb = NULL;
> - ovl->vblank_cb_data = NULL;
IMO, this may be not a good solution.
If this is a timing issue and you don't need to handle irq after
disable vblank.
I think you should handle ovl->vblank_cb_data == NULL in
mtk_disp_ovl_irq_handler?
If I am wrong, please correct me.
Thanks.
BRs,
Rex
> writel_relaxed(0x0, ovl->regs + DISP_REG_OVL_INTEN);
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-17 12:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-14 8:08 drm/mediatek: fixup ovl vblank callback data null pointer issue Yongqiang Niu
2022-03-14 8:08 ` [PATCH v1, 1/1] " Yongqiang Niu
2022-03-17 12:46 ` Rex-BC Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).