* [PATCH V2] arm64: Declare non global symbols as static
@ 2022-05-09 4:32 Linu Cherian
2022-05-10 11:05 ` Will Deacon
2022-05-11 16:10 ` Catalin Marinas
0 siblings, 2 replies; 3+ messages in thread
From: Linu Cherian @ 2022-05-09 4:32 UTC (permalink / raw)
To: maz, catalin.marinas, will
Cc: linux-kernel, linux-arm-kernel, linuc.decode, Linu Cherian,
kernel test robot
Fix below sparse warnings introduced while adding errata.
arch/arm64/kernel/cpu_errata.c:218:25: sparse: warning: symbol
'cavium_erratum_23154_cpus' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Linu Cherian <lcherian@marvell.com>
---
Changes from V1:
Reverted change to global symbol cavium_erratum_27456_cpus since it
was used in other files.
arch/arm64/kernel/cpu_errata.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
index 4c9b5b4b7a0b..49f4863c6c56 100644
--- a/arch/arm64/kernel/cpu_errata.c
+++ b/arch/arm64/kernel/cpu_errata.c
@@ -215,7 +215,7 @@ static const struct arm64_cpu_capabilities arm64_repeat_tlbi_list[] = {
#endif
#ifdef CONFIG_CAVIUM_ERRATUM_23154
-const struct midr_range cavium_erratum_23154_cpus[] = {
+static const struct midr_range cavium_erratum_23154_cpus[] = {
MIDR_ALL_VERSIONS(MIDR_THUNDERX),
MIDR_ALL_VERSIONS(MIDR_THUNDERX_81XX),
MIDR_ALL_VERSIONS(MIDR_THUNDERX_83XX),
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] arm64: Declare non global symbols as static
2022-05-09 4:32 [PATCH V2] arm64: Declare non global symbols as static Linu Cherian
@ 2022-05-10 11:05 ` Will Deacon
2022-05-11 16:10 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2022-05-10 11:05 UTC (permalink / raw)
To: Linu Cherian
Cc: maz, catalin.marinas, linux-kernel, linux-arm-kernel,
linuc.decode, kernel test robot
On Mon, May 09, 2022 at 10:02:21AM +0530, Linu Cherian wrote:
> Fix below sparse warnings introduced while adding errata.
>
> arch/arm64/kernel/cpu_errata.c:218:25: sparse: warning: symbol
> 'cavium_erratum_23154_cpus' was not declared. Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Linu Cherian <lcherian@marvell.com>
> ---
> Changes from V1:
> Reverted change to global symbol cavium_erratum_27456_cpus since it
> was used in other files.
>
> arch/arm64/kernel/cpu_errata.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Will Deacon <will@kernel.org>
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] arm64: Declare non global symbols as static
2022-05-09 4:32 [PATCH V2] arm64: Declare non global symbols as static Linu Cherian
2022-05-10 11:05 ` Will Deacon
@ 2022-05-11 16:10 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2022-05-11 16:10 UTC (permalink / raw)
To: maz, will, Linu Cherian
Cc: linuc.decode, linux-kernel, linux-arm-kernel, kernel test robot
On Mon, 9 May 2022 10:02:21 +0530, Linu Cherian wrote:
> Fix below sparse warnings introduced while adding errata.
>
> arch/arm64/kernel/cpu_errata.c:218:25: sparse: warning: symbol
> 'cavium_erratum_23154_cpus' was not declared. Should it be static?
>
>
Applied to arm64 (for-next/misc), thanks!
[1/1] arm64: Declare non global symbols as static
https://git.kernel.org/arm64/c/710c8d6c026c
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-11 16:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-09 4:32 [PATCH V2] arm64: Declare non global symbols as static Linu Cherian
2022-05-10 11:05 ` Will Deacon
2022-05-11 16:10 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).