From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alexandre Bailon <abailon@baylibre.com>,
krzk+dt@kernel.org, matthias.bgg@gmail.com,
p.zabel@pengutronix.de, rafael@kernel.org,
daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com,
michael.kao@mediatek.com, ben.tseng@mediatek.com,
ethan.chang@mediatek.com, frank-w@public-files.de,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, khilman@baylibre.com
Subject: Re: [PATCH v6 2/7] dt-bindings: thermal: Add binding document for mt6873 thermal controller
Date: Tue, 17 May 2022 12:59:58 -0500 [thread overview]
Message-ID: <20220517175958.GA1321687-robh@kernel.org> (raw)
In-Reply-To: <546ddbd4-927d-2e28-6e82-a67b4584a17f@linaro.org>
On Thu, May 12, 2022 at 04:25:51PM +0200, Krzysztof Kozlowski wrote:
> On 12/05/2022 14:24, Alexandre Bailon wrote:
> > From: Michael Kao <michael.kao@mediatek.com>
> >
> > This patch adds binding document for mt6873 thermal controller.
>
> Thank you for your patch. There is something to discuss/improve.
>
> >
> > Signed-off-by: Michael Kao <michael.kao@mediatek.com>
> > Signed-off-by: Ben Tseng <ben.tseng@mediatek.com>
> > ---
> > .../thermal/mediatek-thermal-lvts.yaml | 81 +++++++++++++++++++
> > 1 file changed, 81 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> > new file mode 100644
> > index 000000000000..69ffe7b14c21
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
>
> filename: vendor,device
> so something like mediatek,mt6873-lvts.yaml or
> mediatek,mt6873-lvts-thermal.yaml
>
> > @@ -0,0 +1,81 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/thermal/mediatek-thermal-lvts.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek SoC LVTS thermal controller (DTS) binding
>
> s/(DTS) binding//
> (unless DTS means something related to hardware)
>
> > +
> > +maintainers:
> > + - Yu-Chia Chang <ethan.chang@mediatek.com>
> > + - Ben Tseng <ben.tseng@mediatek.com>
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt6873-lvts
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + clock-names:
> > + items:
> > + - const: lvts_clk
>
> Skip "_clk" suffix, so just lvts.
Or drop altogether. There's generally no good name when there's only one
entry so folks just make up 'clk', 'phy', 'rst', etc. or $block for the
name.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-17 18:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 12:24 [PATCH v6 0/7] Add LVTS architecture thermal Alexandre Bailon
2022-05-12 12:24 ` [PATCH v6 1/7] thermal: mediatek: Relocate driver to mediatek folder Alexandre Bailon
2022-05-17 11:54 ` Rex-BC Chen
2022-05-12 12:24 ` [PATCH v6 2/7] dt-bindings: thermal: Add binding document for mt6873 thermal controller Alexandre Bailon
2022-05-12 14:25 ` Krzysztof Kozlowski
2022-05-17 17:59 ` Rob Herring [this message]
2022-05-12 12:24 ` [PATCH v6 3/7] thermal: mediatek: Add LVTS drivers for SoC theraml zones Alexandre Bailon
2022-05-12 14:29 ` Krzysztof Kozlowski
2022-05-17 12:13 ` Rex-BC Chen
2022-05-12 12:24 ` [PATCH v6 4/7] dt-bindings: thermal: Add binding document for mt8195 thermal controller Alexandre Bailon
2022-05-12 14:30 ` Krzysztof Kozlowski
2022-05-12 12:24 ` [PATCH v6 5/7] thermal: mediatek: Add thermal zone settings for mt8195 Alexandre Bailon
2022-05-12 12:24 ` [PATCH v6 6/7] arm64: dts: mt8195: Add efuse node to mt8195 Alexandre Bailon
2022-05-12 12:24 ` [PATCH v6 7/7] arm64: dts: mt8195: Add thermal zone Alexandre Bailon
2022-05-12 14:32 ` Krzysztof Kozlowski
2022-05-12 12:33 ` [PATCH v6 0/7] Add LVTS architecture thermal Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517175958.GA1321687-robh@kernel.org \
--to=robh@kernel.org \
--cc=abailon@baylibre.com \
--cc=amitk@kernel.org \
--cc=ben.tseng@mediatek.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ethan.chang@mediatek.com \
--cc=frank-w@public-files.de \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=michael.kao@mediatek.com \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).