* [PATCH 2/4] arm64: dts: rockchip: px30: max drive-strength for cif_clkout_m0
[not found] <20220519075117.1003520-1-tommaso.merciai@amarulasolutions.com>
@ 2022-05-19 7:51 ` Tommaso Merciai
2022-05-23 8:17 ` Michael Nazzareno Trimarchi
2022-05-19 7:51 ` [PATCH 3/4] arm64: dts: rockchip: px30: add mux for mipi-pdn pad Tommaso Merciai
2022-05-19 7:51 ` [PATCH 4/4] arm64: dts: rockchip: px30: use rk gpio naming convention into reset-gpios Tommaso Merciai
2 siblings, 1 reply; 6+ messages in thread
From: Tommaso Merciai @ 2022-05-19 7:51 UTC (permalink / raw)
Cc: tommaso.merciai, linuxfancy, linux-amarula, michael, Rob Herring,
Krzysztof Kozlowski, Heiko Stuebner, Shunqian Zheng,
Mauro Carvalho Chehab, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-media
Add max drive-strength for cif_clkout_m0. This fix the issue that
sometimes camera ov5695 is not probed correctly.
Tested on PX30_Mini_EVB_V11_20190507
Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Tested-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
---
arch/arm64/boot/dts/rockchip/px30-evb.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/px30-evb.dts b/arch/arm64/boot/dts/rockchip/px30-evb.dts
index 848bc39cf86a..53930e28eadf 100644
--- a/arch/arm64/boot/dts/rockchip/px30-evb.dts
+++ b/arch/arm64/boot/dts/rockchip/px30-evb.dts
@@ -537,6 +537,13 @@ wifi_enable_h: wifi-enable-h {
<0 RK_PA2 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
+
+ cif-m0 {
+ cif_clkout_m0: cif-clkout-m0 {
+ rockchip,pins =
+ <2 RK_PB3 1 &pcfg_pull_none_12ma>;
+ };
+ };
};
&pmu_io_domains {
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] arm64: dts: rockchip: px30: add mux for mipi-pdn pad
[not found] <20220519075117.1003520-1-tommaso.merciai@amarulasolutions.com>
2022-05-19 7:51 ` [PATCH 2/4] arm64: dts: rockchip: px30: max drive-strength for cif_clkout_m0 Tommaso Merciai
@ 2022-05-19 7:51 ` Tommaso Merciai
2022-05-23 8:18 ` Michael Nazzareno Trimarchi
2022-05-19 7:51 ` [PATCH 4/4] arm64: dts: rockchip: px30: use rk gpio naming convention into reset-gpios Tommaso Merciai
2 siblings, 1 reply; 6+ messages in thread
From: Tommaso Merciai @ 2022-05-19 7:51 UTC (permalink / raw)
Cc: tommaso.merciai, linuxfancy, linux-amarula, michael, Rob Herring,
Krzysztof Kozlowski, Heiko Stuebner, Shunqian Zheng,
Mauro Carvalho Chehab, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-media
Add right mux for mipi-pdn. Mux this pad as gpio2 14
Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Tested-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
---
arch/arm64/boot/dts/rockchip/px30-evb.dts | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/px30-evb.dts b/arch/arm64/boot/dts/rockchip/px30-evb.dts
index 53930e28eadf..0d05a1b098bc 100644
--- a/arch/arm64/boot/dts/rockchip/px30-evb.dts
+++ b/arch/arm64/boot/dts/rockchip/px30-evb.dts
@@ -450,8 +450,8 @@ ov5695: ov5695@36 {
dvdd-supply = <&vcc1v5_dvp>;
dovdd-supply = <&vcc1v8_dvp>;
pinctrl-names = "default";
- pinctrl-0 = <&cif_clkout_m0>;
reset-gpios = <&gpio2 14 GPIO_ACTIVE_LOW>;
+ pinctrl-0 = <&cif_clkout_m0 &mipi_pdn>;
port {
ucam_out: endpoint {
@@ -544,6 +544,12 @@ cif_clkout_m0: cif-clkout-m0 {
<2 RK_PB3 1 &pcfg_pull_none_12ma>;
};
};
+
+ mipi {
+ mipi_pdn: mipi-pdn {
+ rockchip,pins = <2 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
};
&pmu_io_domains {
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/4] arm64: dts: rockchip: px30: use rk gpio naming convention into reset-gpios
[not found] <20220519075117.1003520-1-tommaso.merciai@amarulasolutions.com>
2022-05-19 7:51 ` [PATCH 2/4] arm64: dts: rockchip: px30: max drive-strength for cif_clkout_m0 Tommaso Merciai
2022-05-19 7:51 ` [PATCH 3/4] arm64: dts: rockchip: px30: add mux for mipi-pdn pad Tommaso Merciai
@ 2022-05-19 7:51 ` Tommaso Merciai
2022-05-23 8:16 ` Michael Nazzareno Trimarchi
2 siblings, 1 reply; 6+ messages in thread
From: Tommaso Merciai @ 2022-05-19 7:51 UTC (permalink / raw)
Cc: tommaso.merciai, linuxfancy, linux-amarula, michael, Rob Herring,
Krzysztof Kozlowski, Heiko Stuebner, Shunqian Zheng,
Mauro Carvalho Chehab, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-media
Use rk gpio naming convention into reset-gpios of ov5695 camera
Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Tested-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
---
arch/arm64/boot/dts/rockchip/px30-evb.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/px30-evb.dts b/arch/arm64/boot/dts/rockchip/px30-evb.dts
index 0d05a1b098bc..07008d84434c 100644
--- a/arch/arm64/boot/dts/rockchip/px30-evb.dts
+++ b/arch/arm64/boot/dts/rockchip/px30-evb.dts
@@ -450,8 +450,8 @@ ov5695: ov5695@36 {
dvdd-supply = <&vcc1v5_dvp>;
dovdd-supply = <&vcc1v8_dvp>;
pinctrl-names = "default";
- reset-gpios = <&gpio2 14 GPIO_ACTIVE_LOW>;
pinctrl-0 = <&cif_clkout_m0 &mipi_pdn>;
+ reset-gpios = <&gpio2 RK_PB6 GPIO_ACTIVE_LOW>;
port {
ucam_out: endpoint {
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] arm64: dts: rockchip: px30: use rk gpio naming convention into reset-gpios
2022-05-19 7:51 ` [PATCH 4/4] arm64: dts: rockchip: px30: use rk gpio naming convention into reset-gpios Tommaso Merciai
@ 2022-05-23 8:16 ` Michael Nazzareno Trimarchi
0 siblings, 0 replies; 6+ messages in thread
From: Michael Nazzareno Trimarchi @ 2022-05-23 8:16 UTC (permalink / raw)
To: Tommaso Merciai
Cc: linuxfancy, linux-amarula, Rob Herring, Krzysztof Kozlowski,
Heiko Stuebner, Shunqian Zheng, Mauro Carvalho Chehab,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
linux-media
Hi
On Thu, May 19, 2022 at 9:51 AM Tommaso Merciai
<tommaso.merciai@amarulasolutions.com> wrote:
>
> Use rk gpio naming convention into reset-gpios of ov5695 camera
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> Tested-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> ---
> arch/arm64/boot/dts/rockchip/px30-evb.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/px30-evb.dts b/arch/arm64/boot/dts/rockchip/px30-evb.dts
> index 0d05a1b098bc..07008d84434c 100644
> --- a/arch/arm64/boot/dts/rockchip/px30-evb.dts
> +++ b/arch/arm64/boot/dts/rockchip/px30-evb.dts
> @@ -450,8 +450,8 @@ ov5695: ov5695@36 {
> dvdd-supply = <&vcc1v5_dvp>;
> dovdd-supply = <&vcc1v8_dvp>;
> pinctrl-names = "default";
> - reset-gpios = <&gpio2 14 GPIO_ACTIVE_LOW>;
> pinctrl-0 = <&cif_clkout_m0 &mipi_pdn>;
> + reset-gpios = <&gpio2 RK_PB6 GPIO_ACTIVE_LOW>;
>
Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>
> port {
> ucam_out: endpoint {
> --
> 2.25.1
>
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/4] arm64: dts: rockchip: px30: max drive-strength for cif_clkout_m0
2022-05-19 7:51 ` [PATCH 2/4] arm64: dts: rockchip: px30: max drive-strength for cif_clkout_m0 Tommaso Merciai
@ 2022-05-23 8:17 ` Michael Nazzareno Trimarchi
0 siblings, 0 replies; 6+ messages in thread
From: Michael Nazzareno Trimarchi @ 2022-05-23 8:17 UTC (permalink / raw)
To: Tommaso Merciai
Cc: linuxfancy, linux-amarula, Rob Herring, Krzysztof Kozlowski,
Heiko Stuebner, Shunqian Zheng, Mauro Carvalho Chehab,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
linux-media
Hi
On Thu, May 19, 2022 at 9:51 AM Tommaso Merciai
<tommaso.merciai@amarulasolutions.com> wrote:
>
> Add max drive-strength for cif_clkout_m0. This fix the issue that
> sometimes camera ov5695 is not probed correctly.
> Tested on PX30_Mini_EVB_V11_20190507
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> Tested-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> ---
> arch/arm64/boot/dts/rockchip/px30-evb.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/px30-evb.dts b/arch/arm64/boot/dts/rockchip/px30-evb.dts
> index 848bc39cf86a..53930e28eadf 100644
> --- a/arch/arm64/boot/dts/rockchip/px30-evb.dts
> +++ b/arch/arm64/boot/dts/rockchip/px30-evb.dts
> @@ -537,6 +537,13 @@ wifi_enable_h: wifi-enable-h {
> <0 RK_PA2 RK_FUNC_GPIO &pcfg_pull_none>;
> };
> };
> +
> + cif-m0 {
> + cif_clkout_m0: cif-clkout-m0 {
> + rockchip,pins =
> + <2 RK_PB3 1 &pcfg_pull_none_12ma>;
> + };
> + };
> };
This is the same now on rockchip bsp
Reviewed-by: Michael Trimarchi <michael@amarulasolutios.com>
>
> &pmu_io_domains {
> --
> 2.25.1
>
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/4] arm64: dts: rockchip: px30: add mux for mipi-pdn pad
2022-05-19 7:51 ` [PATCH 3/4] arm64: dts: rockchip: px30: add mux for mipi-pdn pad Tommaso Merciai
@ 2022-05-23 8:18 ` Michael Nazzareno Trimarchi
0 siblings, 0 replies; 6+ messages in thread
From: Michael Nazzareno Trimarchi @ 2022-05-23 8:18 UTC (permalink / raw)
To: Tommaso Merciai
Cc: linuxfancy, linux-amarula, Rob Herring, Krzysztof Kozlowski,
Heiko Stuebner, Shunqian Zheng, Mauro Carvalho Chehab,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
linux-media
Hi
On Thu, May 19, 2022 at 9:51 AM Tommaso Merciai
<tommaso.merciai@amarulasolutions.com> wrote:
>
> Add right mux for mipi-pdn. Mux this pad as gpio2 14
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> Tested-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> ---
> arch/arm64/boot/dts/rockchip/px30-evb.dts | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/px30-evb.dts b/arch/arm64/boot/dts/rockchip/px30-evb.dts
> index 53930e28eadf..0d05a1b098bc 100644
> --- a/arch/arm64/boot/dts/rockchip/px30-evb.dts
> +++ b/arch/arm64/boot/dts/rockchip/px30-evb.dts
> @@ -450,8 +450,8 @@ ov5695: ov5695@36 {
> dvdd-supply = <&vcc1v5_dvp>;
> dovdd-supply = <&vcc1v8_dvp>;
> pinctrl-names = "default";
> - pinctrl-0 = <&cif_clkout_m0>;
> reset-gpios = <&gpio2 14 GPIO_ACTIVE_LOW>;
> + pinctrl-0 = <&cif_clkout_m0 &mipi_pdn>;
>
> port {
> ucam_out: endpoint {
> @@ -544,6 +544,12 @@ cif_clkout_m0: cif-clkout-m0 {
> <2 RK_PB3 1 &pcfg_pull_none_12ma>;
> };
> };
> +
> + mipi {
> + mipi_pdn: mipi-pdn {
> + rockchip,pins = <2 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> };
>
Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>
Michael
> &pmu_io_domains {
> --
> 2.25.1
>
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-23 9:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220519075117.1003520-1-tommaso.merciai@amarulasolutions.com>
2022-05-19 7:51 ` [PATCH 2/4] arm64: dts: rockchip: px30: max drive-strength for cif_clkout_m0 Tommaso Merciai
2022-05-23 8:17 ` Michael Nazzareno Trimarchi
2022-05-19 7:51 ` [PATCH 3/4] arm64: dts: rockchip: px30: add mux for mipi-pdn pad Tommaso Merciai
2022-05-23 8:18 ` Michael Nazzareno Trimarchi
2022-05-19 7:51 ` [PATCH 4/4] arm64: dts: rockchip: px30: use rk gpio naming convention into reset-gpios Tommaso Merciai
2022-05-23 8:16 ` Michael Nazzareno Trimarchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).