* [PATCH 1/2] net/ncsi: use proper "mellanox" DT vendor prefix
@ 2022-05-29 11:10 Krzysztof Kozlowski
2022-05-29 11:10 ` [PATCH 2/2] ARM: dts: aspeed: yosemitev2: " Krzysztof Kozlowski
2022-05-31 8:21 ` [PATCH 1/2] net/ncsi: " Paolo Abeni
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-29 11:10 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Joel Stanley, Andrew Jeffery,
Samuel Mendoza-Jonas, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel, netdev
Cc: Krzysztof Kozlowski
"mlx" Devicetree vendor prefix is not documented and instead "mellanox"
should be used.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
net/ncsi/ncsi-manage.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c
index 78814417d753..80713febfac6 100644
--- a/net/ncsi/ncsi-manage.c
+++ b/net/ncsi/ncsi-manage.c
@@ -1803,7 +1803,8 @@ struct ncsi_dev *ncsi_register_dev(struct net_device *dev,
pdev = to_platform_device(dev->dev.parent);
if (pdev) {
np = pdev->dev.of_node;
- if (np && of_get_property(np, "mlx,multi-host", NULL))
+ if (np && (of_get_property(np, "mellanox,multi-host", NULL) ||
+ of_get_property(np, "mlx,multi-host", NULL)))
ndp->mlx_multi_host = true;
}
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] ARM: dts: aspeed: yosemitev2: use proper "mellanox" DT vendor prefix
2022-05-29 11:10 [PATCH 1/2] net/ncsi: use proper "mellanox" DT vendor prefix Krzysztof Kozlowski
@ 2022-05-29 11:10 ` Krzysztof Kozlowski
2022-05-31 8:21 ` [PATCH 1/2] net/ncsi: " Paolo Abeni
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-29 11:10 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Joel Stanley, Andrew Jeffery,
Samuel Mendoza-Jonas, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel, netdev
Cc: Krzysztof Kozlowski
"mlx" Devicetree vendor prefix is not documented and instead "mellanox"
should be used:
aspeed-bmc-facebook-yosemitev2.dtb: ethernet@1e660000: 'mlx,multi-host' does not match any of the regexes
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
The change depends on net/ncsi change.
---
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
index 8864e9c312a8..26217bc652e7 100644
--- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
@@ -95,7 +95,7 @@ &mac0 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_rmii1_default>;
use-ncsi;
- mlx,multi-host;
+ mellanox,multi-host;
};
&adc {
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] net/ncsi: use proper "mellanox" DT vendor prefix
2022-05-29 11:10 [PATCH 1/2] net/ncsi: use proper "mellanox" DT vendor prefix Krzysztof Kozlowski
2022-05-29 11:10 ` [PATCH 2/2] ARM: dts: aspeed: yosemitev2: " Krzysztof Kozlowski
@ 2022-05-31 8:21 ` Paolo Abeni
2022-05-31 9:06 ` Krzysztof Kozlowski
1 sibling, 1 reply; 4+ messages in thread
From: Paolo Abeni @ 2022-05-31 8:21 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Joel Stanley, Andrew Jeffery, Samuel Mendoza-Jonas,
David S. Miller, Eric Dumazet, Jakub Kicinski, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel, netdev
Hello,
On Sun, 2022-05-29 at 13:10 +0200, Krzysztof Kozlowski wrote:
> "mlx" Devicetree vendor prefix is not documented and instead "mellanox"
> should be used.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> net/ncsi/ncsi-manage.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c
> index 78814417d753..80713febfac6 100644
> --- a/net/ncsi/ncsi-manage.c
> +++ b/net/ncsi/ncsi-manage.c
> @@ -1803,7 +1803,8 @@ struct ncsi_dev *ncsi_register_dev(struct net_device *dev,
> pdev = to_platform_device(dev->dev.parent);
> if (pdev) {
> np = pdev->dev.of_node;
> - if (np && of_get_property(np, "mlx,multi-host", NULL))
> + if (np && (of_get_property(np, "mellanox,multi-host", NULL) ||
> + of_get_property(np, "mlx,multi-host", NULL)))
> ndp->mlx_multi_host = true;
> }
>
I can't guess which tree are you targeting, devicetree? net-next? could
you please specify?
thanks!
Paolo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] net/ncsi: use proper "mellanox" DT vendor prefix
2022-05-31 8:21 ` [PATCH 1/2] net/ncsi: " Paolo Abeni
@ 2022-05-31 9:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-31 9:06 UTC (permalink / raw)
To: Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Joel Stanley,
Andrew Jeffery, Samuel Mendoza-Jonas, David S. Miller,
Eric Dumazet, Jakub Kicinski, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel, netdev
On 31/05/2022 10:21, Paolo Abeni wrote:
> Hello,
>
> On Sun, 2022-05-29 at 13:10 +0200, Krzysztof Kozlowski wrote:
>> "mlx" Devicetree vendor prefix is not documented and instead "mellanox"
>> should be used.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> net/ncsi/ncsi-manage.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c
>> index 78814417d753..80713febfac6 100644
>> --- a/net/ncsi/ncsi-manage.c
>> +++ b/net/ncsi/ncsi-manage.c
>> @@ -1803,7 +1803,8 @@ struct ncsi_dev *ncsi_register_dev(struct net_device *dev,
>> pdev = to_platform_device(dev->dev.parent);
>> if (pdev) {
>> np = pdev->dev.of_node;
>> - if (np && of_get_property(np, "mlx,multi-host", NULL))
>> + if (np && (of_get_property(np, "mellanox,multi-host", NULL) ||
>> + of_get_property(np, "mlx,multi-host", NULL)))
>> ndp->mlx_multi_host = true;
>> }
>>
>
> I can't guess which tree are you targeting, devicetree? net-next? could
> you please specify?
Both independently. The patch here for net-next (although it is closed
now). The DTS patch can come later via ARM SoC maintainer tree.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-31 9:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-29 11:10 [PATCH 1/2] net/ncsi: use proper "mellanox" DT vendor prefix Krzysztof Kozlowski
2022-05-29 11:10 ` [PATCH 2/2] ARM: dts: aspeed: yosemitev2: " Krzysztof Kozlowski
2022-05-31 8:21 ` [PATCH 1/2] net/ncsi: " Paolo Abeni
2022-05-31 9:06 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).