linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] pwm: atmel-tcb: use 'unsigned int' instead of 'unsigned'
       [not found] <20220608010607.19469-1-yuanjilin@cdjrlc.com>
@ 2022-06-08  6:45 ` Uwe Kleine-König
  0 siblings, 0 replies; only message in thread
From: Uwe Kleine-König @ 2022-06-08  6:45 UTC (permalink / raw)
  To: Jilin Yuan
  Cc: linux-pwm, alexandre.belloni, linux-kernel, thierry.reding,
	lee.jones, claudiu.beznea, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 1335 bytes --]

On Wed, Jun 08, 2022 at 09:06:07AM +0800, Jilin Yuan wrote:
> Replace the 'unsigned' with 'unsigned int' which is more accurate.

What was your motivation? To please checkpatch? Please mention this in
the commit log.

> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
>  drivers/pwm/pwm-atmel-tcb.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
> index 3977a0f9d132..d6977e4e71f3 100644
> --- a/drivers/pwm/pwm-atmel-tcb.c
> +++ b/drivers/pwm/pwm-atmel-tcb.c
> @@ -35,9 +35,9 @@
>  
>  struct atmel_tcb_pwm_device {
>  	enum pwm_polarity polarity;	/* PWM polarity */
> -	unsigned div;			/* PWM clock divider */
> -	unsigned duty;			/* PWM duty expressed in clk cycles */
> -	unsigned period;		/* PWM period expressed in clk cycles */
> +	unsigned int div;			/* PWM clock divider */
> +	unsigned int duty;			/* PWM duty expressed in clk cycles */
> +	unsigned int period;		/* PWM period expressed in clk cycles */

Please reindent the comments such they keep to be aligned.

>  };
>  
>  struct atmel_tcb_channel {

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-06-08  6:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20220608010607.19469-1-yuanjilin@cdjrlc.com>
2022-06-08  6:45 ` [PATCH] pwm: atmel-tcb: use 'unsigned int' instead of 'unsigned' Uwe Kleine-König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).