linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pwm: stmpe: Deleted extra {}
@ 2022-06-08  1:03 Jilin Yuan
  2022-06-08  6:51 ` Uwe Kleine-König
  0 siblings, 1 reply; 2+ messages in thread
From: Jilin Yuan @ 2022-06-08  1:03 UTC (permalink / raw)
  To: thierry.reding, lee.jones, mcoquelin.stm32, alexandre.torgue
  Cc: u.kleine-koenig, linux-pwm, linux-stm32, linux-arm-kernel,
	linux-kernel, Jilin Yuan

Remove unnecessary braces

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/pwm/pwm-stmpe.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pwm/pwm-stmpe.c b/drivers/pwm/pwm-stmpe.c
index 2df526fe9c38..c45fe27859de 100644
--- a/drivers/pwm/pwm-stmpe.c
+++ b/drivers/pwm/pwm-stmpe.c
@@ -78,10 +78,9 @@ static void stmpe_24xx_pwm_disable(struct pwm_chip *chip,
 	value = ret & ~BIT(pwm->hwpwm);
 
 	ret = stmpe_reg_write(stmpe_pwm->stmpe, STMPE24XX_PWMCS, value);
-	if (ret) {
+	if (ret)
 		dev_err(chip->dev, "error writing PWM#%u control\n",
 			pwm->hwpwm);
-	}
 }
 
 /* STMPE 24xx PWM instructions */
-- 
2.36.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] pwm: stmpe: Deleted extra {}
  2022-06-08  1:03 [PATCH] pwm: stmpe: Deleted extra {} Jilin Yuan
@ 2022-06-08  6:51 ` Uwe Kleine-König
  0 siblings, 0 replies; 2+ messages in thread
From: Uwe Kleine-König @ 2022-06-08  6:51 UTC (permalink / raw)
  To: Jilin Yuan
  Cc: thierry.reding, lee.jones, mcoquelin.stm32, alexandre.torgue,
	linux-pwm, linux-stm32, linux-arm-kernel, linux-kernel


[-- Attachment #1.1: Type: text/plain, Size: 1304 bytes --]

On Wed, Jun 08, 2022 at 09:03:18AM +0800, Jilin Yuan wrote:
> Remove unnecessary braces
> 
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
>  drivers/pwm/pwm-stmpe.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-stmpe.c b/drivers/pwm/pwm-stmpe.c
> index 2df526fe9c38..c45fe27859de 100644
> --- a/drivers/pwm/pwm-stmpe.c
> +++ b/drivers/pwm/pwm-stmpe.c
> @@ -78,10 +78,9 @@ static void stmpe_24xx_pwm_disable(struct pwm_chip *chip,
>  	value = ret & ~BIT(pwm->hwpwm);
>  
>  	ret = stmpe_reg_write(stmpe_pwm->stmpe, STMPE24XX_PWMCS, value);
> -	if (ret) {
> +	if (ret)
>  		dev_err(chip->dev, "error writing PWM#%u control\n",
>  			pwm->hwpwm);
> -	}
>  }

This doesn't apply to neither next nor on the pwm tree nor on Linus
Torvald's tree. Please always mention preconditions of your patches,
preferably using git format-patch's --base option.

In this case it builds on top of a patch that was sent to only some
maintainers, but no public list. Please squash these patches together
and send them to (at least) linux-pwm@vger.kernel.org.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-08  6:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-08  1:03 [PATCH] pwm: stmpe: Deleted extra {} Jilin Yuan
2022-06-08  6:51 ` Uwe Kleine-König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).