linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] ARM: dts: at91: ksz9477_evb: fix port/phy validation
@ 2022-06-10  8:16 Oleksij Rempel
  2022-06-15  5:13 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Oleksij Rempel @ 2022-06-10  8:16 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Nicolas Ferre,
	Alexandre Belloni, Claudiu Beznea, Arun Ramadoss
  Cc: Oleksij Rempel, kernel, linux-kernel, netdev, devicetree,
	linux-arm-kernel

Latest drivers version requires phy-mode to be set. Otherwise we will
use "NA" mode and the switch driver will invalidate this port mode.

Fixes: 65ac79e18120 ("net: dsa: microchip: add the phylink get_caps")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/at91-sama5d3_ksz9477_evb.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/at91-sama5d3_ksz9477_evb.dts b/arch/arm/boot/dts/at91-sama5d3_ksz9477_evb.dts
index 443e8b022897..14af1fd6d247 100644
--- a/arch/arm/boot/dts/at91-sama5d3_ksz9477_evb.dts
+++ b/arch/arm/boot/dts/at91-sama5d3_ksz9477_evb.dts
@@ -120,26 +120,31 @@ ports {
 			port@0 {
 				reg = <0>;
 				label = "lan1";
+				phy-mode = "internal";
 			};
 
 			port@1 {
 				reg = <1>;
 				label = "lan2";
+				phy-mode = "internal";
 			};
 
 			port@2 {
 				reg = <2>;
 				label = "lan3";
+				phy-mode = "internal";
 			};
 
 			port@3 {
 				reg = <3>;
 				label = "lan4";
+				phy-mode = "internal";
 			};
 
 			port@4 {
 				reg = <4>;
 				label = "lan5";
+				phy-mode = "internal";
 			};
 
 			port@5 {
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] ARM: dts: at91: ksz9477_evb: fix port/phy validation
  2022-06-10  8:16 [PATCH v1] ARM: dts: at91: ksz9477_evb: fix port/phy validation Oleksij Rempel
@ 2022-06-15  5:13 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-06-15  5:13 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: devicetree, Arun Ramadoss, kernel, linux-kernel,
	Alexandre Belloni, Rob Herring, Krzysztof Kozlowski, netdev,
	Claudiu Beznea, linux-arm-kernel

On Fri, 10 Jun 2022 10:16:21 +0200 Oleksij Rempel wrote:
> Latest drivers version requires phy-mode to be set. Otherwise we will
> use "NA" mode and the switch driver will invalidate this port mode.
> 
> Fixes: 65ac79e18120 ("net: dsa: microchip: add the phylink get_caps")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

This got an Awaiting Upstream in patchwork along the way, but based on
Krzysztof's comment I think net is right here. So it's commit
56315b6bf7fc ("ARM: dts: at91: ksz9477_evb: fix port/phy validation")
in net now 🤷

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-15  5:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-10  8:16 [PATCH v1] ARM: dts: at91: ksz9477_evb: fix port/phy validation Oleksij Rempel
2022-06-15  5:13 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).