[PATCH v1 1/3] power: domain: handle power supplies that need irq

From: Martin Kepplinger <martin.kepplinger@puri.sm>
To: rafael@kernel.org, khilman@kernel.org, ulf.hansson@linaro.org,
	robh@kernel.org, krzysztof.kozlowski@linaro.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
	pavel@ucw.cz
Cc: kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org,
	l.stach@pengutronix.de, aford173@gmail.com,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Martin Kepplinger <martin.kepplinger@puri.sm>
Subject: [PATCH v1 1/3] power: domain: handle power supplies that need irq
Date: Mon, 11 Jul 2022 11:45:47 +0200	[thread overview]
Message-ID: <20220711094549.3445566-1-martin.kepplinger@puri.sm> (raw)

Handle a new DT property power-supply-needs-irq that boards can
use if the power-domains' power-supply node (regulator) needs
interrupts to function. An example is a pmic regulator on i2c.

Since suspend/resume doesn't work in these cases currently, switch
to the normal, outer suspend/resume callbacks.

Usually such a regulator already times out during suspend_noirq:

[   41.024193] buck4: failed to disable: -ETIMEDOUT

Initially systemd suspend problems had been discussed at
https://lore.kernel.org/linux-arm-kernel/20211002005954.1367653-8-l.stach@pengutronix.de/
which led to discussing the pmic that contains the regulators which
serve as power-domain power-supplies:
https://lore.kernel.org/linux-pm/573166b75e524517782471c2b7f96e03fd93d175.camel@puri.sm/T/

So this enables boards to use power-supply-needs-irq and fix systemd
suspend and resume.

Possibly one can find more changes this property should configure. They
can be added later when testing them.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
 drivers/base/power/domain.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 3e86772d5fac..c8fecba2c191 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -2298,6 +2298,16 @@ static bool genpd_present(const struct generic_pm_domain *genpd)
 	return ret;
 }
 
+static void of_genpd_get_power_supply_irq(struct generic_pm_domain *pd)
+{
+	if (of_property_read_bool(pd->dev.of_node, "power-supply-needs-irq")) {
+		pd->domain.ops.suspend = genpd_suspend_noirq;
+		pd->domain.ops.resume = genpd_resume_noirq;
+		pd->domain.ops.suspend_noirq = NULL;
+		pd->domain.ops.resume_noirq = NULL;
+	}
+}
+
 /**
  * of_genpd_add_provider_simple() - Register a simple PM domain provider
  * @np: Device node pointer associated with the PM domain provider.
@@ -2343,6 +2353,8 @@ int of_genpd_add_provider_simple(struct device_node *np,
 	genpd->provider = &np->fwnode;
 	genpd->has_provider = true;
 
+	of_genpd_get_power_supply_irq(genpd);
+
 	return 0;
 }
 EXPORT_SYMBOL_GPL(of_genpd_add_provider_simple);
@@ -2394,6 +2406,8 @@ int of_genpd_add_provider_onecell(struct device_node *np,
 
 		genpd->provider = &np->fwnode;
 		genpd->has_provider = true;
+
+		of_genpd_get_power_supply_irq(genpd);
 	}
 
 	ret = genpd_add_provider(np, data->xlate, data);
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
