From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>,
rafael@kernel.org, khilman@kernel.org, ulf.hansson@linaro.org,
robh@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
festevam@gmail.com, pavel@ucw.cz
Cc: kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org,
l.stach@pengutronix.de, aford173@gmail.com,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 2/3] dt-binding: power: power-domain: add power-supply-needs-irq
Date: Mon, 11 Jul 2022 12:38:28 +0200 [thread overview]
Message-ID: <c68e4ae9-c435-c74e-91cd-b153be6de92f@linaro.org> (raw)
In-Reply-To: <20220711094549.3445566-2-martin.kepplinger@puri.sm>
On 11/07/2022 11:45, Martin Kepplinger wrote:
> Add the power-supply-needs-irq board description property for power domains.
Where is a board description here? I think you just meant
"power-supply-needs-irq property"?
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
> .../devicetree/bindings/power/power-domain.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/power-domain.yaml b/Documentation/devicetree/bindings/power/power-domain.yaml
> index 889091b9814f..e82c2f7ccb97 100644
> --- a/Documentation/devicetree/bindings/power/power-domain.yaml
> +++ b/Documentation/devicetree/bindings/power/power-domain.yaml
> @@ -70,6 +70,16 @@ properties:
> by the given provider should be subdomains of the domain specified
> by this binding.
>
> + power-supply: true
This is a new property not described in the commit msg.
> +
> + power-supply-needs-irq:
> + type: boolean
> + description:
> + A power-supply can link for example to a regulator controlled via
> + i2c or otherwise needing interrupts enabled to be able to enable and
> + disable.
Not really a property of power domain. How the regulator supply works is
entirely up to regulator. Otherwise such property should appear for
every device.
> This property makes various callbacks usually run in the
> + noirq phase, being run when interrupts are available.
Last sentence does not fit - you embed Linux implementation into DT
bindings. noirq phase is Linux specific.
> +
> required:
> - "#power-domain-cells"
>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-11 10:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 9:45 [PATCH v1 1/3] power: domain: handle power supplies that need irq Martin Kepplinger
2022-07-11 9:45 ` [PATCH v1 2/3] dt-binding: power: power-domain: add power-supply-needs-irq Martin Kepplinger
2022-07-11 10:38 ` Krzysztof Kozlowski [this message]
2022-07-11 13:17 ` Martin Kepplinger
2022-07-12 7:01 ` Krzysztof Kozlowski
2022-07-12 12:24 ` Martin Kepplinger
2022-07-11 9:45 ` [PATCH v1 3/3] arm64: dts: imx8mq-librem5: set pd power-supply-needs-irq when needed Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c68e4ae9-c435-c74e-91cd-b153be6de92f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aford173@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@puri.sm \
--cc=khilman@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).