linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] arm64: dts: rockchip: add vcc_cam regulator to rock-3a
@ 2022-07-12 13:32 Michael Riesch
  2022-07-12 13:32 ` [PATCH 2/3] arm64: dts: rockchip: add vcc_mipi " Michael Riesch
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Michael Riesch @ 2022-07-12 13:32 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
  Cc: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner, Michael Riesch

The Radxa ROCK3 Model A features a voltage regulator that provides
a 3V3 supply to the MIPI CSI connector. Add this regulator to the
device tree of the board.

Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
---
 .../boot/dts/rockchip/rk3568-rock-3a.dts      | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
index da2ef705ce29..821f9b96914b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
@@ -131,6 +131,22 @@ vcc5v0_usb_otg: vcc5v0-usb-otg-regulator {
 		regulator-max-microvolt = <5000000>;
 		vin-supply = <&vcc5v0_usb>;
 	};
+
+	vcc_cam: vcc-cam {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio1 RK_PB1 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&vcc_cam_en>;
+		regulator-name = "vcc_cam";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		vin-supply = <&vcc3v3_sys>;
+
+		regulator-state-mem {
+			regulator-off-in-suspend;
+		};
+	};
 };
 
 &combphy0 {
@@ -454,6 +470,12 @@ rgmii_phy1: ethernet-phy@0 {
 };
 
 &pinctrl {
+	cam {
+		vcc_cam_en: vcc_cam_en {
+			rockchip,pins = <1 RK_PB1 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
 	ethernet {
 		eth_phy_rst: eth_phy_rst {
 			rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] arm64: dts: rockchip: add vcc_mipi regulator to rock-3a
  2022-07-12 13:32 [PATCH 1/3] arm64: dts: rockchip: add vcc_cam regulator to rock-3a Michael Riesch
@ 2022-07-12 13:32 ` Michael Riesch
  2022-07-12 13:32 ` [PATCH 3/3] arm64: dts: rockchip: specify pinctrl for i2c adapters on rock-3a Michael Riesch
  2022-08-29 10:56 ` [PATCH 1/3] arm64: dts: rockchip: add vcc_cam regulator to rock-3a Heiko Stuebner
  2 siblings, 0 replies; 4+ messages in thread
From: Michael Riesch @ 2022-07-12 13:32 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
  Cc: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner, Michael Riesch

The Radxa ROCK3 Model A features a voltage regulator that provides
a 3V3 supply to the MIPI DSI connector. Add this regulator to the
device tree of the board.

Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
---
 .../boot/dts/rockchip/rk3568-rock-3a.dts      | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
index 821f9b96914b..33581a36c9c3 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
@@ -147,6 +147,22 @@ regulator-state-mem {
 			regulator-off-in-suspend;
 		};
 	};
+
+	vcc_mipi: vcc-mipi {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio3 RK_PC0 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&vcc_mipi_en>;
+		regulator-name = "vcc_mipi";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		vin-supply = <&vcc3v3_sys>;
+
+		regulator-state-mem {
+			regulator-off-in-suspend;
+		};
+	};
 };
 
 &combphy0 {
@@ -476,6 +492,12 @@ vcc_cam_en: vcc_cam_en {
 		};
 	};
 
+	display {
+		vcc_mipi_en: vcc_mipi_en {
+			rockchip,pins = <3 RK_PC0 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
 	ethernet {
 		eth_phy_rst: eth_phy_rst {
 			rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] arm64: dts: rockchip: specify pinctrl for i2c adapters on rock-3a
  2022-07-12 13:32 [PATCH 1/3] arm64: dts: rockchip: add vcc_cam regulator to rock-3a Michael Riesch
  2022-07-12 13:32 ` [PATCH 2/3] arm64: dts: rockchip: add vcc_mipi " Michael Riesch
@ 2022-07-12 13:32 ` Michael Riesch
  2022-08-29 10:56 ` [PATCH 1/3] arm64: dts: rockchip: add vcc_cam regulator to rock-3a Heiko Stuebner
  2 siblings, 0 replies; 4+ messages in thread
From: Michael Riesch @ 2022-07-12 13:32 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
  Cc: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner, Michael Riesch

On the Radxa ROCK3 Model A the I2C adapters related to the MIPI DSI
connector and the M.2/NGFF connector use the non-default pins.
Specify the correct pinctrl but leave the adapters disabled (as
they are supposed to be activated by overlays that describe the
external hardware).

Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
---
 arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
index 33581a36c9c3..8c533ee0c5c4 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
@@ -468,6 +468,18 @@ codec {
 	};
 };
 
+&i2c3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c3m1_xfer>;
+	status = "disabled";
+};
+
+&i2c4 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c4m1_xfer>;
+	status = "disabled";
+};
+
 &i2s1_8ch {
 	rockchip,trcm-sync-tx-only;
 	status = "okay";
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] arm64: dts: rockchip: add vcc_cam regulator to rock-3a
  2022-07-12 13:32 [PATCH 1/3] arm64: dts: rockchip: add vcc_cam regulator to rock-3a Michael Riesch
  2022-07-12 13:32 ` [PATCH 2/3] arm64: dts: rockchip: add vcc_mipi " Michael Riesch
  2022-07-12 13:32 ` [PATCH 3/3] arm64: dts: rockchip: specify pinctrl for i2c adapters on rock-3a Michael Riesch
@ 2022-08-29 10:56 ` Heiko Stuebner
  2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2022-08-29 10:56 UTC (permalink / raw)
  To: Michael Riesch, linux-arm-kernel, linux-kernel, linux-rockchip,
	devicetree
  Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski

On Tue, 12 Jul 2022 15:32:02 +0200, Michael Riesch wrote:
> The Radxa ROCK3 Model A features a voltage regulator that provides
> a 3V3 supply to the MIPI CSI connector. Add this regulator to the
> device tree of the board.

Applied, thanks!

[1/3] arm64: dts: rockchip: add vcc_cam regulator to rock-3a
      commit: 2fd8bd005897436c5a6d2d150d7b1ae2907f8b06
[2/3] arm64: dts: rockchip: add vcc_mipi regulator to rock-3a
      commit: 7a3eabdcd0fdc344d31b18e78e4f4b5d94db8df5
[3/3] arm64: dts: rockchip: specify pinctrl for i2c adapters on rock-3a
      commit: a233ea1e6268a779d5c8c427eb14a2a89f95f4f9

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-08-29 10:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-12 13:32 [PATCH 1/3] arm64: dts: rockchip: add vcc_cam regulator to rock-3a Michael Riesch
2022-07-12 13:32 ` [PATCH 2/3] arm64: dts: rockchip: add vcc_mipi " Michael Riesch
2022-07-12 13:32 ` [PATCH 3/3] arm64: dts: rockchip: specify pinctrl for i2c adapters on rock-3a Michael Riesch
2022-08-29 10:56 ` [PATCH 1/3] arm64: dts: rockchip: add vcc_cam regulator to rock-3a Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).