* [PATCH v4 1/2] dt-bindings: mfd: stm32-timers: Document how to specify interrupts
@ 2022-05-19 16:28 Uwe Kleine-König
2022-05-19 16:28 ` [PATCH v4 2/2] ARM: dts: stm32mp15x: Add timer interrupts Uwe Kleine-König
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Uwe Kleine-König @ 2022-05-19 16:28 UTC (permalink / raw)
To: Fabrice Gasnier, Alexandre Torgue, Rob Herring
Cc: devicetree, kernel, Maxime Coquelin, Lee Jones, linux-stm32,
linux-arm-kernel
The timer units in the stm32mp1 CPUs have interrupts, depending on the
timer flavour either one "global" or four dedicated ones. Document how
to formalize these in a device tree.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Changes since v3:
- Do the things Rob suggested in reqly to v1 which I didn't notice
until Fabrice told me in reply to v3.
.../devicetree/bindings/mfd/st,stm32-timers.yaml | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
index 10b330d42901..5b05b2ec1728 100644
--- a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
+++ b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
@@ -46,6 +46,21 @@ properties:
minItems: 1
maxItems: 7
+ interrupts:
+ oneOf:
+ - maxItems: 1
+ - maxItems: 4
+
+ interrupt-names:
+ oneOf:
+ - items:
+ - const: global
+ - items:
+ - const: brk
+ - const: up
+ - const: trg-com
+ - const: cc
+
"#address-cells":
const: 1
base-commit: 3123109284176b1532874591f7c81f3837bbdc17
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v4 2/2] ARM: dts: stm32mp15x: Add timer interrupts 2022-05-19 16:28 [PATCH v4 1/2] dt-bindings: mfd: stm32-timers: Document how to specify interrupts Uwe Kleine-König @ 2022-05-19 16:28 ` Uwe Kleine-König 2022-05-20 13:37 ` Fabrice Gasnier ` (2 more replies) 2022-05-20 13:37 ` [PATCH v4 1/2] dt-bindings: mfd: stm32-timers: Document how to specify interrupts Fabrice Gasnier ` (2 subsequent siblings) 3 siblings, 3 replies; 11+ messages in thread From: Uwe Kleine-König @ 2022-05-19 16:28 UTC (permalink / raw) To: Fabrice Gasnier, Alexandre Torgue, Rob Herring Cc: devicetree, kernel, Maxime Coquelin, Lee Jones, linux-stm32, linux-arm-kernel The timer units in the stm32mp15x CPUs have interrupts, depending on the timer flavour either one "global" or four dedicated ones. Add the irqs to the timer units on stm32mp15x. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- arch/arm/boot/dts/stm32mp151.dtsi | 34 +++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi index f9aa9af31efd..ae290a04771a 100644 --- a/arch/arm/boot/dts/stm32mp151.dtsi +++ b/arch/arm/boot/dts/stm32mp151.dtsi @@ -127,6 +127,8 @@ timers2: timer@40000000 { #size-cells = <0>; compatible = "st,stm32-timers"; reg = <0x40000000 0x400>; + interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "global"; clocks = <&rcc TIM2_K>; clock-names = "int"; dmas = <&dmamux1 18 0x400 0x1>, @@ -160,6 +162,8 @@ timers3: timer@40001000 { #size-cells = <0>; compatible = "st,stm32-timers"; reg = <0x40001000 0x400>; + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "global"; clocks = <&rcc TIM3_K>; clock-names = "int"; dmas = <&dmamux1 23 0x400 0x1>, @@ -194,6 +198,8 @@ timers4: timer@40002000 { #size-cells = <0>; compatible = "st,stm32-timers"; reg = <0x40002000 0x400>; + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "global"; clocks = <&rcc TIM4_K>; clock-names = "int"; dmas = <&dmamux1 29 0x400 0x1>, @@ -226,6 +232,8 @@ timers5: timer@40003000 { #size-cells = <0>; compatible = "st,stm32-timers"; reg = <0x40003000 0x400>; + interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "global"; clocks = <&rcc TIM5_K>; clock-names = "int"; dmas = <&dmamux1 55 0x400 0x1>, @@ -260,6 +268,8 @@ timers6: timer@40004000 { #size-cells = <0>; compatible = "st,stm32-timers"; reg = <0x40004000 0x400>; + interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "global"; clocks = <&rcc TIM6_K>; clock-names = "int"; dmas = <&dmamux1 69 0x400 0x1>; @@ -278,6 +288,8 @@ timers7: timer@40005000 { #size-cells = <0>; compatible = "st,stm32-timers"; reg = <0x40005000 0x400>; + interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "global"; clocks = <&rcc TIM7_K>; clock-names = "int"; dmas = <&dmamux1 70 0x400 0x1>; @@ -296,6 +308,8 @@ timers12: timer@40006000 { #size-cells = <0>; compatible = "st,stm32-timers"; reg = <0x40006000 0x400>; + interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "global"; clocks = <&rcc TIM12_K>; clock-names = "int"; status = "disabled"; @@ -318,6 +332,8 @@ timers13: timer@40007000 { #size-cells = <0>; compatible = "st,stm32-timers"; reg = <0x40007000 0x400>; + interrupts = <GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "global"; clocks = <&rcc TIM13_K>; clock-names = "int"; status = "disabled"; @@ -340,6 +356,8 @@ timers14: timer@40008000 { #size-cells = <0>; compatible = "st,stm32-timers"; reg = <0x40008000 0x400>; + interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "global"; clocks = <&rcc TIM14_K>; clock-names = "int"; status = "disabled"; @@ -623,6 +641,11 @@ timers1: timer@44000000 { #size-cells = <0>; compatible = "st,stm32-timers"; reg = <0x44000000 0x400>; + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "brk", "up", "trg-com", "cc"; clocks = <&rcc TIM1_K>; clock-names = "int"; dmas = <&dmamux1 11 0x400 0x1>, @@ -659,6 +682,11 @@ timers8: timer@44001000 { #size-cells = <0>; compatible = "st,stm32-timers"; reg = <0x44001000 0x400>; + interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "brk", "up", "trg-com", "cc"; clocks = <&rcc TIM8_K>; clock-names = "int"; dmas = <&dmamux1 47 0x400 0x1>, @@ -746,6 +774,8 @@ timers15: timer@44006000 { #size-cells = <0>; compatible = "st,stm32-timers"; reg = <0x44006000 0x400>; + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "global"; clocks = <&rcc TIM15_K>; clock-names = "int"; dmas = <&dmamux1 105 0x400 0x1>, @@ -773,6 +803,8 @@ timers16: timer@44007000 { #size-cells = <0>; compatible = "st,stm32-timers"; reg = <0x44007000 0x400>; + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "global"; clocks = <&rcc TIM16_K>; clock-names = "int"; dmas = <&dmamux1 109 0x400 0x1>, @@ -797,6 +829,8 @@ timers17: timer@44008000 { #size-cells = <0>; compatible = "st,stm32-timers"; reg = <0x44008000 0x400>; + interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "global"; clocks = <&rcc TIM17_K>; clock-names = "int"; dmas = <&dmamux1 111 0x400 0x1>, -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v4 2/2] ARM: dts: stm32mp15x: Add timer interrupts 2022-05-19 16:28 ` [PATCH v4 2/2] ARM: dts: stm32mp15x: Add timer interrupts Uwe Kleine-König @ 2022-05-20 13:37 ` Fabrice Gasnier 2022-07-20 7:18 ` Uwe Kleine-König 2022-08-26 8:17 ` Alexandre TORGUE 2 siblings, 0 replies; 11+ messages in thread From: Fabrice Gasnier @ 2022-05-20 13:37 UTC (permalink / raw) To: Uwe Kleine-König, Alexandre Torgue, Rob Herring Cc: devicetree, kernel, Maxime Coquelin, Lee Jones, linux-stm32, linux-arm-kernel On 5/19/22 18:28, Uwe Kleine-König wrote: > The timer units in the stm32mp15x CPUs have interrupts, depending on the > timer flavour either one "global" or four dedicated ones. Add the irqs > to the timer units on stm32mp15x. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Hi Uwe, You can add my: Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> Best Regards, Thanks Fabrice > --- > arch/arm/boot/dts/stm32mp151.dtsi | 34 +++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi > index f9aa9af31efd..ae290a04771a 100644 > --- a/arch/arm/boot/dts/stm32mp151.dtsi > +++ b/arch/arm/boot/dts/stm32mp151.dtsi > @@ -127,6 +127,8 @@ timers2: timer@40000000 { > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x40000000 0x400>; > + interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "global"; > clocks = <&rcc TIM2_K>; > clock-names = "int"; > dmas = <&dmamux1 18 0x400 0x1>, > @@ -160,6 +162,8 @@ timers3: timer@40001000 { > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x40001000 0x400>; > + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "global"; > clocks = <&rcc TIM3_K>; > clock-names = "int"; > dmas = <&dmamux1 23 0x400 0x1>, > @@ -194,6 +198,8 @@ timers4: timer@40002000 { > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x40002000 0x400>; > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "global"; > clocks = <&rcc TIM4_K>; > clock-names = "int"; > dmas = <&dmamux1 29 0x400 0x1>, > @@ -226,6 +232,8 @@ timers5: timer@40003000 { > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x40003000 0x400>; > + interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "global"; > clocks = <&rcc TIM5_K>; > clock-names = "int"; > dmas = <&dmamux1 55 0x400 0x1>, > @@ -260,6 +268,8 @@ timers6: timer@40004000 { > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x40004000 0x400>; > + interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "global"; > clocks = <&rcc TIM6_K>; > clock-names = "int"; > dmas = <&dmamux1 69 0x400 0x1>; > @@ -278,6 +288,8 @@ timers7: timer@40005000 { > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x40005000 0x400>; > + interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "global"; > clocks = <&rcc TIM7_K>; > clock-names = "int"; > dmas = <&dmamux1 70 0x400 0x1>; > @@ -296,6 +308,8 @@ timers12: timer@40006000 { > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x40006000 0x400>; > + interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "global"; > clocks = <&rcc TIM12_K>; > clock-names = "int"; > status = "disabled"; > @@ -318,6 +332,8 @@ timers13: timer@40007000 { > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x40007000 0x400>; > + interrupts = <GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "global"; > clocks = <&rcc TIM13_K>; > clock-names = "int"; > status = "disabled"; > @@ -340,6 +356,8 @@ timers14: timer@40008000 { > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x40008000 0x400>; > + interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "global"; > clocks = <&rcc TIM14_K>; > clock-names = "int"; > status = "disabled"; > @@ -623,6 +641,11 @@ timers1: timer@44000000 { > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x44000000 0x400>; > + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "brk", "up", "trg-com", "cc"; > clocks = <&rcc TIM1_K>; > clock-names = "int"; > dmas = <&dmamux1 11 0x400 0x1>, > @@ -659,6 +682,11 @@ timers8: timer@44001000 { > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x44001000 0x400>; > + interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "brk", "up", "trg-com", "cc"; > clocks = <&rcc TIM8_K>; > clock-names = "int"; > dmas = <&dmamux1 47 0x400 0x1>, > @@ -746,6 +774,8 @@ timers15: timer@44006000 { > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x44006000 0x400>; > + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "global"; > clocks = <&rcc TIM15_K>; > clock-names = "int"; > dmas = <&dmamux1 105 0x400 0x1>, > @@ -773,6 +803,8 @@ timers16: timer@44007000 { > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x44007000 0x400>; > + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "global"; > clocks = <&rcc TIM16_K>; > clock-names = "int"; > dmas = <&dmamux1 109 0x400 0x1>, > @@ -797,6 +829,8 @@ timers17: timer@44008000 { > #size-cells = <0>; > compatible = "st,stm32-timers"; > reg = <0x44008000 0x400>; > + interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "global"; > clocks = <&rcc TIM17_K>; > clock-names = "int"; > dmas = <&dmamux1 111 0x400 0x1>, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 2/2] ARM: dts: stm32mp15x: Add timer interrupts 2022-05-19 16:28 ` [PATCH v4 2/2] ARM: dts: stm32mp15x: Add timer interrupts Uwe Kleine-König 2022-05-20 13:37 ` Fabrice Gasnier @ 2022-07-20 7:18 ` Uwe Kleine-König 2022-08-01 8:44 ` Alexandre TORGUE 2022-08-26 8:17 ` Alexandre TORGUE 2 siblings, 1 reply; 11+ messages in thread From: Uwe Kleine-König @ 2022-07-20 7:18 UTC (permalink / raw) To: Fabrice Gasnier, Alexandre Torgue, Rob Herring Cc: devicetree, kernel, Maxime Coquelin, Lee Jones, linux-stm32, linux-arm-kernel [-- Attachment #1.1: Type: text/plain, Size: 663 bytes --] Hello, On Thu, May 19, 2022 at 06:28:38PM +0200, Uwe Kleine-König wrote: > The timer units in the stm32mp15x CPUs have interrupts, depending on the > timer flavour either one "global" or four dedicated ones. Add the irqs > to the timer units on stm32mp15x. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> This patch wasn't picked up yet (at least nobody told to have done it and it's not in next). Is there a problem other than no maintainer time? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 2/2] ARM: dts: stm32mp15x: Add timer interrupts 2022-07-20 7:18 ` Uwe Kleine-König @ 2022-08-01 8:44 ` Alexandre TORGUE 2022-08-01 9:53 ` Uwe Kleine-König 0 siblings, 1 reply; 11+ messages in thread From: Alexandre TORGUE @ 2022-08-01 8:44 UTC (permalink / raw) To: Uwe Kleine-König, Fabrice Gasnier, Rob Herring Cc: devicetree, kernel, Maxime Coquelin, Lee Jones, linux-stm32, linux-arm-kernel Hi Uwe On 7/20/22 09:18, Uwe Kleine-König wrote: > Hello, > > On Thu, May 19, 2022 at 06:28:38PM +0200, Uwe Kleine-König wrote: >> The timer units in the stm32mp15x CPUs have interrupts, depending on the >> timer flavour either one "global" or four dedicated ones. Add the irqs >> to the timer units on stm32mp15x. >> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > This patch wasn't picked up yet (at least nobody told to have done it > and it's not in next). Is there a problem other than no maintainer time? > > Best regards > Uwe > I was waiting for a review from Rob or Krzysztof on bindings patch [1]. Let me know if I missed it. Alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 2/2] ARM: dts: stm32mp15x: Add timer interrupts 2022-08-01 8:44 ` Alexandre TORGUE @ 2022-08-01 9:53 ` Uwe Kleine-König 2022-08-01 13:28 ` Alexandre TORGUE 0 siblings, 1 reply; 11+ messages in thread From: Uwe Kleine-König @ 2022-08-01 9:53 UTC (permalink / raw) To: Alexandre TORGUE Cc: Fabrice Gasnier, Rob Herring, devicetree, kernel, Maxime Coquelin, Lee Jones, linux-stm32, linux-arm-kernel [-- Attachment #1.1: Type: text/plain, Size: 1233 bytes --] On Mon, Aug 01, 2022 at 10:44:28AM +0200, Alexandre TORGUE wrote: > Hi Uwe > > On 7/20/22 09:18, Uwe Kleine-König wrote: > > Hello, > > > > On Thu, May 19, 2022 at 06:28:38PM +0200, Uwe Kleine-König wrote: > > > The timer units in the stm32mp15x CPUs have interrupts, depending on the > > > timer flavour either one "global" or four dedicated ones. Add the irqs > > > to the timer units on stm32mp15x. > > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > > This patch wasn't picked up yet (at least nobody told to have done it > > and it's not in next). Is there a problem other than no maintainer time? > > > > Best regards > > Uwe > > > > I was waiting for a review from Rob or Krzysztof on bindings patch [1]. Let > me know if I missed it. You did: Patch #1 was reviewed by Rob and taken by Lee, currently waiting in 'for-mfd-next' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git as 9875ab53c8ae ("dt-bindings: mfd: stm32-timers: Document how to specify interrupts"). Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 2/2] ARM: dts: stm32mp15x: Add timer interrupts 2022-08-01 9:53 ` Uwe Kleine-König @ 2022-08-01 13:28 ` Alexandre TORGUE 0 siblings, 0 replies; 11+ messages in thread From: Alexandre TORGUE @ 2022-08-01 13:28 UTC (permalink / raw) To: Uwe Kleine-König Cc: Fabrice Gasnier, Rob Herring, devicetree, kernel, Maxime Coquelin, Lee Jones, linux-stm32, linux-arm-kernel On 8/1/22 11:53, Uwe Kleine-König wrote: > On Mon, Aug 01, 2022 at 10:44:28AM +0200, Alexandre TORGUE wrote: >> Hi Uwe >> >> On 7/20/22 09:18, Uwe Kleine-König wrote: >>> Hello, >>> >>> On Thu, May 19, 2022 at 06:28:38PM +0200, Uwe Kleine-König wrote: >>>> The timer units in the stm32mp15x CPUs have interrupts, depending on the >>>> timer flavour either one "global" or four dedicated ones. Add the irqs >>>> to the timer units on stm32mp15x. >>>> >>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >>> >>> This patch wasn't picked up yet (at least nobody told to have done it >>> and it's not in next). Is there a problem other than no maintainer time? >>> >>> Best regards >>> Uwe >>> >> >> I was waiting for a review from Rob or Krzysztof on bindings patch [1]. Let >> me know if I missed it. > > You did: > > Patch #1 was reviewed by Rob and taken by Lee, currently waiting in > 'for-mfd-next' of > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git as > 9875ab53c8ae ("dt-bindings: mfd: stm32-timers: Document how to specify > interrupts"). Ok, my mistake. I'll apply it for v5.21. Cheers Alex > > Best regards > Uwe > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 2/2] ARM: dts: stm32mp15x: Add timer interrupts 2022-05-19 16:28 ` [PATCH v4 2/2] ARM: dts: stm32mp15x: Add timer interrupts Uwe Kleine-König 2022-05-20 13:37 ` Fabrice Gasnier 2022-07-20 7:18 ` Uwe Kleine-König @ 2022-08-26 8:17 ` Alexandre TORGUE 2 siblings, 0 replies; 11+ messages in thread From: Alexandre TORGUE @ 2022-08-26 8:17 UTC (permalink / raw) To: Uwe Kleine-König, Fabrice Gasnier, Rob Herring Cc: devicetree, kernel, Maxime Coquelin, Lee Jones, linux-stm32, linux-arm-kernel Hi Uwe On 5/19/22 18:28, Uwe Kleine-König wrote: > The timer units in the stm32mp15x CPUs have interrupts, depending on the > timer flavour either one "global" or four dedicated ones. Add the irqs > to the timer units on stm32mp15x. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > arch/arm/boot/dts/stm32mp151.dtsi | 34 +++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > Sorry for the delays. Applied on stm32-next. Thanks. Alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: mfd: stm32-timers: Document how to specify interrupts 2022-05-19 16:28 [PATCH v4 1/2] dt-bindings: mfd: stm32-timers: Document how to specify interrupts Uwe Kleine-König 2022-05-19 16:28 ` [PATCH v4 2/2] ARM: dts: stm32mp15x: Add timer interrupts Uwe Kleine-König @ 2022-05-20 13:37 ` Fabrice Gasnier 2022-06-01 21:11 ` Rob Herring 2022-06-15 22:01 ` Lee Jones 3 siblings, 0 replies; 11+ messages in thread From: Fabrice Gasnier @ 2022-05-20 13:37 UTC (permalink / raw) To: Uwe Kleine-König, Alexandre Torgue, Rob Herring Cc: devicetree, kernel, Maxime Coquelin, Lee Jones, linux-stm32, linux-arm-kernel On 5/19/22 18:28, Uwe Kleine-König wrote: > The timer units in the stm32mp1 CPUs have interrupts, depending on the > timer flavour either one "global" or four dedicated ones. Document how > to formalize these in a device tree. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Hi Uwe, You can add my: Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> Best Regards, Thanks Fabrice > --- > Changes since v3: > - Do the things Rob suggested in reqly to v1 which I didn't notice > until Fabrice told me in reply to v3. > > .../devicetree/bindings/mfd/st,stm32-timers.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml > index 10b330d42901..5b05b2ec1728 100644 > --- a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml > +++ b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml > @@ -46,6 +46,21 @@ properties: > minItems: 1 > maxItems: 7 > > + interrupts: > + oneOf: > + - maxItems: 1 > + - maxItems: 4 > + > + interrupt-names: > + oneOf: > + - items: > + - const: global > + - items: > + - const: brk > + - const: up > + - const: trg-com > + - const: cc > + > "#address-cells": > const: 1 > > > base-commit: 3123109284176b1532874591f7c81f3837bbdc17 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: mfd: stm32-timers: Document how to specify interrupts 2022-05-19 16:28 [PATCH v4 1/2] dt-bindings: mfd: stm32-timers: Document how to specify interrupts Uwe Kleine-König 2022-05-19 16:28 ` [PATCH v4 2/2] ARM: dts: stm32mp15x: Add timer interrupts Uwe Kleine-König 2022-05-20 13:37 ` [PATCH v4 1/2] dt-bindings: mfd: stm32-timers: Document how to specify interrupts Fabrice Gasnier @ 2022-06-01 21:11 ` Rob Herring 2022-06-15 22:01 ` Lee Jones 3 siblings, 0 replies; 11+ messages in thread From: Rob Herring @ 2022-06-01 21:11 UTC (permalink / raw) To: Uwe Kleine-König Cc: Lee Jones, Alexandre Torgue, Rob Herring, Maxime Coquelin, linux-arm-kernel, Fabrice Gasnier, devicetree, linux-stm32, kernel On Thu, 19 May 2022 18:28:37 +0200, Uwe Kleine-König wrote: > The timer units in the stm32mp1 CPUs have interrupts, depending on the > timer flavour either one "global" or four dedicated ones. Document how > to formalize these in a device tree. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Changes since v3: > - Do the things Rob suggested in reqly to v1 which I didn't notice > until Fabrice told me in reply to v3. > > .../devicetree/bindings/mfd/st,stm32-timers.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: mfd: stm32-timers: Document how to specify interrupts 2022-05-19 16:28 [PATCH v4 1/2] dt-bindings: mfd: stm32-timers: Document how to specify interrupts Uwe Kleine-König ` (2 preceding siblings ...) 2022-06-01 21:11 ` Rob Herring @ 2022-06-15 22:01 ` Lee Jones 3 siblings, 0 replies; 11+ messages in thread From: Lee Jones @ 2022-06-15 22:01 UTC (permalink / raw) To: Uwe Kleine-König Cc: Fabrice Gasnier, Alexandre Torgue, Rob Herring, devicetree, kernel, Maxime Coquelin, linux-stm32, linux-arm-kernel On Thu, 19 May 2022, Uwe Kleine-König wrote: > The timer units in the stm32mp1 CPUs have interrupts, depending on the > timer flavour either one "global" or four dedicated ones. Document how > to formalize these in a device tree. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Changes since v3: > - Do the things Rob suggested in reqly to v1 which I didn't notice > until Fabrice told me in reply to v3. > > .../devicetree/bindings/mfd/st,stm32-timers.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) Applied, thanks. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-08-26 8:18 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-05-19 16:28 [PATCH v4 1/2] dt-bindings: mfd: stm32-timers: Document how to specify interrupts Uwe Kleine-König 2022-05-19 16:28 ` [PATCH v4 2/2] ARM: dts: stm32mp15x: Add timer interrupts Uwe Kleine-König 2022-05-20 13:37 ` Fabrice Gasnier 2022-07-20 7:18 ` Uwe Kleine-König 2022-08-01 8:44 ` Alexandre TORGUE 2022-08-01 9:53 ` Uwe Kleine-König 2022-08-01 13:28 ` Alexandre TORGUE 2022-08-26 8:17 ` Alexandre TORGUE 2022-05-20 13:37 ` [PATCH v4 1/2] dt-bindings: mfd: stm32-timers: Document how to specify interrupts Fabrice Gasnier 2022-06-01 21:11 ` Rob Herring 2022-06-15 22:01 ` Lee Jones
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).