linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node
@ 2022-07-26 12:32 David Jander
  2022-07-26 12:32 ` [PATCH v2 1/2] " David Jander
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: David Jander @ 2022-07-26 12:32 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski
  Cc: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Oleksij Rempel,
	Fabio Estevam, NXP Linux Team, devicetree, linux-arm-kernel,
	linux-kernel, David Jander

This series adds the backlight-isb node and fixes existing backlight_led
node name.

---
v2:
 - Fix node names to use minus character instead of underscore.

David Jander (2):
  arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node
  arm: dts: imx6qdl-vicut1.dtsi: Fix node name backlight_led

 arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

-- 
2.32.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/2] arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node
  2022-07-26 12:32 [PATCH v2 0/2] arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node David Jander
@ 2022-07-26 12:32 ` David Jander
  2022-07-26 12:32 ` [PATCH v2 2/2] arm: dts: imx6qdl-vicut1.dtsi: Fix node name backlight_led David Jander
  2022-08-21 12:19 ` [PATCH v2 0/2] arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: David Jander @ 2022-07-26 12:32 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski
  Cc: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Oleksij Rempel,
	Fabio Estevam, NXP Linux Team, devicetree, linux-arm-kernel,
	linux-kernel, David Jander

On some older hardware models this is needed. It will do no harm if used
with newer models though.

Signed-off-by: David Jander <david@protonic.nl>
---
v2:
 - Fix node name to use minus character instead of underscore.
---
 arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
index a1676b5d2980..8a2512f3f378 100644
--- a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
@@ -37,6 +37,16 @@ backlight_led: backlight_led {
 		power-supply = <&reg_3v3>;
 	};
 
+	/* only for backwards compatibility with old HW */
+	backlight_isb: backlight-isb {
+		compatible = "pwm-backlight";
+		pwms = <&pwm2 0 5000000 0>;
+		brightness-levels = <0 8 48 255>;
+		num-interpolated-steps = <5>;
+		default-brightness-level = <0>;
+		power-supply = <&reg_3v3>;
+	};
+
 	connector {
 		compatible = "composite-video-connector";
 		label = "Composite0";
@@ -370,6 +380,12 @@ &pwm1 {
 	status = "okay";
 };
 
+&pwm2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_pwm2>;
+	status = "okay";
+};
+
 &pwm3 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_pwm3>;
@@ -601,6 +617,12 @@ MX6QDL_PAD_DISP0_DAT8__PWM1_OUT			0x1b0b0
 		>;
 	};
 
+	pinctrl_pwm2: pwm2grp {
+		fsl,pins = <
+			MX6QDL_PAD_DISP0_DAT9__PWM2_OUT			0x1b0b0
+		>;
+	};
+
 	pinctrl_pwm3: pwm3grp {
 		fsl,pins = <
 			MX6QDL_PAD_SD4_DAT1__PWM3_OUT			0x1b0b0
-- 
2.32.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] arm: dts: imx6qdl-vicut1.dtsi: Fix node name backlight_led
  2022-07-26 12:32 [PATCH v2 0/2] arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node David Jander
  2022-07-26 12:32 ` [PATCH v2 1/2] " David Jander
@ 2022-07-26 12:32 ` David Jander
  2022-08-21 12:19 ` [PATCH v2 0/2] arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: David Jander @ 2022-07-26 12:32 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski
  Cc: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Oleksij Rempel,
	Fabio Estevam, NXP Linux Team, devicetree, linux-arm-kernel,
	linux-kernel, David Jander

This naming error slipped through, so now that a new backlight node has
been added with correct spelling, fix this one also.

Fixes: 98efa526a0c4 ("ARM: dts: imx6qdl-vicut1/vicutgo: Add backlight_led node")
Signed-off-by: David Jander <david@protonic.nl>
---
v2:
 - new patch in series
---
 arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
index 8a2512f3f378..c4e6cf0527ba 100644
--- a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
@@ -28,7 +28,7 @@ backlight_lcd: backlight {
 		enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
 	};
 
-	backlight_led: backlight_led {
+	backlight_led: backlight-led {
 		compatible = "pwm-backlight";
 		pwms = <&pwm3 0 5000000 0>;
 		brightness-levels = <0 16 64 255>;
-- 
2.32.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 0/2] arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node
  2022-07-26 12:32 [PATCH v2 0/2] arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node David Jander
  2022-07-26 12:32 ` [PATCH v2 1/2] " David Jander
  2022-07-26 12:32 ` [PATCH v2 2/2] arm: dts: imx6qdl-vicut1.dtsi: Fix node name backlight_led David Jander
@ 2022-08-21 12:19 ` Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2022-08-21 12:19 UTC (permalink / raw)
  To: David Jander
  Cc: Rob Herring, Krzysztof Kozlowski, Sascha Hauer,
	Pengutronix Kernel Team, Oleksij Rempel, Fabio Estevam,
	NXP Linux Team, devicetree, linux-arm-kernel, linux-kernel

On Tue, Jul 26, 2022 at 02:32:20PM +0200, David Jander wrote:
> This series adds the backlight-isb node and fixes existing backlight_led
> node name.
> 
> ---
> v2:
>  - Fix node names to use minus character instead of underscore.
> 
> David Jander (2):
>   arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node
>   arm: dts: imx6qdl-vicut1.dtsi: Fix node name backlight_led

Applied both, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-08-21 12:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-26 12:32 [PATCH v2 0/2] arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node David Jander
2022-07-26 12:32 ` [PATCH v2 1/2] " David Jander
2022-07-26 12:32 ` [PATCH v2 2/2] arm: dts: imx6qdl-vicut1.dtsi: Fix node name backlight_led David Jander
2022-08-21 12:19 ` [PATCH v2 0/2] arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).