Re: [PATCH v7 4/4] PCI: endpoint: Add NTB MSI support

[kernel test robot <lkp@intel.com>]

Hi Frank,

I love your patch! Yet something to improve:

[auto build test ERROR on jonmason-ntb/ntb-next]
[also build test ERROR on robh/for-next linus/master v6.0-rc2 next-20220822]
[cannot apply to tip/irq/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Frank-Li/PCI-EP-driver-support-MSI-doorbell-from-host/20220822-235323
base:   https://github.com/jonmason/ntb ntb-next
config: microblaze-randconfig-r005-20220821 (https://download.01.org/0day-ci/archive/20220823/202208230543.fAaLXJy7-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/d98704aefa5b57814d7b9b1b40160df34977b2b6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Frank-Li/PCI-EP-driver-support-MSI-doorbell-from-host/20220822-235323
        git checkout d98704aefa5b57814d7b9b1b40160df34977b2b6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/pci/endpoint/functions/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/pci/endpoint/functions/pci-epf-vntb.c: In function 'epf_ntb_epc_msi_init':
>> drivers/pci/endpoint/functions/pci-epf-vntb.c:786:13: error: implicit declaration of function 'platform_msi_domain_alloc_irqs' [-Werror=implicit-function-declaration]
     786 |         if (platform_msi_domain_alloc_irqs(&ntb->epf->dev,
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/platform_msi_domain_alloc_irqs +786 drivers/pci/endpoint/functions/pci-epf-vntb.c

   771	
   772	static void epf_ntb_epc_msi_init(struct epf_ntb *ntb)
   773	{
   774		struct device *dev = &ntb->epf->dev;
   775		struct irq_domain *domain;
   776		int virq;
   777		int ret;
   778		int i;
   779	
   780		domain = dev_get_msi_domain(ntb->epf->epc->dev.parent);
   781		if (!domain)
   782			return;
   783	
   784		dev_set_msi_domain(dev, domain);
   785	
 > 786		if (platform_msi_domain_alloc_irqs(&ntb->epf->dev,
   787			ntb->db_count,
   788			epf_ntb_write_msi_msg)) {
   789			dev_info(dev, "Can't allocate MSI, fall back to poll mode\n");
   790			return;
   791		}
   792	
   793		dev_info(dev, "vntb use MSI as doorbell\n");
   794	
   795		for (i = 0; i < ntb->db_count; i++) {
   796			virq = msi_get_virq(dev, i);
   797			ret = devm_request_irq(dev, virq,
   798				       epf_ntb_interrupt_handler, 0,
   799				       "ntb", ntb);
   800	
   801			if (ret) {
   802				dev_err(dev, "devm_request_irq() failure, fall back to poll mode\n");
   803				ntb->epf_db_phy = 0;
   804				break;
   805			}
   806	
   807			if (!i)
   808				ntb->msi_virqbase = virq;
   809		}
   810	}
   811	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel