* [RESEND v4 0/3] clk: bcm: rpi: Add support for three more clocks
@ 2022-08-29 15:21 Ivan T. Ivanov
2022-08-29 15:21 ` [RESEND v4 1/3] clk: bcm: rpi: Add support HEVC clock Ivan T. Ivanov
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Ivan T. Ivanov @ 2022-08-29 15:21 UTC (permalink / raw)
To: Stephen Boyd
Cc: Stefan Wahren, Dave Stevenson, bcm-kernel-feedback-list,
linux-clk, linux-rpi-kernel, linux-arm-kernel, Guillaume Gardet,
Nicolas Saenz Julienne, Ivan T. Ivanov
Add missing clock required by RPiVid video decoder and provide more
reliable and accurate source for HDMI pixel and video encoder clocks.
Changes since v3
- Put back support for VEC clock, which was actually one of
reasons for this patch-set [1]. I mixed "HEVC" vs. "VEC", sorry.
[1] https://bugzilla.suse.com/show_bug.cgi?id=1198942
Changes since v2
- Added Acks from Maxime Ripard and Dave Stevenson
Changes since v1
- Drop RPI_FIRMWARE_VEC_CLK_ID clock it doesn't seems to be used.
- Rework downstream changes on top of recent Maxime changes.
Dom Cobley (1):
clk: bcm: rpi: Add support for VEC clock
Ivan T. Ivanov (2):
clk: bcm: rpi: Add support HEVC clock
clk: bcm: rpi: Handle pixel clock in firmware
drivers/clk/bcm/clk-raspberrypi.c | 11 +++++++++++
1 file changed, 11 insertions(+)
--
2.35.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [RESEND v4 1/3] clk: bcm: rpi: Add support HEVC clock
2022-08-29 15:21 [RESEND v4 0/3] clk: bcm: rpi: Add support for three more clocks Ivan T. Ivanov
@ 2022-08-29 15:21 ` Ivan T. Ivanov
2022-09-30 21:34 ` Stephen Boyd
2022-08-29 15:21 ` [RESEND v4 2/3] clk: bcm: rpi: Handle pixel clock in firmware Ivan T. Ivanov
2022-08-29 15:21 ` [RESEND v4 3/3] clk: bcm: rpi: Add support for VEC clock Ivan T. Ivanov
2 siblings, 1 reply; 7+ messages in thread
From: Ivan T. Ivanov @ 2022-08-29 15:21 UTC (permalink / raw)
To: Stephen Boyd
Cc: Stefan Wahren, Dave Stevenson, bcm-kernel-feedback-list,
linux-clk, linux-rpi-kernel, linux-arm-kernel, Guillaume Gardet,
Nicolas Saenz Julienne, Ivan T. Ivanov, Dom Cobley,
Maxime Ripard
Export clock required for RPiVid video decoder hardware.
Cc: Dom Cobley <popcornmix@gmail.com>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
---
drivers/clk/bcm/clk-raspberrypi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
index 73518009a0f2..8f560c6b602d 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
[RPI_FIRMWARE_V3D_CLK_ID] = {
.export = true,
},
+ [RPI_FIRMWARE_HEVC_CLK_ID] = {
+ .export = true,
+ },
[RPI_FIRMWARE_PIXEL_BVB_CLK_ID] = {
.export = true,
},
--
2.35.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [RESEND v4 2/3] clk: bcm: rpi: Handle pixel clock in firmware
2022-08-29 15:21 [RESEND v4 0/3] clk: bcm: rpi: Add support for three more clocks Ivan T. Ivanov
2022-08-29 15:21 ` [RESEND v4 1/3] clk: bcm: rpi: Add support HEVC clock Ivan T. Ivanov
@ 2022-08-29 15:21 ` Ivan T. Ivanov
2022-09-30 21:34 ` Stephen Boyd
2022-08-29 15:21 ` [RESEND v4 3/3] clk: bcm: rpi: Add support for VEC clock Ivan T. Ivanov
2 siblings, 1 reply; 7+ messages in thread
From: Ivan T. Ivanov @ 2022-08-29 15:21 UTC (permalink / raw)
To: Stephen Boyd
Cc: Stefan Wahren, Dave Stevenson, bcm-kernel-feedback-list,
linux-clk, linux-rpi-kernel, linux-arm-kernel, Guillaume Gardet,
Nicolas Saenz Julienne, Ivan T. Ivanov, Maxime Ripard
The clk-bcm2835 handling of the pixel clock does not function
correctly when the HDMI power domain is disabled.
The firmware supports it correctly, so add it to the
firmware clock driver.
Acked-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
---
drivers/clk/bcm/clk-raspberrypi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
index 8f560c6b602d..1248c0d64eae 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
[RPI_FIRMWARE_V3D_CLK_ID] = {
.export = true,
},
+ [RPI_FIRMWARE_PIXEL_CLK_ID] = {
+ .export = true,
+ },
[RPI_FIRMWARE_HEVC_CLK_ID] = {
.export = true,
},
--
2.35.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [RESEND v4 3/3] clk: bcm: rpi: Add support for VEC clock
2022-08-29 15:21 [RESEND v4 0/3] clk: bcm: rpi: Add support for three more clocks Ivan T. Ivanov
2022-08-29 15:21 ` [RESEND v4 1/3] clk: bcm: rpi: Add support HEVC clock Ivan T. Ivanov
2022-08-29 15:21 ` [RESEND v4 2/3] clk: bcm: rpi: Handle pixel clock in firmware Ivan T. Ivanov
@ 2022-08-29 15:21 ` Ivan T. Ivanov
2022-09-30 21:35 ` Stephen Boyd
2 siblings, 1 reply; 7+ messages in thread
From: Ivan T. Ivanov @ 2022-08-29 15:21 UTC (permalink / raw)
To: Stephen Boyd
Cc: Stefan Wahren, Dave Stevenson, bcm-kernel-feedback-list,
linux-clk, linux-rpi-kernel, linux-arm-kernel, Guillaume Gardet,
Nicolas Saenz Julienne, Dom Cobley, Ivan T . Ivanov
From: Dom Cobley <popcornmix@gmail.com>
Platform driver clk-bcm2835 gets an inaccurate clock for VEC (107MHz).
Export VEC clock trough clk-raspberrypi which uses the right PLL to
get an accurate 108MHz.
Signed-off-by: Dom Cobley <popcornmix@gmail.com>
[iivanov: Adapted on top of v5.17-rc6]
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
---
drivers/clk/bcm/clk-raspberrypi.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
index 1248c0d64eae..d70bb9283af7 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -33,6 +33,7 @@ enum rpi_firmware_clk_id {
RPI_FIRMWARE_EMMC2_CLK_ID,
RPI_FIRMWARE_M2MC_CLK_ID,
RPI_FIRMWARE_PIXEL_BVB_CLK_ID,
+ RPI_FIRMWARE_VEC_CLK_ID,
RPI_FIRMWARE_NUM_CLK_ID,
};
@@ -51,6 +52,7 @@ static char *rpi_firmware_clk_names[] = {
[RPI_FIRMWARE_EMMC2_CLK_ID] = "emmc2",
[RPI_FIRMWARE_M2MC_CLK_ID] = "m2mc",
[RPI_FIRMWARE_PIXEL_BVB_CLK_ID] = "pixel-bvb",
+ [RPI_FIRMWARE_VEC_CLK_ID] = "vec",
};
#define RPI_FIRMWARE_STATE_ENABLE_BIT BIT(0)
@@ -138,6 +140,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
[RPI_FIRMWARE_PIXEL_BVB_CLK_ID] = {
.export = true,
},
+ [RPI_FIRMWARE_VEC_CLK_ID] = {
+ .export = true,
+ },
};
/*
--
2.35.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [RESEND v4 1/3] clk: bcm: rpi: Add support HEVC clock
2022-08-29 15:21 ` [RESEND v4 1/3] clk: bcm: rpi: Add support HEVC clock Ivan T. Ivanov
@ 2022-09-30 21:34 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2022-09-30 21:34 UTC (permalink / raw)
To: Ivan T. Ivanov
Cc: Stefan Wahren, Dave Stevenson, bcm-kernel-feedback-list,
linux-clk, linux-rpi-kernel, linux-arm-kernel, Guillaume Gardet,
Nicolas Saenz Julienne, Ivan T. Ivanov, Dom Cobley,
Maxime Ripard
Quoting Ivan T. Ivanov (2022-08-29 08:21:52)
> Export clock required for RPiVid video decoder hardware.
>
> Cc: Dom Cobley <popcornmix@gmail.com>
> Acked-by: Maxime Ripard <maxime@cerno.tech>
> Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
> ---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND v4 2/3] clk: bcm: rpi: Handle pixel clock in firmware
2022-08-29 15:21 ` [RESEND v4 2/3] clk: bcm: rpi: Handle pixel clock in firmware Ivan T. Ivanov
@ 2022-09-30 21:34 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2022-09-30 21:34 UTC (permalink / raw)
To: Ivan T. Ivanov
Cc: Stefan Wahren, Dave Stevenson, bcm-kernel-feedback-list,
linux-clk, linux-rpi-kernel, linux-arm-kernel, Guillaume Gardet,
Nicolas Saenz Julienne, Ivan T. Ivanov, Maxime Ripard
Quoting Ivan T. Ivanov (2022-08-29 08:21:53)
> The clk-bcm2835 handling of the pixel clock does not function
> correctly when the HDMI power domain is disabled.
>
> The firmware supports it correctly, so add it to the
> firmware clock driver.
>
> Acked-by: Maxime Ripard <maxime@cerno.tech>
> Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
> ---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND v4 3/3] clk: bcm: rpi: Add support for VEC clock
2022-08-29 15:21 ` [RESEND v4 3/3] clk: bcm: rpi: Add support for VEC clock Ivan T. Ivanov
@ 2022-09-30 21:35 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2022-09-30 21:35 UTC (permalink / raw)
To: Ivan T. Ivanov
Cc: Stefan Wahren, Dave Stevenson, bcm-kernel-feedback-list,
linux-clk, linux-rpi-kernel, linux-arm-kernel, Guillaume Gardet,
Nicolas Saenz Julienne, Dom Cobley, Ivan T . Ivanov
Quoting Ivan T. Ivanov (2022-08-29 08:21:54)
> From: Dom Cobley <popcornmix@gmail.com>
>
> Platform driver clk-bcm2835 gets an inaccurate clock for VEC (107MHz).
> Export VEC clock trough clk-raspberrypi which uses the right PLL to
> get an accurate 108MHz.
>
> Signed-off-by: Dom Cobley <popcornmix@gmail.com>
> [iivanov: Adapted on top of v5.17-rc6]
> Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
> ---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-30 21:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29 15:21 [RESEND v4 0/3] clk: bcm: rpi: Add support for three more clocks Ivan T. Ivanov
2022-08-29 15:21 ` [RESEND v4 1/3] clk: bcm: rpi: Add support HEVC clock Ivan T. Ivanov
2022-09-30 21:34 ` Stephen Boyd
2022-08-29 15:21 ` [RESEND v4 2/3] clk: bcm: rpi: Handle pixel clock in firmware Ivan T. Ivanov
2022-09-30 21:34 ` Stephen Boyd
2022-08-29 15:21 ` [RESEND v4 3/3] clk: bcm: rpi: Add support for VEC clock Ivan T. Ivanov
2022-09-30 21:35 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).