Re: linux-next: build warnings after merge of the broadcom tree

Re: linux-next: build warnings after merge of the broadcom tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 2250 bytes --]

Hi all,

On Mon, 25 Jul 2022 12:33:48 +0200 Rafał Miłecki <rafal@milecki.pl> wrote:
>
> On 25.07.2022 01:59, Stephen Rothwell wrote:
> > After merging the broadcom tree, today's linux-next build (arm
> > multi_v7_defconfig) produced these warnings:
> > 
> > arch/arm/boot/dts/bcm5301x.dtsi:240.21-246.5: Warning (pci_bridge): /axi@18000000/pcie@12000: missing ranges for PCI bridge (or not a bridge)
> > arch/arm/boot/dts/bcm5301x.dtsi:248.21-254.5: Warning (pci_bridge): /axi@18000000/pcie@13000: missing ranges for PCI bridge (or not a bridge)
> > arch/arm/boot/dts/bcm5301x.dtsi:256.21-262.5: Warning (pci_bridge): /axi@18000000/pcie@14000: missing ranges for PCI bridge (or not a bridge)  
> 
> This is expected. My commit ef126d3f58d25 ("ARM: dts: BCM5301X: Add
> basic PCI controller properties") reduced following warnings:
> 
> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'device_type' is a required property
>          From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'ranges' is a required property
>          From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#address-cells' is a required property
>          From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#size-cells' is a required property
>          From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> 
> 
> down to this one:
> 
> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'ranges' is a required property
>          From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> 
> 
> and basically does the right thing (adds required properties).
> 
> 
> I'm fully aware "ranges" need to be added (it's mentioned in the commit)
> and it's one of next things on my BCM5301X list.
> 
> So while my commits triggers that problem it also reduces warnings so
> I'd say it's acceptable.

So, is something being done about these introduced warnings?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: linux-next: build warnings after merge of the broadcom tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 2670 bytes --]

Hi all,

On Mon, 15 Aug 2022 10:54:19 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Mon, 25 Jul 2022 12:33:48 +0200 Rafał Miłecki <rafal@milecki.pl> wrote:
> >
> > On 25.07.2022 01:59, Stephen Rothwell wrote:  
> > > After merging the broadcom tree, today's linux-next build (arm
> > > multi_v7_defconfig) produced these warnings:
> > > 
> > > arch/arm/boot/dts/bcm5301x.dtsi:240.21-246.5: Warning (pci_bridge): /axi@18000000/pcie@12000: missing ranges for PCI bridge (or not a bridge)
> > > arch/arm/boot/dts/bcm5301x.dtsi:248.21-254.5: Warning (pci_bridge): /axi@18000000/pcie@13000: missing ranges for PCI bridge (or not a bridge)
> > > arch/arm/boot/dts/bcm5301x.dtsi:256.21-262.5: Warning (pci_bridge): /axi@18000000/pcie@14000: missing ranges for PCI bridge (or not a bridge)    
> > 
> > This is expected. My commit ef126d3f58d25 ("ARM: dts: BCM5301X: Add
> > basic PCI controller properties") reduced following warnings:
> > 
> > arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'device_type' is a required property
> >          From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> > arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'ranges' is a required property
> >          From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> > arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#address-cells' is a required property
> >          From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> > arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#size-cells' is a required property
> >          From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> > 
> > 
> > down to this one:
> > 
> > arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'ranges' is a required property
> >          From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> > 
> > 
> > and basically does the right thing (adds required properties).
> > 
> > 
> > I'm fully aware "ranges" need to be added (it's mentioned in the commit)
> > and it's one of next things on my BCM5301X list.
> > 
> > So while my commits triggers that problem it also reduces warnings so
> > I'd say it's acceptable.

Not from my point of view:  I was not getting any warnings and now I am
getting 254 lines of warnings :-(
  
> So, is something being done about these introduced warnings?

I am still seeing these warnings.

The above commit is now

  61dc1e3850a6 ("ARM: dts: BCM5301X: Add basic PCI controller properties")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: linux-next: build warnings after merge of the broadcom tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 2950 bytes --]

Hi all,

On Wed, 31 Aug 2022 09:16:54 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> On Mon, 15 Aug 2022 10:54:19 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Mon, 25 Jul 2022 12:33:48 +0200 Rafał Miłecki <rafal@milecki.pl> wrote:  
> > >
> > > On 25.07.2022 01:59, Stephen Rothwell wrote:    
> > > > After merging the broadcom tree, today's linux-next build (arm
> > > > multi_v7_defconfig) produced these warnings:
> > > > 
> > > > arch/arm/boot/dts/bcm5301x.dtsi:240.21-246.5: Warning (pci_bridge): /axi@18000000/pcie@12000: missing ranges for PCI bridge (or not a bridge)
> > > > arch/arm/boot/dts/bcm5301x.dtsi:248.21-254.5: Warning (pci_bridge): /axi@18000000/pcie@13000: missing ranges for PCI bridge (or not a bridge)
> > > > arch/arm/boot/dts/bcm5301x.dtsi:256.21-262.5: Warning (pci_bridge): /axi@18000000/pcie@14000: missing ranges for PCI bridge (or not a bridge)      
> > > 
> > > This is expected. My commit ef126d3f58d25 ("ARM: dts: BCM5301X: Add
> > > basic PCI controller properties") reduced following warnings:
> > > 
> > > arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'device_type' is a required property
> > >          From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> > > arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'ranges' is a required property
> > >          From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> > > arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#address-cells' is a required property
> > >          From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> > > arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#size-cells' is a required property
> > >          From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> > > 
> > > 
> > > down to this one:
> > > 
> > > arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'ranges' is a required property
> > >          From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> > > 
> > > 
> > > and basically does the right thing (adds required properties).
> > > 
> > > 
> > > I'm fully aware "ranges" need to be added (it's mentioned in the commit)
> > > and it's one of next things on my BCM5301X list.
> > > 
> > > So while my commits triggers that problem it also reduces warnings so
> > > I'd say it's acceptable.  
> 
> Not from my point of view:  I was not getting any warnings and now I am
> getting 254 lines of warnings :-(
>   
> > So, is something being done about these introduced warnings?  
> 
> I am still seeing these warnings.
> 
> The above commit is now
> 
>   61dc1e3850a6 ("ARM: dts: BCM5301X: Add basic PCI controller properties")

Has any progress been made with this?  This commit is now in the
arm-soc tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: linux-next: build warnings after merge of the broadcom tree

[Florian Fainelli]

On 10/4/2022 5:48 PM, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 31 Aug 2022 09:16:54 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> On Mon, 15 Aug 2022 10:54:19 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>
>>> On Mon, 25 Jul 2022 12:33:48 +0200 Rafał Miłecki <rafal@milecki.pl> wrote:
>>>>
>>>> On 25.07.2022 01:59, Stephen Rothwell wrote:
>>>>> After merging the broadcom tree, today's linux-next build (arm
>>>>> multi_v7_defconfig) produced these warnings:
>>>>>
>>>>> arch/arm/boot/dts/bcm5301x.dtsi:240.21-246.5: Warning (pci_bridge): /axi@18000000/pcie@12000: missing ranges for PCI bridge (or not a bridge)
>>>>> arch/arm/boot/dts/bcm5301x.dtsi:248.21-254.5: Warning (pci_bridge): /axi@18000000/pcie@13000: missing ranges for PCI bridge (or not a bridge)
>>>>> arch/arm/boot/dts/bcm5301x.dtsi:256.21-262.5: Warning (pci_bridge): /axi@18000000/pcie@14000: missing ranges for PCI bridge (or not a bridge)
>>>>
>>>> This is expected. My commit ef126d3f58d25 ("ARM: dts: BCM5301X: Add
>>>> basic PCI controller properties") reduced following warnings:
>>>>
>>>> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'device_type' is a required property
>>>>           From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>>>> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'ranges' is a required property
>>>>           From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>>>> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#address-cells' is a required property
>>>>           From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>>>> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#size-cells' is a required property
>>>>           From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>>>>
>>>>
>>>> down to this one:
>>>>
>>>> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'ranges' is a required property
>>>>           From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>>>>
>>>>
>>>> and basically does the right thing (adds required properties).
>>>>
>>>>
>>>> I'm fully aware "ranges" need to be added (it's mentioned in the commit)
>>>> and it's one of next things on my BCM5301X list.
>>>>
>>>> So while my commits triggers that problem it also reduces warnings so
>>>> I'd say it's acceptable.
>>
>> Not from my point of view:  I was not getting any warnings and now I am
>> getting 254 lines of warnings :-(
>>    
>>> So, is something being done about these introduced warnings?
>>
>> I am still seeing these warnings.
>>
>> The above commit is now
>>
>>    61dc1e3850a6 ("ARM: dts: BCM5301X: Add basic PCI controller properties")
> 
> Has any progress been made with this?  This commit is now in the
> arm-soc tree.

Yes, I was hoping to get some feedback on this patch:

https://lore.kernel.org/all/20220920210213.3268525-1-f.fainelli@gmail.com/

but I suppose being the ARM SoC maintainer I can just go ahead and push it.
-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: linux-next: build warnings after merge of the broadcom tree

[Joel Stanley]

On Wed, 5 Oct 2022 at 03:01, Florian Fainelli <f.fainelli@gmail.com> wrote:
> >> I am still seeing these warnings.
> >>
> >> The above commit is now
> >>
> >>    61dc1e3850a6 ("ARM: dts: BCM5301X: Add basic PCI controller properties")
> >
> > Has any progress been made with this?  This commit is now in the
> > arm-soc tree.
>
> Yes, I was hoping to get some feedback on this patch:
>
> https://lore.kernel.org/all/20220920210213.3268525-1-f.fainelli@gmail.com/
>
> but I suppose being the ARM SoC maintainer I can just go ahead and push it.

I'd send a revert of the change. Rafal can then re-submit a series
that fixes the dtc warnings as well as the yaml warning once they have
been tested and reviewed.

The yaml warnings aren't seen by other developers, as they require the
tools to be installed, but those from dtc are.

Cheers,

Joel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: linux-next: build warnings after merge of the broadcom tree

[Arnd Bergmann]

On Wed, Oct 5, 2022, at 8:02 AM, Joel Stanley wrote:
> On Wed, 5 Oct 2022 at 03:01, Florian Fainelli <f.fainelli@gmail.com> wrote:
>> >> I am still seeing these warnings.
>> >>
>> >> The above commit is now
>> >>
>> >>    61dc1e3850a6 ("ARM: dts: BCM5301X: Add basic PCI controller properties")
>> >
>> > Has any progress been made with this?  This commit is now in the
>> > arm-soc tree.
>>
>> Yes, I was hoping to get some feedback on this patch:
>>
>> https://lore.kernel.org/all/20220920210213.3268525-1-f.fainelli@gmail.com/
>>
>> but I suppose being the ARM SoC maintainer I can just go ahead and push it.

Sorry, I unfortunately missed this patch, and forgot about the
original issue.

> I'd send a revert of the change. Rafal can then re-submit a series
> that fixes the dtc warnings as well as the yaml warning once they have
> been tested and reviewed.
>
> The yaml warnings aren't seen by other developers, as they require the
> tools to be installed, but those from dtc are.

Agreed. Alternatively, we could just remove the pcie@ nodes from
bcm5301x as a hotfix, as they are clearly not usable in the
current form, and none of the three versions (5.19, Rafał's
patch missing ranges, and Florian's patch with incorrect ranges)
actually conform to the binding.

I'll tentatively apply the revert for now so I can send the pull
request tonight. If someone comes up with a better fix, I can
use that instead.

     Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: linux-next: build warnings after merge of the broadcom tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 678 bytes --]

Hi Arnd,

On Wed, 05 Oct 2022 09:21:21 +0200 "Arnd Bergmann" <arnd@arndb.de> wrote:
>
> Agreed. Alternatively, we could just remove the pcie@ nodes from
> bcm5301x as a hotfix, as they are clearly not usable in the
> current form, and none of the three versions (5.19, Rafał's
> patch missing ranges, and Florian's patch with incorrect ranges)
> actually conform to the binding.
> 
> I'll tentatively apply the revert for now so I can send the pull
> request tonight. If someone comes up with a better fix, I can
> use that instead.

I applied the revert to the merge of the arm-soc tree today and *all*
the warnings are gone.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: linux-next: build warnings after merge of the broadcom tree

[Rafał Miłecki]

On 2022-10-06 02:17, Stephen Rothwell wrote:
> On Wed, 05 Oct 2022 09:21:21 +0200 "Arnd Bergmann" <arnd@arndb.de> 
> wrote:
>> 
>> Agreed. Alternatively, we could just remove the pcie@ nodes from
>> bcm5301x as a hotfix, as they are clearly not usable in the
>> current form, and none of the three versions (5.19, Rafał's
>> patch missing ranges, and Florian's patch with incorrect ranges)
>> actually conform to the binding.
>> 
>> I'll tentatively apply the revert for now so I can send the pull
>> request tonight. If someone comes up with a better fix, I can
>> use that instead.
> 
> I applied the revert to the merge of the arm-soc tree today and *all*
> the warnings are gone.

As explained by Joel, there are dtc and yaml warnings.

Not "*all*" warnings are gone
dtc warnings are gone
yaml warnings are back

Which may be OK, just clarifying.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: linux-next: build warnings after merge of the broadcom tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 1288 bytes --]

Hi Rafał,

On Thu, 06 Oct 2022 07:14:05 +0200 Rafał Miłecki <rafal@milecki.pl> wrote:
>
> On 2022-10-06 02:17, Stephen Rothwell wrote:
> > On Wed, 05 Oct 2022 09:21:21 +0200 "Arnd Bergmann" <arnd@arndb.de> > wrote:  
> >> >> Agreed. Alternatively, we could just remove the pcie@ nodes from  
> >> bcm5301x as a hotfix, as they are clearly not usable in the
> >> current form, and none of the three versions (5.19, Rafał's
> >> patch missing ranges, and Florian's patch with incorrect ranges)
> >> actually conform to the binding.  
> >> >> I'll tentatively apply the revert for now so I can send the pull  
> >> request tonight. If someone comes up with a better fix, I can
> >> use that instead.  
> > 
> > I applied the revert to the merge of the arm-soc tree today and *all*
> > the warnings are gone.  
> 
> As explained by Joel, there are dtc and yaml warnings.
> 
> Not "*all*" warnings are gone
> dtc warnings are gone
> yaml warnings are back
> 
> Which may be OK, just clarifying.

Ah, OK, now I see.  The build I do (arm multi_v7_defconfig) does not
produce the yaml warnings (for me anyway - maybe I have not installed
some optional build tool?), so I never saw them - all I saw was all the
new dtc warnings.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel