From: Francesco Dolcini <francesco.dolcini@toradex.com>
To: Mark Brown <broonie@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Max Krummenacher <max.oss.09@gmail.com>
Cc: Max Krummenacher <max.krummenacher@toradex.com>,
Fabio Estevam <festevam@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Philippe Schenker <philippe.schenker@toradex.com>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] arm64: dts: imx8mp-verdin: board regulators: add always-on
Date: Fri, 2 Sep 2022 14:50:40 +0200 [thread overview]
Message-ID: <20220902125040.GA5699@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <YxD9m7sELdTUFFZ3@sirena.org.uk>
On Thu, Sep 01, 2022 at 07:44:43PM +0100, Mark Brown wrote:
> On Thu, Sep 01, 2022 at 09:29:13PM +0300, Laurent Pinchart wrote:
> > On Thu, Sep 01, 2022 at 01:04:22PM +0200, Max Krummenacher wrote:
> > > From: Max Krummenacher <max.krummenacher@toradex.com>
>
> > > These regulators are switched on by HW during power up and can not
> > > be influenced by SW.
> > > Set the always-on property.
> >
> > Is this needed ? When a fixed regulator has no control GPIO or clock, as
> > is the case here, I would expect the driver and/or regulator core to
> > understand that it's always on, as the alternative is always-off, which
> > is pointless :-) Mark, Liam, what do you think ?
>
> If there's no physical control setting always-on does nothing.
The patch was posted because of a warning on trying to disable an unused
regulator.
However this was changed with
261f06315cf7 ("regulator: Flag uncontrollable regulators as always_on").
Max was testing with a kernel without this patch in and forgot to verify
on latest upstream kernel.
Just disregard this.
Francesco
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-09-02 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 11:04 [PATCH] arm64: dts: imx8mp-verdin: board regulators: add always-on Max Krummenacher
2022-09-01 18:29 ` Laurent Pinchart
2022-09-01 18:44 ` Mark Brown
2022-09-02 12:50 ` Francesco Dolcini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902125040.GA5699@francesco-nb.int.toradex.com \
--to=francesco.dolcini@toradex.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=max.krummenacher@toradex.com \
--cc=max.oss.09@gmail.com \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).