From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Max Krummenacher <max.oss.09@gmail.com>
Cc: Max Krummenacher <max.krummenacher@toradex.com>,
Fabio Estevam <festevam@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Philippe Schenker <philippe.schenker@toradex.com>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] arm64: dts: imx8mp-verdin: board regulators: add always-on
Date: Thu, 1 Sep 2022 21:29:13 +0300 [thread overview]
Message-ID: <YxD5+RCYtzcxEdjj@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220901110422.1859621-1-max.oss.09@gmail.com>
Hi Max,
(CC'ing Mark and Liam)
Thank you for the patch.
On Thu, Sep 01, 2022 at 01:04:22PM +0200, Max Krummenacher wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
>
> These regulators are switched on by HW during power up and can not
> be influenced by SW.
> Set the always-on property.
Is this needed ? When a fixed regulator has no control GPIO or clock, as
is the case here, I would expect the driver and/or regulator core to
understand that it's always on, as the alternative is always-off, which
is pointless :-) Mark, Liam, what do you think ?
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
>
> ---
>
> arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> index 557cfef8f049..76cc89296150 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -62,6 +62,7 @@ button-wakeup {
> /* Carrier Board Supplies */
> reg_1p8v: regulator-1p8v {
> compatible = "regulator-fixed";
> + regulator-always-on;
> regulator-max-microvolt = <1800000>;
> regulator-min-microvolt = <1800000>;
> regulator-name = "+V1.8_SW";
> @@ -69,6 +70,7 @@ reg_1p8v: regulator-1p8v {
>
> reg_3p3v: regulator-3p3v {
> compatible = "regulator-fixed";
> + regulator-always-on;
> regulator-max-microvolt = <3300000>;
> regulator-min-microvolt = <3300000>;
> regulator-name = "+V3.3_SW";
> @@ -76,6 +78,7 @@ reg_3p3v: regulator-3p3v {
>
> reg_5p0v: regulator-5p0v {
> compatible = "regulator-fixed";
> + regulator-always-on;
> regulator-max-microvolt = <5000000>;
> regulator-min-microvolt = <5000000>;
> regulator-name = "+V5_SW";
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-01 18:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 11:04 [PATCH] arm64: dts: imx8mp-verdin: board regulators: add always-on Max Krummenacher
2022-09-01 18:29 ` Laurent Pinchart [this message]
2022-09-01 18:44 ` Mark Brown
2022-09-02 12:50 ` Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxD5+RCYtzcxEdjj@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=max.krummenacher@toradex.com \
--cc=max.oss.09@gmail.com \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).