linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/5] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity
@ 2022-09-12 18:08 Tim Harvey
  2022-09-12 18:08 ` [PATCH v2 2/5] arm64: dts: imx8mp-venice-gw74xx: fix ksz9477 cpu port Tim Harvey
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Tim Harvey @ 2022-09-12 18:08 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel, devicetree
  Cc: NXP Linux Team, Fabio Estevam, Pengutronix Kernel Team,
	Sascha Hauer, Shawn Guo, Krzysztof Kozlowski, Rob Herring,
	Tim Harvey

The CAN STBY poarlity is active-low. Specify it as such by removing the
'enable-active-high' property and updating the gpio property.

Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts support")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
v2: remove invalid 'enable-active-low' prop
---
 arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index 6630ec561dc2..4c729ac89625 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -123,8 +123,7 @@ reg_can2_stby: regulator-can2-stby {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_reg_can>;
 		regulator-name = "can2_stby";
-		gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>;
-		enable-active-high;
+		gpio = <&gpio3 19 GPIO_ACTIVE_LOW>;
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 	};
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 2/5] arm64: dts: imx8mp-venice-gw74xx: fix ksz9477 cpu port
  2022-09-12 18:08 [PATCH v2 1/5] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity Tim Harvey
@ 2022-09-12 18:08 ` Tim Harvey
  2022-09-12 18:08 ` [PATCH v2 3/5] arm64: dts: imx8mp-venice-gw74xx: fix port/phy validation Tim Harvey
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Tim Harvey @ 2022-09-12 18:08 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel, devicetree
  Cc: NXP Linux Team, Fabio Estevam, Pengutronix Kernel Team,
	Sascha Hauer, Shawn Guo, Krzysztof Kozlowski, Rob Herring,
	Tim Harvey

The CPU uplink port on the KSZ9477 is P5 not P6 - fix this.

Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts support")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
v2: no changes
---
 arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index 4c729ac89625..3df7ee9a2fe1 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -510,8 +510,8 @@ lan5: port@4 {
 				local-mac-address = [00 00 00 00 00 00];
 			};
 
-			port@6 {
-				reg = <6>;
+			port@5 {
+				reg = <5>;
 				label = "cpu";
 				ethernet = <&fec>;
 				phy-mode = "rgmii-id";
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 3/5] arm64: dts: imx8mp-venice-gw74xx: fix port/phy validation
  2022-09-12 18:08 [PATCH v2 1/5] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity Tim Harvey
  2022-09-12 18:08 ` [PATCH v2 2/5] arm64: dts: imx8mp-venice-gw74xx: fix ksz9477 cpu port Tim Harvey
@ 2022-09-12 18:08 ` Tim Harvey
  2022-09-12 18:08 ` [PATCH v2 4/5] arm64: dts: imx8mp-venice-gw74xx: add cpu-supply node for cpufreq Tim Harvey
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Tim Harvey @ 2022-09-12 18:08 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel, devicetree
  Cc: NXP Linux Team, Fabio Estevam, Pengutronix Kernel Team,
	Sascha Hauer, Shawn Guo, Krzysztof Kozlowski, Rob Herring,
	Tim Harvey

Since commit 65ac79e18120 ("net: dsa: microchip: add the phylink
get_caps") the phy-mode must be set otherwise the switch driver will
assume "NA" mode and invalidate the port.

Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400
dts support")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
v2: no changes
---
 arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index 3df7ee9a2fe1..211e6a1b296e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -483,30 +483,35 @@ ports {
 			lan1: port@0 {
 				reg = <0>;
 				label = "lan1";
+				phy-mode = "internal";
 				local-mac-address = [00 00 00 00 00 00];
 			};
 
 			lan2: port@1 {
 				reg = <1>;
 				label = "lan2";
+				phy-mode = "internal";
 				local-mac-address = [00 00 00 00 00 00];
 			};
 
 			lan3: port@2 {
 				reg = <2>;
 				label = "lan3";
+				phy-mode = "internal";
 				local-mac-address = [00 00 00 00 00 00];
 			};
 
 			lan4: port@3 {
 				reg = <3>;
 				label = "lan4";
+				phy-mode = "internal";
 				local-mac-address = [00 00 00 00 00 00];
 			};
 
 			lan5: port@4 {
 				reg = <4>;
 				label = "lan5";
+				phy-mode = "internal";
 				local-mac-address = [00 00 00 00 00 00];
 			};
 
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 4/5] arm64: dts: imx8mp-venice-gw74xx: add cpu-supply node for cpufreq
  2022-09-12 18:08 [PATCH v2 1/5] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity Tim Harvey
  2022-09-12 18:08 ` [PATCH v2 2/5] arm64: dts: imx8mp-venice-gw74xx: fix ksz9477 cpu port Tim Harvey
  2022-09-12 18:08 ` [PATCH v2 3/5] arm64: dts: imx8mp-venice-gw74xx: fix port/phy validation Tim Harvey
@ 2022-09-12 18:08 ` Tim Harvey
  2022-09-12 18:08 ` [PATCH v2 5/5] arm64: dts: imx8mp-venice-gw74xx: add WiFi/BT module support Tim Harvey
  2022-09-13  2:24 ` [PATCH v2 1/5] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity Shawn Guo
  4 siblings, 0 replies; 6+ messages in thread
From: Tim Harvey @ 2022-09-12 18:08 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel, devicetree
  Cc: NXP Linux Team, Fabio Estevam, Pengutronix Kernel Team,
	Sascha Hauer, Shawn Guo, Krzysztof Kozlowski, Rob Herring,
	Tim Harvey

Add regulator config for cpu-supply in order to support cpufreq.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
v2: no changes
---
 .../dts/freescale/imx8mp-venice-gw74xx.dts     | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index 211e6a1b296e..066a4afaf8a1 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -141,6 +141,22 @@ reg_wifi_en: regulator-wifi-en {
 	};
 };
 
+&A53_0 {
+	cpu-supply = <&reg_arm>;
+};
+
+&A53_1 {
+	cpu-supply = <&reg_arm>;
+};
+
+&A53_2 {
+	cpu-supply = <&reg_arm>;
+};
+
+&A53_3 {
+	cpu-supply = <&reg_arm>;
+};
+
 /* off-board header */
 &ecspi2 {
 	pinctrl-names = "default";
@@ -361,7 +377,7 @@ BUCK1 {
 				regulator-ramp-delay = <3125>;
 			};
 
-			BUCK2 {
+			reg_arm: BUCK2 {
 				regulator-name = "BUCK2";
 				regulator-min-microvolt = <720000>;
 				regulator-max-microvolt = <1025000>;
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 5/5] arm64: dts: imx8mp-venice-gw74xx: add WiFi/BT module support
  2022-09-12 18:08 [PATCH v2 1/5] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity Tim Harvey
                   ` (2 preceding siblings ...)
  2022-09-12 18:08 ` [PATCH v2 4/5] arm64: dts: imx8mp-venice-gw74xx: add cpu-supply node for cpufreq Tim Harvey
@ 2022-09-12 18:08 ` Tim Harvey
  2022-09-13  2:24 ` [PATCH v2 1/5] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity Shawn Guo
  4 siblings, 0 replies; 6+ messages in thread
From: Tim Harvey @ 2022-09-12 18:08 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel, devicetree
  Cc: NXP Linux Team, Fabio Estevam, Pengutronix Kernel Team,
	Sascha Hauer, Shawn Guo, Krzysztof Kozlowski, Rob Herring,
	Tim Harvey

The GW74xx supports an on-board Laird Connectivity Sterling LWB5+ module
which uses a Cypress CYW4373W chip to provide 1x1 802.11 a/b/g/n/ac +
Bluetooth 5.2.

Add the proper device-tree nodes for it.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
v2: no changes
---
 .../dts/freescale/imx8mp-venice-gw74xx.dts    | 62 ++++++++++++++++++-
 1 file changed, 59 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index 066a4afaf8a1..a2b32275bbf9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -134,10 +134,10 @@ reg_wifi_en: regulator-wifi-en {
 		compatible = "regulator-fixed";
 		regulator-name = "wl";
 		gpio = <&gpio3 9 GPIO_ACTIVE_HIGH>;
-		startup-delay-us = <100>;
+		startup-delay-us = <70000>;
 		enable-active-high;
-		regulator-min-microvolt = <1800000>;
-		regulator-max-microvolt = <1800000>;
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
 	};
 };
 
@@ -576,6 +576,21 @@ &uart2 {
 	status = "okay";
 };
 
+/* bluetooth HCI */
+&uart3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>;
+	cts-gpios = <&gpio3 21 GPIO_ACTIVE_LOW>;
+	rts-gpios = <&gpio3 22 GPIO_ACTIVE_LOW>;
+	uart-has-rtscts;
+	status = "okay";
+
+	bluetooth {
+		compatible = "brcm,bcm4330-bt";
+		shutdown-gpios = <&gpio3 8 GPIO_ACTIVE_HIGH>;
+	};
+};
+
 &uart4 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart4>;
@@ -616,6 +631,25 @@ &usb_dwc3_1 {
 	status = "okay";
 };
 
+/* SDIO WiFi */
+&usdhc1 {
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc1>;
+	pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
+	bus-width = <4>;
+	non-removable;
+	vmmc-supply = <&reg_wifi_en>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+	status = "okay";
+
+	wifi@0 {
+		compatible = "cypress,cyw4373-fmac";
+		reg = <0>;
+	};
+};
+
 /* eMMC */
 &usdhc3 {
 	assigned-clocks = <&clk IMX8MP_CLK_USDHC3>;
@@ -860,6 +894,28 @@ MX8MP_IOMUXC_SD1_DATA3__USDHC1_DATA3	0x1d0
 		>;
 	};
 
+	pinctrl_usdhc1_100mhz: usdhc1-100mhzgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD1_CLK__USDHC1_CLK	0x194
+			MX8MP_IOMUXC_SD1_CMD__USDHC1_CMD	0x1d4
+			MX8MP_IOMUXC_SD1_DATA0__USDHC1_DATA0	0x1d4
+			MX8MP_IOMUXC_SD1_DATA1__USDHC1_DATA1	0x1d4
+			MX8MP_IOMUXC_SD1_DATA2__USDHC1_DATA2	0x1d4
+			MX8MP_IOMUXC_SD1_DATA3__USDHC1_DATA3	0x1d4
+		>;
+	};
+
+	pinctrl_usdhc1_200mhz: usdhc1-200mhzgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD1_CLK__USDHC1_CLK	0x196
+			MX8MP_IOMUXC_SD1_CMD__USDHC1_CMD	0x1d6
+			MX8MP_IOMUXC_SD1_DATA0__USDHC1_DATA0	0x1d6
+			MX8MP_IOMUXC_SD1_DATA1__USDHC1_DATA1	0x1d6
+			MX8MP_IOMUXC_SD1_DATA2__USDHC1_DATA2	0x1d6
+			MX8MP_IOMUXC_SD1_DATA3__USDHC1_DATA3	0x1d6
+		>;
+	};
+
 	pinctrl_usdhc3: usdhc3grp {
 		fsl,pins = <
 			MX8MP_IOMUXC_NAND_WE_B__USDHC3_CLK	0x190
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/5] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity
  2022-09-12 18:08 [PATCH v2 1/5] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity Tim Harvey
                   ` (3 preceding siblings ...)
  2022-09-12 18:08 ` [PATCH v2 5/5] arm64: dts: imx8mp-venice-gw74xx: add WiFi/BT module support Tim Harvey
@ 2022-09-13  2:24 ` Shawn Guo
  4 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2022-09-13  2:24 UTC (permalink / raw)
  To: Tim Harvey
  Cc: linux-arm-kernel, linux-kernel, devicetree, NXP Linux Team,
	Fabio Estevam, Pengutronix Kernel Team, Sascha Hauer,
	Krzysztof Kozlowski, Rob Herring

On Mon, Sep 12, 2022 at 11:08:32AM -0700, Tim Harvey wrote:
> The CAN STBY poarlity is active-low. Specify it as such by removing the
> 'enable-active-high' property and updating the gpio property.
> 
> Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts support")
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>

Applied all, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-09-13  2:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-12 18:08 [PATCH v2 1/5] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity Tim Harvey
2022-09-12 18:08 ` [PATCH v2 2/5] arm64: dts: imx8mp-venice-gw74xx: fix ksz9477 cpu port Tim Harvey
2022-09-12 18:08 ` [PATCH v2 3/5] arm64: dts: imx8mp-venice-gw74xx: fix port/phy validation Tim Harvey
2022-09-12 18:08 ` [PATCH v2 4/5] arm64: dts: imx8mp-venice-gw74xx: add cpu-supply node for cpufreq Tim Harvey
2022-09-12 18:08 ` [PATCH v2 5/5] arm64: dts: imx8mp-venice-gw74xx: add WiFi/BT module support Tim Harvey
2022-09-13  2:24 ` [PATCH v2 1/5] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).